langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 20:45:26 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31704] fix: convert HTTP method to lowercase when parsing cURL commands #33357

New Issue
Closed
opened 2026-02-21 20:53:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:08 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31704

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

#31703
Fixes the HTTP node cURL import functionality where HTTP methods (POST, PUT, PATCH, DELETE, etc.) were incorrectly parsed as GET.

Root cause: When parsing cURL commands with -X POST (or other methods), the parser extracted the method as uppercase (e.g., "POST"), but the Method enum uses lowercase values (e.g., 'post'). This mismatch caused the method to fall back to the default GET.

Solution: Added .toLowerCase() when parsing the HTTP method from the -X or --request parameter to ensure it matches the Method enum values.

Changes:

  • Modified web/app/components/workflow/nodes/http/components/curl-panel.tsx line 42
  • Added .toLowerCase() to convert parsed method to lowercase before type casting

Testing:
Verified with cURL commands using POST, PUT, PATCH, and DELETE methods:

POST - now works ✅

curl -X POST 'https://api.example.com/endpoint' -d '{"key": "value"}'

PUT - now works ✅

curl -X PUT 'https://api.example.com/endpoint/123' -d '{"key": "updated"}'

PATCH - now works ✅

curl -X PATCH 'https://api.example.com/endpoint/123' -d '{"key": "patched"}'

DELETE - now works ✅

curl -X DELETE 'https://api.example.com/endpoint/123'All methods are now correctly parsed instead of defaulting to GET.

Screenshots

Before After
Importing curl -X POST ... resulted in method being set to GET Importing curl -X POST ... correctly sets method to POST

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/31704 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary #31703 Fixes the HTTP node cURL import functionality where HTTP methods (POST, PUT, PATCH, DELETE, etc.) were incorrectly parsed as GET. **Root cause:** When parsing cURL commands with `-X POST` (or other methods), the parser extracted the method as uppercase (e.g., `"POST"`), but the `Method` enum uses lowercase values (e.g., `'post'`). This mismatch caused the method to fall back to the default `GET`. **Solution:** Added `.toLowerCase()` when parsing the HTTP method from the `-X` or `--request` parameter to ensure it matches the `Method` enum values. **Changes:** - Modified `web/app/components/workflow/nodes/http/components/curl-panel.tsx` line 42 - Added `.toLowerCase()` to convert parsed method to lowercase before type casting **Testing:** Verified with cURL commands using POST, PUT, PATCH, and DELETE methods: # POST - now works ✅ curl -X POST 'https://api.example.com/endpoint' -d '{"key": "value"}' # PUT - now works ✅ curl -X PUT 'https://api.example.com/endpoint/123' -d '{"key": "updated"}' # PATCH - now works ✅ curl -X PATCH 'https://api.example.com/endpoint/123' -d '{"key": "patched"}' # DELETE - now works ✅ curl -X DELETE 'https://api.example.com/endpoint/123'All methods are now correctly parsed instead of defaulting to `GET`. ## Screenshots | Before | After | |--------|-------| | Importing `curl -X POST ...` resulted in method being set to `GET` | Importing `curl -X POST ...` correctly sets method to `POST` | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:53:08 -05:00
yindo closed this issue 2026-02-21 20:53:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33357
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?