langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31707] refactor(datasets): extract hooks and components with comprehensive tests #33358

New Issue
Closed
opened 2026-02-21 20:53:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:08 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31707

State: closed
Merged: Yes

Summary

  • Refactor datasets form component: Extract useFormState hook and split into BasicInfoSection, IndexingSection, ExternalKnowledgeSection components
  • Implement local-file upload: Add LocalFile component with useLocalFileUpload hook, UploadDropzone and FileListItem UI components
  • Refactor create-from-dsl-modal: Extract useDSLImport hook, reduce component complexity from 63 to 3
  • Refactor file-uploader: Extract useFileUpload hook and UI components, reduce from 399 to 90 lines
  • Add shared utility: Add getFileExtension to @/utils/format.ts for reuse
    Test plan

[x] 164 tests for datasets/settings/form (97%+ coverage)
[x] 879+ tests for local-file-upload hooks and components
[x] 35 tests for create-from-dsl-modal hook (98%+ coverage)
[x] 102 tests for file-uploader (100% coverage)

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/31707 **State:** closed **Merged:** Yes --- ## Summary - Refactor datasets form component: Extract useFormState hook and split into BasicInfoSection, IndexingSection, ExternalKnowledgeSection components - Implement local-file upload: Add LocalFile component with useLocalFileUpload hook, UploadDropzone and FileListItem UI components - Refactor create-from-dsl-modal: Extract useDSLImport hook, reduce component complexity from 63 to 3 - Refactor file-uploader: Extract useFileUpload hook and UI components, reduce from 399 to 90 lines - Add shared utility: Add getFileExtension to @/utils/format.ts for reuse Test plan [x] 164 tests for datasets/settings/form (97%+ coverage) [x] 879+ tests for local-file-upload hooks and components [x] 35 tests for create-from-dsl-modal hook (98%+ coverage) [x] 102 tests for file-uploader (100% coverage) ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:53:08 -05:00
yindo closed this issue 2026-02-21 20:53:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33358
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?