langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31699] fix(web): remove unwanted border on sticky elements in dark mode #33359

New Issue
Closed
opened 2026-02-21 20:53:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:08 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31699

State: closed
Merged: Yes

Summary

Fixes #31137

close #31419

The CSS in monaco-sticky-fix.css was applying border-bottom to ALL .sticky and .is-sticky elements in dark mode, causing unwanted borders on tabs and other UI elements that should remain borderless.

Changes

Changed the overly broad CSS selector to only target Monaco editor specific sticky elements, ensuring consistent styling between light and dark modes.

Before

The fallback CSS was:

html[data-theme="dark"] .sticky, html[data-theme="dark"] .is-sticky {
  background-color: var(--color-components-sticky-header-bg) !important;
  border-bottom: 1px solid var(--color-components-sticky-header-border) !important;
}

This applied unwanted borders to:

  • Tab sections
  • Settings title
  • Other sticky UI elements

After

html[data-theme="dark"] .monaco-editor .sticky-line-root {
  background-color: var(--color-components-sticky-header-bg) !important;
}

Now only Monaco editor sticky elements receive the dark mode styling.

Testing

  • Verified tabs no longer have unwanted borders in dark mode
  • Monaco editor sticky scroll still works correctly
**Original Pull Request:** https://github.com/langgenius/dify/pull/31699 **State:** closed **Merged:** Yes --- ## Summary Fixes #31137 close #31419 The CSS in `monaco-sticky-fix.css` was applying `border-bottom` to ALL `.sticky` and `.is-sticky` elements in dark mode, causing unwanted borders on tabs and other UI elements that should remain borderless. ## Changes Changed the overly broad CSS selector to only target Monaco editor specific sticky elements, ensuring consistent styling between light and dark modes. ## Before The fallback CSS was: ```css html[data-theme="dark"] .sticky, html[data-theme="dark"] .is-sticky { background-color: var(--color-components-sticky-header-bg) !important; border-bottom: 1px solid var(--color-components-sticky-header-border) !important; } ``` This applied unwanted borders to: - Tab sections - Settings title - Other sticky UI elements ## After ```css html[data-theme="dark"] .monaco-editor .sticky-line-root { background-color: var(--color-components-sticky-header-bg) !important; } ``` Now only Monaco editor sticky elements receive the dark mode styling. ## Testing - Verified tabs no longer have unwanted borders in dark mode - Monaco editor sticky scroll still works correctly
yindo added the pull-request label 2026-02-21 20:53:08 -05:00
yindo closed this issue 2026-02-21 20:53:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?