langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31792] refactor(typing): use enum types for workflow status fields #33411

New Issue
Closed
opened 2026-02-21 20:53:14 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:14 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31792

State: closed
Merged: Yes

Summary

  • Replace status: str with status: WorkflowExecutionStatus in WorkflowFinishStreamResponse.Data and WorkflowAppBlockingResponse.Data
  • Replace status: str with status: WorkflowNodeExecutionStatus in NodeFinishStreamResponse.Data and NodeRetryStreamResponse.Data
  • Remove unnecessary .value calls at assignment sites in WorkflowResponseConverter, passing enum instances directly

This aligns these four response classes with the existing pattern already used by IterationNodeCompletedStreamResponse and LoopNodeCompletedStreamResponse, which correctly use enum type annotations. Since both enums are StrEnum, JSON serialization behavior is unchanged.

Test plan

  • Verified imports succeed
  • Verified Pydantic model_dump() and json.dumps() produce identical string output with StrEnum fields
  • Pre-commit linter checks passed
  • Confirm existing workflow/node stream response tests pass in CI
**Original Pull Request:** https://github.com/langgenius/dify/pull/31792 **State:** closed **Merged:** Yes --- ## Summary - Replace `status: str` with `status: WorkflowExecutionStatus` in `WorkflowFinishStreamResponse.Data` and `WorkflowAppBlockingResponse.Data` - Replace `status: str` with `status: WorkflowNodeExecutionStatus` in `NodeFinishStreamResponse.Data` and `NodeRetryStreamResponse.Data` - Remove unnecessary `.value` calls at assignment sites in `WorkflowResponseConverter`, passing enum instances directly This aligns these four response classes with the existing pattern already used by `IterationNodeCompletedStreamResponse` and `LoopNodeCompletedStreamResponse`, which correctly use enum type annotations. Since both enums are `StrEnum`, JSON serialization behavior is unchanged. ## Test plan - [x] Verified imports succeed - [x] Verified Pydantic `model_dump()` and `json.dumps()` produce identical string output with `StrEnum` fields - [x] Pre-commit linter checks passed - [ ] Confirm existing workflow/node stream response tests pass in CI
yindo added the pull-request label 2026-02-21 20:53:14 -05:00
yindo closed this issue 2026-02-21 20:53:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?