langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31801] refactor!: SSR prefetch + replace Zustand with TanStack Query for systemFeatures #33413

New Issue
Closed
opened 2026-02-21 20:53:14 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:14 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31801

State: closed
Merged: No

Summary

  • SSR Prefetch: Migrate (commonLayout) to async Server Component with TanStack Query prefetchQuery + HydrationBoundary for user profile and workspace data, replacing client-side splash screen with Next.js loading.tsx convention
  • Zustand Removal: Replace useGlobalPublicStore Zustand store with direct TanStack Query hooks (useSystemFeatures, useSystemFeaturesQuery, useIsSystemFeaturesPending, useSetupStatusQuery) in hooks/use-global-public.ts, eliminating the query→store sync middleman
  • Shared SSR utilities: Extract utils/ssr-fetch.ts with React.cache()-wrapped getAuthHeaders for per-request deduplication across server components
  • Fix SetupStatusResponse.setup_at type from Date to string to match JSON API response
  • Fix setup-status.spec.ts mock target to match actual consoleClient usage

Test plan

  • Verify /apps page loads with SSR-prefetched data (no client-side loading flash)
  • Verify loading.tsx shows correctly during navigation
  • Verify all useSystemFeatures() consumers work correctly (plugin permissions, marketplace, branding, collaboration features)
  • Verify sign-in/sign-up flows still work (systemFeatures used for SSO/branding)
  • Run pnpm type-check:tsgo — passes
  • Run pnpm test for affected spec files — all pass

Breaking Changes

useGlobalPublicStore is removed. Use useSystemFeatures() from @/hooks/use-global-public instead.

**Original Pull Request:** https://github.com/langgenius/dify/pull/31801 **State:** closed **Merged:** No --- ## Summary - **SSR Prefetch**: Migrate `(commonLayout)` to async Server Component with TanStack Query `prefetchQuery` + `HydrationBoundary` for user profile and workspace data, replacing client-side splash screen with Next.js `loading.tsx` convention - **Zustand Removal**: Replace `useGlobalPublicStore` Zustand store with direct TanStack Query hooks (`useSystemFeatures`, `useSystemFeaturesQuery`, `useIsSystemFeaturesPending`, `useSetupStatusQuery`) in `hooks/use-global-public.ts`, eliminating the query→store sync middleman - **Shared SSR utilities**: Extract `utils/ssr-fetch.ts` with `React.cache()`-wrapped `getAuthHeaders` for per-request deduplication across server components - Fix `SetupStatusResponse.setup_at` type from `Date` to `string` to match JSON API response - Fix `setup-status.spec.ts` mock target to match actual `consoleClient` usage ## Test plan - [ ] Verify `/apps` page loads with SSR-prefetched data (no client-side loading flash) - [ ] Verify `loading.tsx` shows correctly during navigation - [ ] Verify all `useSystemFeatures()` consumers work correctly (plugin permissions, marketplace, branding, collaboration features) - [ ] Verify sign-in/sign-up flows still work (systemFeatures used for SSO/branding) - [ ] Run `pnpm type-check:tsgo` — passes - [ ] Run `pnpm test` for affected spec files — all pass ## Breaking Changes `useGlobalPublicStore` is removed. Use `useSystemFeatures()` from `@/hooks/use-global-public` instead.
yindo added the pull-request label 2026-02-21 20:53:14 -05:00
yindo closed this issue 2026-02-21 20:53:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?