langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31877] refactor: replace line-clamp package with native CSS #33448

New Issue
Closed
opened 2026-02-21 20:53:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31877

State: closed
Merged: Yes

Summary

Partially addresses #31875

Replaces the JavaScript-based line-clamp npm package with Tailwind's native line-clamp-4 CSS utility class.

Changes

  • Removed line-clamp dependency from web/package.json
  • Updated edit-slice.tsx to use Tailwind's line-clamp-4 utility instead of the JS-based approach

Why

  • The line-clamp package uses JavaScript DOM manipulation to truncate text
  • Modern CSS line-clamp (via -webkit-line-clamp) is well-supported across all browsers
  • The codebase already uses Tailwind's line-clamp-* utilities in 50+ other places
  • CSS approach is more performant - no JavaScript runtime manipulation needed

Test Plan

  1. Navigate to a dataset document that uses the formatted text component
  2. Verify text is properly truncated to 4 lines
  3. Verify the edit slice renders correctly with the floating element reference
**Original Pull Request:** https://github.com/langgenius/dify/pull/31877 **State:** closed **Merged:** Yes --- ## Summary Partially addresses #31875 Replaces the JavaScript-based `line-clamp` npm package with Tailwind's native `line-clamp-4` CSS utility class. ## Changes - Removed `line-clamp` dependency from `web/package.json` - Updated `edit-slice.tsx` to use Tailwind's `line-clamp-4` utility instead of the JS-based approach ## Why - The `line-clamp` package uses JavaScript DOM manipulation to truncate text - Modern CSS `line-clamp` (via `-webkit-line-clamp`) is well-supported across all browsers - The codebase already uses Tailwind's `line-clamp-*` utilities in 50+ other places - CSS approach is more performant - no JavaScript runtime manipulation needed ## Test Plan 1. Navigate to a dataset document that uses the formatted text component 2. Verify text is properly truncated to 4 lines 3. Verify the edit slice renders correctly with the floating element reference
yindo added the pull-request label 2026-02-21 20:53:18 -05:00
yindo closed this issue 2026-02-21 20:53:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33448
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?