langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31955] fix: dynamically update image URLs in agent_thoughts with valid signatures #33485

New Issue
Open
opened 2026-02-21 20:53:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:22 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31955

State: open
Merged: No

Fixes #31907.

Description

Currently, image URLs in agent_thoughts.thought and agent_thoughts.observation have static signatures that expire after ~10 minutes. This PR adds dynamic re-signing logic to these fields, consistent with how the answer field is handled in the Message model.

Changes

  • Added _re_sign_file_url helper and related properties (re_sign_file_url_thought, re_sign_file_url_observation) to MessageAgentThought model.
  • Updated AgentThought Pydantic schema to use these properties via validation_alias.

This is a more lightweight approach compared to other proposed fixes, focusing on the core issue of signature expiration in API responses.

Fixes #31907

**Original Pull Request:** https://github.com/langgenius/dify/pull/31955 **State:** open **Merged:** No --- Fixes #31907. ### Description Currently, image URLs in `agent_thoughts.thought` and `agent_thoughts.observation` have static signatures that expire after ~10 minutes. This PR adds dynamic re-signing logic to these fields, consistent with how the `answer` field is handled in the `Message` model. ### Changes - Added `_re_sign_file_url` helper and related properties (`re_sign_file_url_thought`, `re_sign_file_url_observation`) to `MessageAgentThought` model. - Updated `AgentThought` Pydantic schema to use these properties via `validation_alias`. This is a more lightweight approach compared to other proposed fixes, focusing on the core issue of signature expiration in API responses. Fixes #31907
yindo added the pull-request label 2026-02-21 20:53:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?