langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32058] fix: correct mock return type in CodeBasedExtension test #33528

New Issue
Open
opened 2026-02-21 20:53:26 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:26 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32058

State: open
Merged: No

Summary

  • Fix test_code_based_extension_get_returns_service_data to mock CodeBasedExtensionService.get_code_based_extension with a list[dict] instead of a plain dict, matching the actual service return type.

Fixes #31864

Test plan

  • Verified the actual service (api/services/code_based_extension_service.py) returns a list comprehension (list[dict])
  • Updated mock return value from {"entrypoint": "main:agent"} to [{"entrypoint": "main:agent"}]
  • Assertion already references service_result by variable, so it automatically validates the correct type
  • Pre-commit hooks (Ruff linter) pass
**Original Pull Request:** https://github.com/langgenius/dify/pull/32058 **State:** open **Merged:** No --- ## Summary - Fix `test_code_based_extension_get_returns_service_data` to mock `CodeBasedExtensionService.get_code_based_extension` with a `list[dict]` instead of a plain `dict`, matching the actual service return type. Fixes #31864 ## Test plan - [x] Verified the actual service (`api/services/code_based_extension_service.py`) returns a list comprehension (`list[dict]`) - [x] Updated mock return value from `{"entrypoint": "main:agent"}` to `[{"entrypoint": "main:agent"}]` - [x] Assertion already references `service_result` by variable, so it automatically validates the correct type - [x] Pre-commit hooks (Ruff linter) pass
yindo added the pull-request label 2026-02-21 20:53:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33528
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?