langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 21:15:32 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32063] refactor: extract hooks and add tests for text-generation Result component #33532

New Issue
Closed
opened 2026-02-21 20:53:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:27 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32063

State: closed
Merged: No

Summary

Refactor the Result component (web/app/components/share/text-generation/result/index.tsx): Reduced complexity from 86/100 to ~20/100 and lines from 608 to ~130 by extracting all state management, side effects, and business logic into a custom useTextGeneration hook, and extracting workflow SSE event handlers into a createWorkflowCallbacks factory function.
Reorganize file structure: Moved sub-components (header.tsx, content.tsx) into a components/ subdirectory and created a hooks/ subdirectory for the extracted use-text-generation.ts and workflow-callbacks.ts, improving module separation.
Add comprehensive test coverage: Created test suites for all refactored modules (index.spec.tsx, use-text-generation.spec.ts, workflow-callbacks.spec.ts) achieving 99.6% statement, 97.1% branch, 98.4% function, and 100% line coverage for the hooks directory. Tests cover handleStop with active tasks, SSE callback handling, timeout scenarios, file processing, validation edge cases, markNodesStopped recursive traversal, and workflow lifecycle events.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/32063 **State:** closed **Merged:** No --- ## Summary Refactor the Result component (web/app/components/share/text-generation/result/index.tsx): Reduced complexity from 86/100 to ~20/100 and lines from 608 to ~130 by extracting all state management, side effects, and business logic into a custom useTextGeneration hook, and extracting workflow SSE event handlers into a createWorkflowCallbacks factory function. Reorganize file structure: Moved sub-components (header.tsx, content.tsx) into a components/ subdirectory and created a hooks/ subdirectory for the extracted use-text-generation.ts and workflow-callbacks.ts, improving module separation. Add comprehensive test coverage: Created test suites for all refactored modules (index.spec.tsx, use-text-generation.spec.ts, workflow-callbacks.spec.ts) achieving 99.6% statement, 97.1% branch, 98.4% function, and 100% line coverage for the hooks directory. Tests cover handleStop with active tasks, SSE callback handling, timeout scenarios, file processing, validation edge cases, markNodesStopped recursive traversal, and workflow lifecycle events. ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:53:27 -05:00
yindo closed this issue 2026-02-21 20:53:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?