langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-19 08:35:20 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32071] refactor: decouple workflow knowledge access via repository injection #33533

New Issue
Closed
opened 2026-02-21 20:53:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:27 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32071

State: closed
Merged: No

Summary

  • Introduce a knowledge repository protocol with a SQLAlchemy implementation that is tenant-scoped and uses per-call sessions.
  • Inject repositories into workflow and pipeline execution paths, including single-step runs and sub-graph execution.
  • Refactor KnowledgeRetrievalNode to use repository access and add focused unit coverage.

Testing

  • make lint
  • uv run --directory api --dev -- basedpyright --threads 8
  • uv --directory api run mypy --exclude-gitignore --exclude 'tests/' --exclude 'migrations/' --check-untyped-defs --disable-error-code=import-untyped .
  • uv --directory api run ty check
  • uv run --project api pytest api/tests/unit_tests/core/workflow api/tests/unit_tests/core/app/apps -q

Related Issue

Part of #30269.
Implements the Repository pattern to decouple the Graph Engine from Flask-SQLAlchemy, setting the stage for the FastAPI migration.

**Original Pull Request:** https://github.com/langgenius/dify/pull/32071 **State:** closed **Merged:** No --- ## Summary - Introduce a knowledge repository protocol with a SQLAlchemy implementation that is tenant-scoped and uses per-call sessions. - Inject repositories into workflow and pipeline execution paths, including single-step runs and sub-graph execution. - Refactor KnowledgeRetrievalNode to use repository access and add focused unit coverage. ## Testing - make lint - uv run --directory api --dev -- basedpyright --threads 8 - uv --directory api run mypy --exclude-gitignore --exclude 'tests/' --exclude 'migrations/' --check-untyped-defs --disable-error-code=import-untyped . - uv --directory api run ty check - uv run --project api pytest api/tests/unit_tests/core/workflow api/tests/unit_tests/core/app/apps -q ### Related Issue Part of #30269. Implements the Repository pattern to decouple the Graph Engine from Flask-SQLAlchemy, setting the stage for the FastAPI migration.
yindo added the pull-request label 2026-02-21 20:53:27 -05:00
yindo closed this issue 2026-02-21 20:53:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33533
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?