langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32088] fix: replace sendBeacon with fetch keepalive for autosave on page close #33542

New Issue
Closed
opened 2026-02-21 20:53:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:28 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32088

State: closed
Merged: Yes

Summary

  • Replaces navigator.sendBeacon with fetch using keepalive: true for autosave when the user switches tabs or closes the page.
  • sendBeacon has a hard 64KB payload size limit in browsers. When workflow data exceeds this (e.g. workflows with file variables or many nodes), the autosave request silently fails, causing data loss.
  • fetch with keepalive: true provides the same fire-and-forget behavior during page unload but supports larger payloads.
  • Updated both workflow and RAG pipeline sync draft hooks, plus corresponding tests.

Changes

  • web/app/components/workflow-app/hooks/use-nodes-sync-draft.ts - replaced sendBeacon with fetch + keepalive
  • web/app/components/rag-pipeline/hooks/use-nodes-sync-draft.ts - replaced sendBeacon with fetch + keepalive
  • web/app/components/rag-pipeline/hooks/use-nodes-sync-draft.spec.ts - updated tests to mock fetch instead of sendBeacon

Test plan

  • All 20 existing rag-pipeline sync draft tests pass
  • Verify autosave works on tab switch with workflows that have large payloads (>64KB)

Closes #32030

**Original Pull Request:** https://github.com/langgenius/dify/pull/32088 **State:** closed **Merged:** Yes --- ## Summary - Replaces `navigator.sendBeacon` with `fetch` using `keepalive: true` for autosave when the user switches tabs or closes the page. - `sendBeacon` has a hard 64KB payload size limit in browsers. When workflow data exceeds this (e.g. workflows with file variables or many nodes), the autosave request silently fails, causing data loss. - `fetch` with `keepalive: true` provides the same fire-and-forget behavior during page unload but supports larger payloads. - Updated both workflow and RAG pipeline sync draft hooks, plus corresponding tests. ## Changes - `web/app/components/workflow-app/hooks/use-nodes-sync-draft.ts` - replaced `sendBeacon` with `fetch` + `keepalive` - `web/app/components/rag-pipeline/hooks/use-nodes-sync-draft.ts` - replaced `sendBeacon` with `fetch` + `keepalive` - `web/app/components/rag-pipeline/hooks/use-nodes-sync-draft.spec.ts` - updated tests to mock `fetch` instead of `sendBeacon` ## Test plan - [x] All 20 existing rag-pipeline sync draft tests pass - [ ] Verify autosave works on tab switch with workflows that have large payloads (>64KB) Closes #32030
yindo added the pull-request label 2026-02-21 20:53:28 -05:00
yindo closed this issue 2026-02-21 20:53:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33542
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?