langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32091] fix: prevent full-page loading when switching tabs in app detail #33546

New Issue
Open
opened 2026-02-21 20:53:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:28 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32091

State: open
Merged: No

Summary

Fixes #31171

When switching between tabs (e.g., Orchestrate, API Access, Logs, Overview) in the app detail view, the entire page would flash a full-screen loading spinner. This happened because:

  1. The fetch useEffect had pathname in its dependency array, so every tab switch triggered a re-fetch
  2. Before re-fetching, setAppDetail() was called with no arguments, clearing the app detail state to undefined
  3. The render guard if (!appDetail) then showed the full-page <Loading /> component

Changes

  • Remove pathname from the fetch effect's dependency array ([appId, pathname] -> [appId]): App details only need to be fetched when the appId changes, not on every tab navigation within the same app.
  • Add pathname to the redirection effect's dependency array: The redirection logic (permission checks and mode-based redirects) uses pathname to determine if the user should be redirected. Adding it as a dependency ensures these checks still run correctly when navigating between tabs.

Before

Switching tabs clears appDetail -> full-page loading spinner -> re-fetch -> restore. The entire tab content disappears momentarily.

After

Switching tabs preserves the existing appDetail state. Only the content area updates. No full-page loading flash.

Test plan

  • Open any app in the Dify dashboard
  • Switch between tabs (Orchestrate/Workflow, API Access, Logs, Overview)
  • Verify no full-page loading spinner appears when switching tabs
  • Verify the sidebar navigation remains visible during tab switches
  • Navigate to a different app and verify the loading state still shows correctly on initial load
  • Verify that permission-based redirects still work (non-editor user accessing restricted tabs gets redirected to Overview)
**Original Pull Request:** https://github.com/langgenius/dify/pull/32091 **State:** open **Merged:** No --- ## Summary Fixes #31171 When switching between tabs (e.g., Orchestrate, API Access, Logs, Overview) in the app detail view, the entire page would flash a full-screen loading spinner. This happened because: 1. The fetch `useEffect` had `pathname` in its dependency array, so every tab switch triggered a re-fetch 2. Before re-fetching, `setAppDetail()` was called with no arguments, clearing the app detail state to `undefined` 3. The render guard `if (!appDetail)` then showed the full-page `<Loading />` component ### Changes - **Remove `pathname` from the fetch effect's dependency array** (`[appId, pathname]` -> `[appId]`): App details only need to be fetched when the `appId` changes, not on every tab navigation within the same app. - **Add `pathname` to the redirection effect's dependency array**: The redirection logic (permission checks and mode-based redirects) uses `pathname` to determine if the user should be redirected. Adding it as a dependency ensures these checks still run correctly when navigating between tabs. ### Before Switching tabs clears `appDetail` -> full-page loading spinner -> re-fetch -> restore. The entire tab content disappears momentarily. ### After Switching tabs preserves the existing `appDetail` state. Only the content area updates. No full-page loading flash. ## Test plan - [ ] Open any app in the Dify dashboard - [ ] Switch between tabs (Orchestrate/Workflow, API Access, Logs, Overview) - [ ] Verify no full-page loading spinner appears when switching tabs - [ ] Verify the sidebar navigation remains visible during tab switches - [ ] Navigate to a different app and verify the loading state still shows correctly on initial load - [ ] Verify that permission-based redirects still work (non-editor user accessing restricted tabs gets redirected to Overview)
yindo added the pull-request label 2026-02-21 20:53:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33546
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?