langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32109] fix(service_api): register rag pipeline service API routes #33552

New Issue
Closed
opened 2026-02-21 20:53:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:29 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32109

State: closed
Merged: No

Summary

  • fix 3 RAG pipeline service API routes to use Flask converter syntax (<uuid:...>, <string:...>)
  • import rag_pipeline_workflow in controllers.service_api so route decorators are evaluated and endpoints are registered under /v1
  • serialize created_at in /v1/datasets/pipeline/file-upload response to a Unix timestamp to avoid JSON serialization errors
  • add regression tests for both route registration and file-upload response serialization

Why

Two service API bugs were present in the same module:

  1. Pipeline endpoints under /v1/datasets/<dataset_id>/pipeline/... were not registered/usable due to route syntax + missing module import.
  2. File upload endpoint returned a raw datetime (created_at) which can trigger TypeError: Object of type datetime is not JSON serializable.

Fixes #32099
Fixes #32100

Testing

  • uv run --project api --group dev ruff check api/controllers/service_api/__init__.py api/controllers/service_api/dataset/rag_pipeline/rag_pipeline_workflow.py api/tests/unit_tests/controllers/service_api/dataset/test_rag_pipeline_route_registration.py api/tests/unit_tests/controllers/service_api/dataset/test_rag_pipeline_file_upload_api.py
  • uv run --project api --group dev pytest api/tests/unit_tests/controllers/service_api/dataset/test_rag_pipeline_route_registration.py api/tests/unit_tests/controllers/service_api/dataset/test_rag_pipeline_file_upload_api.py -q
**Original Pull Request:** https://github.com/langgenius/dify/pull/32109 **State:** closed **Merged:** No --- ## Summary - fix 3 RAG pipeline service API routes to use Flask converter syntax (`<uuid:...>`, `<string:...>`) - import `rag_pipeline_workflow` in `controllers.service_api` so route decorators are evaluated and endpoints are registered under `/v1` - serialize `created_at` in `/v1/datasets/pipeline/file-upload` response to a Unix timestamp to avoid JSON serialization errors - add regression tests for both route registration and file-upload response serialization ## Why Two service API bugs were present in the same module: 1. Pipeline endpoints under `/v1/datasets/<dataset_id>/pipeline/...` were not registered/usable due to route syntax + missing module import. 2. File upload endpoint returned a raw `datetime` (`created_at`) which can trigger `TypeError: Object of type datetime is not JSON serializable`. Fixes #32099 Fixes #32100 ## Testing - `uv run --project api --group dev ruff check api/controllers/service_api/__init__.py api/controllers/service_api/dataset/rag_pipeline/rag_pipeline_workflow.py api/tests/unit_tests/controllers/service_api/dataset/test_rag_pipeline_route_registration.py api/tests/unit_tests/controllers/service_api/dataset/test_rag_pipeline_file_upload_api.py` - `uv run --project api --group dev pytest api/tests/unit_tests/controllers/service_api/dataset/test_rag_pipeline_route_registration.py api/tests/unit_tests/controllers/service_api/dataset/test_rag_pipeline_file_upload_api.py -q`
yindo added the pull-request label 2026-02-21 20:53:29 -05:00
yindo closed this issue 2026-02-21 20:53:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?