langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32118] fix: resolve file validation failure on file return for workflow-as-tool #33561

New Issue
Closed
opened 2026-02-21 20:53:30 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:30 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32118

State: closed
Merged: No

Fixes #32112

Summary

Bug

When a workflow is released as a tool and used elsewhere, it always raise validation error if the return value contains files.

Root Cause

The returned files are created via
https://github.com/langgenius/dify/blob/0428ac5f3aca02ebaeb3bedad866eb7957adf5a7/api/core/tools/__base/tool.py#L171-L176

While the class FileMessage has an attribute file_marker which would be validated before the model is instantiated and the default value assigned.
https://github.com/langgenius/dify/blob/0428ac5f3aca02ebaeb3bedad866eb7957adf5a7/api/core/tools/entities/tool_entities.py#L146-L154

Solution

I fix it by simply pass in the default parameter value explicitly.

Screenshots

Before After
bug2 fixed

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/32118 **State:** closed **Merged:** No --- Fixes #32112 ## Summary ### Bug When a workflow is released as a tool and used elsewhere, it always raise validation error if the return value contains files. ### Root Cause The returned files are created via https://github.com/langgenius/dify/blob/0428ac5f3aca02ebaeb3bedad866eb7957adf5a7/api/core/tools/__base/tool.py#L171-L176 While the class `FileMessage` has an attribute `file_marker` which would be validated **before** the model is instantiated and the default value assigned. https://github.com/langgenius/dify/blob/0428ac5f3aca02ebaeb3bedad866eb7957adf5a7/api/core/tools/entities/tool_entities.py#L146-L154 ### Solution I fix it by simply pass in the default parameter value explicitly. <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ## Screenshots | Before | After | |--------|-------| | <img width="2673" height="1008" alt="bug2" src="https://github.com/user-attachments/assets/fe80cc07-70be-49f9-81e2-f5846390c1bc" /> | <img width="2669" height="1026" alt="fixed" src="https://github.com/user-attachments/assets/f776ed85-62bf-4fd9-ae7a-be9003fafaf7" /> | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:53:30 -05:00
yindo closed this issue 2026-02-21 20:53:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?