langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32148] refactor(web): remove workspace mutate/loading from AppContext #33578

New Issue
Open
opened 2026-02-21 20:53:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:32 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32148

State: open
Merged: No

Summary

  • Remove mutateCurrentWorkspace and isValidatingCurrentWorkspace from AppContext, replacing with useInvalidateCurrentWorkspace() hook in the service layer (consistent with the project's useInvalidateXxx pattern)
  • Remove redundant useEffect + invalidateQueries in ModelProviderPage that caused QuotaPanel to flash a loading spinner on every settings tab switch
  • QuotaPanel now derives its loading state internally from !currentWorkspace.id instead of receiving an isLoading prop driven by isFetching

Test plan

  • vitest tests for custom-web-app-brand and apps-full-in-dialog pass (10/10)
  • TypeScript type check passes (tsgo --noEmit)
  • Verify QuotaPanel no longer flashes loading when switching settings tabs
  • Verify custom webapp brand logo upload/restore/switch still invalidates workspace data correctly
**Original Pull Request:** https://github.com/langgenius/dify/pull/32148 **State:** open **Merged:** No --- ## Summary - Remove `mutateCurrentWorkspace` and `isValidatingCurrentWorkspace` from `AppContext`, replacing with `useInvalidateCurrentWorkspace()` hook in the service layer (consistent with the project's `useInvalidateXxx` pattern) - Remove redundant `useEffect` + `invalidateQueries` in `ModelProviderPage` that caused QuotaPanel to flash a loading spinner on every settings tab switch - `QuotaPanel` now derives its loading state internally from `!currentWorkspace.id` instead of receiving an `isLoading` prop driven by `isFetching` ## Test plan - [x] `vitest` tests for `custom-web-app-brand` and `apps-full-in-dialog` pass (10/10) - [x] TypeScript type check passes (`tsgo --noEmit`) - [ ] Verify QuotaPanel no longer flashes loading when switching settings tabs - [ ] Verify custom webapp brand logo upload/restore/switch still invalidates workspace data correctly
yindo added the pull-request label 2026-02-21 20:53:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33578
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?