langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32163] refactor(api): tighten OTel decorator typing #33585

New Issue
Closed
opened 2026-02-21 20:53:33 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:33 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32163

State: closed
Merged: Yes

Context
This continues issue #25063 by removing Any from OTel decorator wrapper signatures while preserving runtime behavior and callable signatures.

What changed

  • Preserve wrapped function signatures in trace_span using ParamSpec.
  • Use concrete args/kwargs container types in SpanHandler and AppGenerateHandler to avoid invalid ParamSpec usage in non-variadic parameters.

Why
This eliminates Any in key typing hotspots without affecting behavior, and keeps the decorator contract precise and stable.

Issue
Fixes #25063

Checks run

  • uv run --project api make lint
  • uv run --project api make type-check
  • uv run --project api make test
**Original Pull Request:** https://github.com/langgenius/dify/pull/32163 **State:** closed **Merged:** Yes --- Context This continues issue #25063 by removing Any from OTel decorator wrapper signatures while preserving runtime behavior and callable signatures. What changed - Preserve wrapped function signatures in trace_span using ParamSpec. - Use concrete args/kwargs container types in SpanHandler and AppGenerateHandler to avoid invalid ParamSpec usage in non-variadic parameters. Why This eliminates Any in key typing hotspots without affecting behavior, and keeps the decorator contract precise and stable. Issue Fixes #25063 Checks run - uv run --project api make lint - uv run --project api make type-check - uv run --project api make test
yindo added the pull-request label 2026-02-21 20:53:33 -05:00
yindo closed this issue 2026-02-21 20:53:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33585
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?