langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32189] chore: remove unnecessary # type: ignore from request.args.to_dict() calls #33601

New Issue
Closed
opened 2026-02-21 20:53:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32189

State: closed
Merged: No

Summary

Remove 55 # type: ignore comments from 26 controller files where request.args.to_dict(flat=True) is passed to pydantic's model_validate().

Since model_validate() accepts Any as its first parameter, these type ignore suppressions are unnecessary and prevent proper type checking.

Pattern removed

# Before
args = SomeModel.model_validate(request.args.to_dict(flat=True))  # type: ignore

# After  
args = SomeModel.model_validate(request.args.to_dict(flat=True))

Changes

  • 26 files modified in api/controllers/ and api/events/
  • 55 # type: ignore comments removed (all following the same pattern)
  • No functional changes — purely type annotation cleanup

Relates to #24494

Disclosure: This PR was prepared with AI assistance for identifying the repetitive pattern across files.

**Original Pull Request:** https://github.com/langgenius/dify/pull/32189 **State:** closed **Merged:** No --- ## Summary Remove 55 `# type: ignore` comments from 26 controller files where `request.args.to_dict(flat=True)` is passed to pydantic's `model_validate()`. Since `model_validate()` accepts `Any` as its first parameter, these type ignore suppressions are unnecessary and prevent proper type checking. ## Pattern removed ```python # Before args = SomeModel.model_validate(request.args.to_dict(flat=True)) # type: ignore # After args = SomeModel.model_validate(request.args.to_dict(flat=True)) ``` ## Changes - 26 files modified in `api/controllers/` and `api/events/` - 55 `# type: ignore` comments removed (all following the same pattern) - No functional changes — purely type annotation cleanup Relates to #24494 **Disclosure**: This PR was prepared with AI assistance for identifying the repetitive pattern across files.
yindo added the pull-request label 2026-02-21 20:53:34 -05:00
yindo closed this issue 2026-02-21 20:53:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33601
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?