langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32209] fix: convert UUID to str in deleted_tools API provider check #33608

New Issue
Closed
opened 2026-02-21 20:53:35 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:35 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32209

State: closed
Merged: No

Summary

Fix a type mismatch bug where all API tool providers are incorrectly marked as deleted in the deleted_tools property.

Problem

api_provider.id returns a uuid.UUID object from SQLAlchemy, but provider_id from the app JSON config is a str. Since "abc" != UUID("abc") in Python, the in check always fails, causing every API tool to appear as "removed" in the UI.

Fix

Cast api_provider.id to str() so the type comparison works correctly.

existing_api_providers = [
-    api_provider.id
+    str(api_provider.id)
    for api_provider in session.execute(...)
]

Verification

As reported in the issue: before fix 44 tools marked deleted, after fix 0.

Closes #32205

Disclosure: AI-assisted identification of the fix pattern.

**Original Pull Request:** https://github.com/langgenius/dify/pull/32209 **State:** closed **Merged:** No --- ## Summary Fix a type mismatch bug where all API tool providers are incorrectly marked as deleted in the `deleted_tools` property. ## Problem `api_provider.id` returns a `uuid.UUID` object from SQLAlchemy, but `provider_id` from the app JSON config is a `str`. Since `"abc" != UUID("abc")` in Python, the `in` check always fails, causing every API tool to appear as "removed" in the UI. ## Fix Cast `api_provider.id` to `str()` so the type comparison works correctly. ```diff existing_api_providers = [ - api_provider.id + str(api_provider.id) for api_provider in session.execute(...) ] ``` ## Verification As reported in the issue: before fix 44 tools marked deleted, after fix 0. Closes #32205 **Disclosure**: AI-assisted identification of the fix pattern.
yindo added the pull-request label 2026-02-21 20:53:35 -05:00
yindo closed this issue 2026-02-21 20:53:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33608
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?