langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-24 22:11:36 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32225] fix(api): re-raise exceptions in MetadataService to prevent silent failures #33614

New Issue
Closed
opened 2026-02-21 20:53:36 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:36 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32225

State: closed
Merged: No

Fixes #31964

Summary

  • Five except Exception blocks in MetadataService were catching and logging errors without re-raising, so the API always returned HTTP 200 even when updates failed
  • Added db.session.rollback() and raise to all five blocks: update_documents_metadata, update_metadata_name, delete_metadata, enable_built_in_field, disable_built_in_field
  • Consolidated two separate db.session.commit() calls in update_documents_metadata into one for atomicity

Test plan

  • All 16 existing metadata unit tests pass
  • Verify batch metadata edit now returns error response on failure instead of false success
**Original Pull Request:** https://github.com/langgenius/dify/pull/32225 **State:** closed **Merged:** No --- Fixes #31964 ## Summary - Five `except Exception` blocks in `MetadataService` were catching and logging errors without re-raising, so the API always returned HTTP 200 even when updates failed - Added `db.session.rollback()` and `raise` to all five blocks: `update_documents_metadata`, `update_metadata_name`, `delete_metadata`, `enable_built_in_field`, `disable_built_in_field` - Consolidated two separate `db.session.commit()` calls in `update_documents_metadata` into one for atomicity ## Test plan - [x] All 16 existing metadata unit tests pass - [ ] Verify batch metadata edit now returns error response on failure instead of false success
yindo added the pull-request label 2026-02-21 20:53:36 -05:00
yindo closed this issue 2026-02-21 20:53:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?