langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32268] test(web): add and enhance frontend automated tests across multiple modules #33637

New Issue
Closed
opened 2026-02-21 20:53:38 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:38 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32268

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • Add comprehensive unit and integration tests for multiple frontend modules including
    billing, custom page, datasets, develop, explore, goto-anything, plugins/marketplace,
    plugin-auth, plugin-detail-panel, rag-pipeline, signin, tools, and workflow-app
  • Refactor existing test files: reduce redundant mocks, remove duplicated test logic,
    move spec files into __tests__/ directories to follow project conventions, and
    fix lint/type-check issues (no-explicit-any, import paths)
  • Extract reusable utility (tools/utils) to improve provider-list component testability

Changes by area

Module Key changes
billing Enhance styling checks, add edge case coverage
custom Move tests into __tests__/, add custom-page & custom-web-app-brand tests
datasets New tests for image-uploader, file-uploader, document list, metadata, hit-testing
plugins/marketplace Add atoms, state, query, hydration, hooks-integration, plugin-type-switch tests; consolidate mocks
plugin-auth / plugin-detail-panel Simplify and reduce over-mocked tests
rag-pipeline Add use-inspect-vars-crud hook tests; refactor FieldList tests
workflow-app Add workflow-header, onboarding-modal component tests; organize into __tests__/
tools Add provider-list integration tests; extract shared utils; simplify mcp-service-card tests
explore Expand app-list integration tests
signin Move countdown tests into __tests__/

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/32268 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary - Add comprehensive unit and integration tests for multiple frontend modules including billing, custom page, datasets, develop, explore, goto-anything, plugins/marketplace, plugin-auth, plugin-detail-panel, rag-pipeline, signin, tools, and workflow-app - Refactor existing test files: reduce redundant mocks, remove duplicated test logic, move spec files into `__tests__/` directories to follow project conventions, and fix lint/type-check issues (`no-explicit-any`, import paths) - Extract reusable utility (`tools/utils`) to improve provider-list component testability ## Changes by area | Module | Key changes | |--------|-------------| | billing | Enhance styling checks, add edge case coverage | | custom | Move tests into `__tests__/`, add custom-page & custom-web-app-brand tests | | datasets | New tests for image-uploader, file-uploader, document list, metadata, hit-testing | | plugins/marketplace | Add atoms, state, query, hydration, hooks-integration, plugin-type-switch tests; consolidate mocks | | plugin-auth / plugin-detail-panel | Simplify and reduce over-mocked tests | | rag-pipeline | Add use-inspect-vars-crud hook tests; refactor FieldList tests | | workflow-app | Add workflow-header, onboarding-modal component tests; organize into `__tests__/` | | tools | Add provider-list integration tests; extract shared utils; simplify mcp-service-card tests | | explore | Expand app-list integration tests | | signin | Move countdown tests into `__tests__/` | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:53:38 -05:00
yindo closed this issue 2026-02-21 20:53:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33637
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?