langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32287] fix: copy to clipboard failed in non-secure (HTTP) contexts #33651

New Issue
Open
opened 2026-02-21 20:53:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:40 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32287

State: open
Merged: No

Problem

The copy button (e.g., for API secret keys) becomes non-functional when Dify is accessed over an insecure HTTP connection (common in local network or private cloud deployments). This is due to navigator.clipboard being restricted to Secure Contexts.

This issue was reported in #32172 and observed in environments like Kylin Linux.

Solution

Added a robust fallback mechanism using a temporary textarea and document.execCommand('copy') when the primary copy library returns false.

  • Invisible Implementation: The temporary textarea is positioned off-screen (-9999px) to ensure no UI flickering or layout shift occurs during the operation.
  • Improved Compatibility: Ensures the copy function works across all deployment environments (HTTP/HTTPS) and specialized browsers.

Checklist

  • Verified the fallback logic works in non-HTTPS environments.
  • Confirmed no impact on existing HTTPS/localhost functionality.
  • Minimized code changes to avoid side effects.

Fixes #32172

**Original Pull Request:** https://github.com/langgenius/dify/pull/32287 **State:** open **Merged:** No --- ### Problem The copy button (e.g., for API secret keys) becomes non-functional when Dify is accessed over an insecure HTTP connection (common in local network or private cloud deployments). This is due to `navigator.clipboard` being restricted to Secure Contexts. This issue was reported in #32172 and observed in environments like Kylin Linux. ### Solution Added a robust fallback mechanism using a temporary `textarea` and `document.execCommand('copy')` when the primary copy library returns `false`. - **Invisible Implementation:** The temporary `textarea` is positioned off-screen (`-9999px`) to ensure no UI flickering or layout shift occurs during the operation. - **Improved Compatibility:** Ensures the copy function works across all deployment environments (HTTP/HTTPS) and specialized browsers. ### Checklist - [x] Verified the fallback logic works in non-HTTPS environments. - [x] Confirmed no impact on existing HTTPS/localhost functionality. - [x] Minimized code changes to avoid side effects. Fixes #32172
yindo added the pull-request label 2026-02-21 20:53:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33651
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?