langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32300] feat: configurable Enter/Shift+Enter send behavior in embedded chat (#32295) #33655

New Issue
Open
opened 2026-02-21 20:53:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:40 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32300

State: open
Merged: No

Summary

Adds a sendOnEnter option to control whether pressing Enter sends messages or inserts newlines in the embedded chat input.

Closes #32295

Problem

Japanese (and other CJK) IME users expect Enter to insert newlines when composing multi-line messages. Currently, Enter always sends the message, causing accidental sends — especially problematic in production embedded chat deployments.

Solution

Added sendOnEnter prop that flows through ChatInputArea → Chat → ChatWrapper:

  • sendOnEnter=true (default): Enter sends, Shift+Enter inserts newline (existing behavior, no breaking change)
  • sendOnEnter=false: Enter inserts newline, Shift+Enter sends

Configuration

Embed script:

window.difyChatbotConfig = {
  token: 'your-token',
  sendOnEnter: false  // Enter = newline, Shift+Enter = send
}

URL parameter:

/chatbot/TOKEN?sendOnEnter=false

IME Handling

Existing compositionstart/compositionend event handling is preserved. Accidental sends during IME composition are prevented regardless of the sendOnEnter setting.

Changes

File Change
chat-input-area/index.tsx Added sendOnEnter prop; key combo logic now checks setting
chat/index.tsx Pass-through sendOnEnter prop to ChatInputArea
embedded-chatbot/chat-wrapper.tsx Read sendOnEnter from URL params
embed.js / embed.min.js Forward sendOnEnter config to iframe URL

Testing

  • Default behavior unchanged (Enter = send)
  • With sendOnEnter=false: Enter inserts newline, Shift+Enter sends
  • IME composition (Japanese/Korean/Chinese): no accidental sends in either mode
  • History navigation (Cmd+Up/Down) unaffected
**Original Pull Request:** https://github.com/langgenius/dify/pull/32300 **State:** open **Merged:** No --- ## Summary Adds a `sendOnEnter` option to control whether pressing Enter sends messages or inserts newlines in the embedded chat input. Closes #32295 ## Problem Japanese (and other CJK) IME users expect Enter to insert newlines when composing multi-line messages. Currently, Enter always sends the message, causing accidental sends — especially problematic in production embedded chat deployments. ## Solution Added `sendOnEnter` prop that flows through `ChatInputArea → Chat → ChatWrapper`: - **`sendOnEnter=true`** (default): Enter sends, Shift+Enter inserts newline (existing behavior, no breaking change) - **`sendOnEnter=false`**: Enter inserts newline, Shift+Enter sends ### Configuration **Embed script:** ```js window.difyChatbotConfig = { token: 'your-token', sendOnEnter: false // Enter = newline, Shift+Enter = send } ``` **URL parameter:** ``` /chatbot/TOKEN?sendOnEnter=false ``` ### IME Handling Existing `compositionstart`/`compositionend` event handling is preserved. Accidental sends during IME composition are prevented regardless of the `sendOnEnter` setting. ## Changes | File | Change | |------|--------| | `chat-input-area/index.tsx` | Added `sendOnEnter` prop; key combo logic now checks setting | | `chat/index.tsx` | Pass-through `sendOnEnter` prop to ChatInputArea | | `embedded-chatbot/chat-wrapper.tsx` | Read `sendOnEnter` from URL params | | `embed.js` / `embed.min.js` | Forward `sendOnEnter` config to iframe URL | ## Testing - Default behavior unchanged (Enter = send) - With `sendOnEnter=false`: Enter inserts newline, Shift+Enter sends - IME composition (Japanese/Korean/Chinese): no accidental sends in either mode - History navigation (Cmd+Up/Down) unaffected
yindo added the pull-request label 2026-02-21 20:53:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33655
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?