langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32302] refactor(web): centralize role-based route guards and fix anti-patterns #33659

New Issue
Closed
opened 2026-02-21 20:53:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:40 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32302

State: closed
Merged: Yes

Summary

  • Centralized dataset_operator route guard: Created RoleRouteGuard component at (commonLayout)/layout.tsx level, replacing 5 identical useEffect + router.replace guards scattered across leaf components
  • Replaced useEffect guards with synchronous render checks: Guards now check role during render and return null before children mount, preventing unauthorized content flash
  • Fixed derived state anti-pattern: explore/index.tsx derived hasEditPermission directly during render instead of useState + useEffect (rerender-derived-state-no-effect)
  • Replaced @remixicon/react imports with CSS icon classes in apps/list.tsx, reducing JS bundle size
  • Removed dead code: unused validTabs Set and redundant guard in datasets/list/index.tsx (already covered by datasets/layout.tsx)

Test plan

  • Verify dataset_operator role is redirected to /datasets when accessing /apps, /tools, /explore
  • Verify normal role is redirected to /apps when accessing /datasets
  • Verify editor/admin/owner roles can access all routes normally
  • Verify no flash of unauthorized content before redirect
  • Verify icons render correctly in apps list tab slider and DSL drop zone
**Original Pull Request:** https://github.com/langgenius/dify/pull/32302 **State:** closed **Merged:** Yes --- ## Summary - **Centralized dataset_operator route guard**: Created `RoleRouteGuard` component at `(commonLayout)/layout.tsx` level, replacing 5 identical `useEffect` + `router.replace` guards scattered across leaf components - **Replaced useEffect guards with synchronous render checks**: Guards now check role during render and return `null` before children mount, preventing unauthorized content flash - **Fixed derived state anti-pattern**: `explore/index.tsx` derived `hasEditPermission` directly during render instead of `useState` + `useEffect` (`rerender-derived-state-no-effect`) - **Replaced `@remixicon/react` imports with CSS icon classes** in `apps/list.tsx`, reducing JS bundle size - **Removed dead code**: unused `validTabs` Set and redundant guard in `datasets/list/index.tsx` (already covered by `datasets/layout.tsx`) ## Test plan - [ ] Verify dataset_operator role is redirected to `/datasets` when accessing `/apps`, `/tools`, `/explore` - [ ] Verify normal role is redirected to `/apps` when accessing `/datasets` - [ ] Verify editor/admin/owner roles can access all routes normally - [ ] Verify no flash of unauthorized content before redirect - [ ] Verify icons render correctly in apps list tab slider and DSL drop zone
yindo added the pull-request label 2026-02-21 20:53:40 -05:00
yindo closed this issue 2026-02-21 20:53:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?