langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32311] test(web): add members-page account-setting specs and improve coverage #33666

New Issue
Open
opened 2026-02-21 20:53:41 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:41 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32311

State: open
Merged: No

Checklist

  • This change requires a documentation update
  • I’ve added/updated tests for the behavior covered in this change
  • I ran lint, tests, and coverage for the updated members-page specs
  • No backend/API code paths were changed

Unit Test Added Summary

Added/Updated spec files

  • web/app/components/header/account-setting/members-page/edit-workspace-modal/index.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/index.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/invite-button.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/invite-modal/index.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/invite-modal/role-selector.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/invited-modal/index.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/invited-modal/invitation-link.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/operation/index.spec.tsx (updated)
  • web/app/components/header/account-setting/members-page/operation/transfer-ownership.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/transfer-ownership-modal/index.spec.tsx (new)
  • web/app/components/header/account-setting/members-page/transfer-ownership-modal/member-selector.spec.tsx (new)

Validation Run

Lint

pnpm --dir web eslint app/components/header/account-setting/members-page/**/*.spec.tsx
  • Result: ✅ Passed

Type Check

pnpm --dir web type-check:tsgo
  • Result: ✅ Passed

Tests

pnpm --dir web test app/components/header/account-setting/members-page
  • Result: ✅ Passed (49/49 tests)

Coverage

pnpm --dir web test:coverage app/components/header/account-setting/members-page
  • Result: ✅ Passed

Coverage Report (Members Page Source Files)

File Status in this update Statements Branches Functions Lines
web/app/components/header/account-setting/members-page/index.tsx Unchanged (retained) 90.00% 68.42% 72.72% 89.65%
web/app/components/header/account-setting/members-page/invite-button.tsx Covered in current update 100.00% 100.00% 100.00% 100.00%
web/app/components/header/account-setting/members-page/edit-workspace-modal/index.tsx Unchanged (retained) 93.75% 100.00% 80.00% 93.75%
web/app/components/header/account-setting/members-page/invite-modal/index.tsx Unchanged (retained) 91.89% 80.00% 87.50% 91.17%
web/app/components/header/account-setting/members-page/invite-modal/role-selector.tsx Covered in current update 87.50% 100.00% 85.71% 86.66%
web/app/components/header/account-setting/members-page/invited-modal/index.tsx Unchanged (retained) 100.00% 87.50% 100.00% 100.00%
web/app/components/header/account-setting/members-page/invited-modal/invitation-link.tsx Unchanged (retained) 91.66% 90.00% 80.00% 91.66%
web/app/components/header/account-setting/members-page/operation/index.tsx Unchanged (retained) 100.00% 87.50% 100.00% 100.00%
web/app/components/header/account-setting/members-page/operation/transfer-ownership.tsx Covered in current update 100.00% 100.00% 100.00% 100.00%
web/app/components/header/account-setting/members-page/transfer-ownership-modal/index.tsx Covered in current update 98.14% 76.92% 100.00% 98.07%
web/app/components/header/account-setting/members-page/transfer-ownership-modal/member-selector.tsx Unchanged (retained) 100.00% 88.00% 100.00% 100.00%

Fixes issue #32357

**Original Pull Request:** https://github.com/langgenius/dify/pull/32311 **State:** open **Merged:** No --- ## Checklist - [ ] This change requires a documentation update - [x] I’ve added/updated tests for the behavior covered in this change - [x] I ran lint, tests, and coverage for the updated members-page specs - [x] No backend/API code paths were changed ## Unit Test Added Summary ### Added/Updated spec files - `web/app/components/header/account-setting/members-page/edit-workspace-modal/index.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/index.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/invite-button.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/invite-modal/index.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/invite-modal/role-selector.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/invited-modal/index.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/invited-modal/invitation-link.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/operation/index.spec.tsx` (updated) - `web/app/components/header/account-setting/members-page/operation/transfer-ownership.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/transfer-ownership-modal/index.spec.tsx` (new) - `web/app/components/header/account-setting/members-page/transfer-ownership-modal/member-selector.spec.tsx` (new) ## Validation Run ### Lint ```bash pnpm --dir web eslint app/components/header/account-setting/members-page/**/*.spec.tsx ``` - Result: ✅ Passed ### Type Check ```bash pnpm --dir web type-check:tsgo ``` - Result: ✅ Passed ### Tests ```bash pnpm --dir web test app/components/header/account-setting/members-page ``` - Result: ✅ Passed (49/49 tests) ### Coverage ```bash pnpm --dir web test:coverage app/components/header/account-setting/members-page ``` - Result: ✅ Passed ## Coverage Report (Members Page Source Files) | File | Status in this update | Statements | Branches | Functions | Lines | |---|---|---:|---:|---:|---:| | `web/app/components/header/account-setting/members-page/index.tsx` | Unchanged (retained) | 90.00% | 68.42% | 72.72% | 89.65% | | `web/app/components/header/account-setting/members-page/invite-button.tsx` | Covered in current update | 100.00% | 100.00% | 100.00% | 100.00% | | `web/app/components/header/account-setting/members-page/edit-workspace-modal/index.tsx` | Unchanged (retained) | 93.75% | 100.00% | 80.00% | 93.75% | | `web/app/components/header/account-setting/members-page/invite-modal/index.tsx` | Unchanged (retained) | 91.89% | 80.00% | 87.50% | 91.17% | | `web/app/components/header/account-setting/members-page/invite-modal/role-selector.tsx` | Covered in current update | 87.50% | 100.00% | 85.71% | 86.66% | | `web/app/components/header/account-setting/members-page/invited-modal/index.tsx` | Unchanged (retained) | 100.00% | 87.50% | 100.00% | 100.00% | | `web/app/components/header/account-setting/members-page/invited-modal/invitation-link.tsx` | Unchanged (retained) | 91.66% | 90.00% | 80.00% | 91.66% | | `web/app/components/header/account-setting/members-page/operation/index.tsx` | Unchanged (retained) | 100.00% | 87.50% | 100.00% | 100.00% | | `web/app/components/header/account-setting/members-page/operation/transfer-ownership.tsx` | Covered in current update | 100.00% | 100.00% | 100.00% | 100.00% | | `web/app/components/header/account-setting/members-page/transfer-ownership-modal/index.tsx` | Covered in current update | 98.14% | 76.92% | 100.00% | 98.07% | | `web/app/components/header/account-setting/members-page/transfer-ownership-modal/member-selector.tsx` | Unchanged (retained) | 100.00% | 88.00% | 100.00% | 100.00% | Fixes issue #32357 ```
yindo added the pull-request label 2026-02-21 20:53:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33666
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?