langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32324] fix: include sso_verified in access_mode validation #33673

New Issue
Open
opened 2026-02-21 20:53:42 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:42 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32324

State: open
Merged: No

Summary

Fixes app duplication error when the original app has access_mode='sso_verified'.

Problem

When duplicating an app, the code inherits the access_mode from the original app. However, the validation in update_app_access_mode() only allowed ["public", "private", "private_all"], missing the "sso_verified" value that was documented in the WebAppSettings model.

This caused duplication to fail with: access_mode must be either 'public', 'private', or 'private_all'

Changes

  • Added "sso_verified" to the allowed values in update_app_access_mode() validation
  • Updated error message to include "sso_verified"

Files Changed

  • api/services/enterprise/enterprise_service.py

Testing

  • Verified LSP diagnostics are clean
  • No new type errors introduced
**Original Pull Request:** https://github.com/langgenius/dify/pull/32324 **State:** open **Merged:** No --- ## Summary Fixes app duplication error when the original app has `access_mode='sso_verified'`. ## Problem When duplicating an app, the code inherits the `access_mode` from the original app. However, the validation in `update_app_access_mode()` only allowed `["public", "private", "private_all"]`, missing the `"sso_verified"` value that was documented in the `WebAppSettings` model. This caused duplication to fail with: `access_mode must be either 'public', 'private', or 'private_all'` ## Changes - Added `"sso_verified"` to the allowed values in `update_app_access_mode()` validation - Updated error message to include `"sso_verified"` ## Files Changed - `api/services/enterprise/enterprise_service.py` ## Testing - Verified LSP diagnostics are clean - No new type errors introduced
yindo added the pull-request label 2026-02-21 20:53:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33673
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?