langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32369] fix: add missing NodeType for question classifier + prevent duplicate request logging handlers #33697

New Issue
Open
opened 2026-02-21 20:53:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:44 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32369

State: open
Merged: No

Summary

Two bug fixes:

Fix #32352: Question classifier backward invocation type error

invoke_question_classifier in api/core/plugin/backwards_invocation/node.py was missing:

node_data_dict["type"] = NodeType.QUESTION_CLASSIFIER

The invoke_parameter_extractor method correctly sets the node type, but this line was omitted for question classifier, causing a type error when plugins invoke the question classifier node via backward invocation.

Fix #30932: Duplicate request logging signal handlers

ext_request_logging.init_app() registered duplicate Flask signal handlers when called multiple times, causing repeated log entries per request. Now checks has_receivers_for() before connecting.

**Original Pull Request:** https://github.com/langgenius/dify/pull/32369 **State:** open **Merged:** No --- ## Summary Two bug fixes: ### Fix #32352: Question classifier backward invocation type error `invoke_question_classifier` in `api/core/plugin/backwards_invocation/node.py` was missing: ```python node_data_dict["type"] = NodeType.QUESTION_CLASSIFIER ``` The `invoke_parameter_extractor` method correctly sets the node type, but this line was omitted for question classifier, causing a type error when plugins invoke the question classifier node via backward invocation. ### Fix #30932: Duplicate request logging signal handlers `ext_request_logging.init_app()` registered duplicate Flask signal handlers when called multiple times, causing repeated log entries per request. Now checks `has_receivers_for()` before connecting.
yindo added the pull-request label 2026-02-21 20:53:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33697
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?