langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32373] test: add tests for file-upload components #33700

New Issue
Open
opened 2026-02-21 20:53:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:44 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32373

State: open
Merged: No

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • Tests
    • Vastly expanded test coverage for the file uploader: inputs (local/link), lists, image/audio/video/PDF previews, attachment/chat integrations, store/hooks, utils, hotkeys, portals, upload/reupload flows, size/type limits and many edge cases.
  • Refactor
    • Replaced icon components with span-based icon fonts and added test IDs for key actions.
  • Chores
    • Removed select ESLint suppression entries.
File Statements Branches Functions Lines
app/components/base/file-uploader/audio-preview.tsx 100% 100% 100% 100%
app/components/base/file-uploader/constants.ts 100% 100% 100% 100%
app/components/base/file-uploader/file-from-link-or-local/index.tsx 95.45% 91.3% 100% 95%
app/components/base/file-uploader/file-image-render.tsx 100% 100% 100% 100%
app/components/base/file-uploader/file-input.tsx 100% 100% 100% 100%
app/components/base/file-uploader/file-list-in-log.tsx 100% 100% 100% 100%
app/components/base/file-uploader/file-type-icon.tsx 100% 100% 100% 100%
app/components/base/file-uploader/file-uploader-in-attachment/file-item.tsx 100% 100% 100% 100%
app/components/base/file-uploader/file-uploader-in-attachment/index.tsx 100% 100% 100% 100%
app/components/base/file-uploader/file-uploader-in-chat-input/file-image-item.tsx 100% 95.83% 100% 100%
app/components/base/file-uploader/file-uploader-in-chat-input/file-item.tsx 100% 97.87% 100% 100%
app/components/base/file-uploader/file-uploader-in-chat-input/file-list.tsx 100% 100% 100% 100%
app/components/base/file-uploader/file-uploader-in-chat-input/index.tsx 100% 100% 100% 100%
app/components/base/file-uploader/hooks.ts 100% 100% 100% 100%
app/components/base/file-uploader/pdf-preview.tsx 100% 100% 100% 100%
app/components/base/file-uploader/store.tsx 100% 85.71% 100% 100%
app/components/base/file-uploader/utils.ts 100% 99% 100% 100%
app/components/base/file-uploader/video-preview.tsx 100% 100% 100% 100%

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

Fixes: #32152

**Original Pull Request:** https://github.com/langgenius/dify/pull/32373 **State:** open **Merged:** No --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary * **Tests** * Vastly expanded test coverage for the file uploader: inputs (local/link), lists, image/audio/video/PDF previews, attachment/chat integrations, store/hooks, utils, hotkeys, portals, upload/reupload flows, size/type limits and many edge cases. * **Refactor** * Replaced icon components with span-based icon fonts and added test IDs for key actions. * **Chores** * Removed select ESLint suppression entries. | File | Statements | Branches | Functions | Lines | |---|---|---|---|---| | `app/components/base/file-uploader/audio-preview.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/constants.ts` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/file-from-link-or-local/index.tsx` | 95.45% | 91.3% | 100% | 95% | | `app/components/base/file-uploader/file-image-render.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/file-input.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/file-list-in-log.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/file-type-icon.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/file-uploader-in-attachment/file-item.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/file-uploader-in-attachment/index.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/file-uploader-in-chat-input/file-image-item.tsx` | 100% | 95.83% | 100% | 100% | | `app/components/base/file-uploader/file-uploader-in-chat-input/file-item.tsx` | 100% | 97.87% | 100% | 100% | | `app/components/base/file-uploader/file-uploader-in-chat-input/file-list.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/file-uploader-in-chat-input/index.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/hooks.ts` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/pdf-preview.tsx` | 100% | 100% | 100% | 100% | | `app/components/base/file-uploader/store.tsx` | 100% | 85.71% | 100% | 100% | | `app/components/base/file-uploader/utils.ts` | 100% | 99% | 100% | 100% | | `app/components/base/file-uploader/video-preview.tsx` | 100% | 100% | 100% | 100% | ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods Fixes: #32152
yindo added the pull-request label 2026-02-21 20:53:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?