langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32370] test: added tests for some base components #33701

New Issue
Open
opened 2026-02-21 20:53:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:44 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32370

State: open
Merged: No

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • Tests

    • New comprehensive test suites for multiple core UI components (textarea, block input, buttons, carousel, drawer, error boundary, float-right container) covering rendering, interactions, accessibility, edge cases and utilities.

  • Refactor

    • Icon rendering updated across several controls and the drawer close control; accessibility and keyboard activation improved; added test hooks (data-testids) for better testability.

  • Chores

    • Removed two ESLint suppression entries to tighten linting.
Component File % Stmts % Branch % Funcs % Lines
auto-height-textarea index.tsx 100.00 100.00 100.00 100.00
block-input index.tsx 96.36 90.00 92.31 96.30
carousel index.tsx 96.67 92.31 93.33 98.31
error-boundary index.tsx 98.31 94.00 95.24 98.21
float-right-container index.tsx 100.00 100.00 100.00 100.00
button add-button.tsx 100.00 100.00 100.00 100.00
button sync-button.tsx 100.00 100.00 100.00 100.00

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

Fixes: #32152

**Original Pull Request:** https://github.com/langgenius/dify/pull/32370 **State:** open **Merged:** No --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary * **Tests** * New comprehensive test suites for multiple core UI components (textarea, block input, buttons, carousel, drawer, error boundary, float-right container) covering rendering, interactions, accessibility, edge cases and utilities. * **Refactor** * Icon rendering updated across several controls and the drawer close control; accessibility and keyboard activation improved; added test hooks (data-testids) for better testability. * **Chores** * Removed two ESLint suppression entries to tighten linting. | Component | File | % Stmts | % Branch | % Funcs | % Lines | |---|---|---|---|---|---| | auto-height-textarea | index.tsx | 100.00 | 100.00 | 100.00 | 100.00 | | block-input | index.tsx | 96.36 | 90.00 | 92.31 | 96.30 | | carousel | index.tsx | 96.67 | 92.31 | 93.33 | 98.31 | | error-boundary | index.tsx | 98.31 | 94.00 | 95.24 | 98.21 | | float-right-container | index.tsx | 100.00 | 100.00 | 100.00 | 100.00 | | button | add-button.tsx | 100.00 | 100.00 | 100.00 | 100.00 | | button | sync-button.tsx | 100.00 | 100.00 | 100.00 | 100.00 | ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods Fixes: #32152
yindo added the pull-request label 2026-02-21 20:53:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33701
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?