langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32386] refactor(web): replace String.match() with RegExp.exec() for non-global regex #33706

New Issue
Closed
opened 2026-02-21 20:53:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:45 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32386

State: closed
Merged: Yes

Summary

  • Replace string.match(regex) with regex.exec(string) across 18 files (~22 occurrences) per SonarQube rule S6594
  • When String#match is called without the global flag, it internally delegates to RegExp#exec, so calling exec() directly is more explicit and avoids the indirection
  • All .match() calls using global (g) flag regexes are intentionally left unchanged as they have different return semantics (returning all matches)

Closes #25199

Test plan

  • Run pnpm lint — no new lint errors
  • Run pnpm type-check:tsgo — no type errors
  • Run pnpm test — all existing tests pass
  • Verify skipped files still use .match() with global regex (e.g., block-input/index.tsx:16, mermaid/index.tsx:251)
**Original Pull Request:** https://github.com/langgenius/dify/pull/32386 **State:** closed **Merged:** Yes --- ## Summary - Replace `string.match(regex)` with `regex.exec(string)` across 18 files (~22 occurrences) per SonarQube rule S6594 - When `String#match` is called without the global flag, it internally delegates to `RegExp#exec`, so calling `exec()` directly is more explicit and avoids the indirection - All `.match()` calls using global (`g`) flag regexes are intentionally left unchanged as they have different return semantics (returning all matches) Closes #25199 ## Test plan - [ ] Run `pnpm lint` — no new lint errors - [ ] Run `pnpm type-check:tsgo` — no type errors - [ ] Run `pnpm test` — all existing tests pass - [ ] Verify skipped files still use `.match()` with global regex (e.g., `block-input/index.tsx:16`, `mermaid/index.tsx:251`)
yindo added the pull-request label 2026-02-21 20:53:45 -05:00
yindo closed this issue 2026-02-21 20:53:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33706
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?