langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32406] fix: correct misleading retry count in error message #33717

New Issue
Closed
opened 2026-02-21 20:53:46 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:46 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32406

State: closed
Merged: Yes

Summary

This is an alternative solution to PR #31075 for Issue #31071.
As I mentioned in my comment, while #31075 resolves the error message issue, it also has the side effect of excessively increasing the actual number of retries.

Since there has been no response from the author or maintainers on #31075 for a month after my comment, I’m submitting this PR as a follow-up.

In this PR, I’m focusing solely on correcting the error message.
When an error indicating that the retry limit has been exceeded is returned from the SSRF Proxy client, I re-throw a new error message so that the confusing retry count included in the original message is not propagated up the stack.

Closes #31071

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/32406 **State:** closed **Merged:** Yes --- ## Summary This is an alternative solution to PR #31075 for Issue #31071. As I mentioned in [my comment](https://github.com/langgenius/dify/pull/31075#issuecomment-3757432118), while #31075 resolves the error message issue, it also has the side effect of excessively increasing the actual number of retries. Since there has been no response from the author or maintainers on #31075 for a month after my comment, I’m submitting this PR as a follow-up. In this PR, I’m focusing solely on correcting the error message. When an error indicating that the retry limit has been exceeded is returned from the SSRF Proxy client, I re-throw a new error message so that the confusing retry count included in the original message is not propagated up the stack. Closes #31071 ## Screenshots | Before | After | |--------|-------| | <img width="847" height="270" alt="image" src="https://github.com/user-attachments/assets/164722a2-3414-4302-b11f-df8fd65487f4" /> | <img width="827" height="298" alt="image" src="https://github.com/user-attachments/assets/3f68b1c5-13f4-44bb-89bb-570e8d328dc9" /> | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [ ] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:53:46 -05:00
yindo closed this issue 2026-02-21 20:53:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33717
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?