langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-19 08:35:20 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #32425] fix: prevent hydration error from div nested inside p in markdown renderer #33732

New Issue
Open
opened 2026-02-21 20:53:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:47 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/32425

State: open
Merged: No

Summary

Fixes a Next.js hydration warning caused by invalid DOM nesting when markdown paragraphs contain inline images that aren't the first child.

Before: Text ![img](url) text renders as <p>Text <div class="markdown-img-wrapper">...</div> text</p> — invalid HTML (<div> inside <p>).

After: Detects img children at any position and renders <div> instead of <p> when images are present.

Changes

  • web/app/components/base/markdown-blocks/paragraph.tsx: Added fallback check for img children at non-first positions. When found, renders <div> instead of <p> to prevent invalid nesting.

The existing first-child image handling (which extracts the image into an ImageGallery) is preserved unchanged.

Closes #32362

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/langgenius/dify/pull/32425 **State:** open **Merged:** No --- ## Summary Fixes a Next.js hydration warning caused by invalid DOM nesting when markdown paragraphs contain inline images that aren't the first child. **Before:** `Text ![img](url) text` renders as `<p>Text <div class="markdown-img-wrapper">...</div> text</p>` — invalid HTML (`<div>` inside `<p>`). **After:** Detects `img` children at any position and renders `<div>` instead of `<p>` when images are present. ## Changes - **`web/app/components/base/markdown-blocks/paragraph.tsx`**: Added fallback check for `img` children at non-first positions. When found, renders `<div>` instead of `<p>` to prevent invalid nesting. The existing first-child image handling (which extracts the image into an `ImageGallery`) is preserved unchanged. Closes #32362 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
yindo added the pull-request label 2026-02-21 20:53:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?