langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

It is necessary to upgrade the weaviate client. #5416

New Issue
Closed
opened 2026-02-21 18:10:52 -05:00 by yindo · 6 comments
yindo commented 2026-02-21 18:10:52 -05:00
Owner
Copy Link
Copy Source

Originally created by @jiandanfeng on GitHub (Sep 5, 2024).

Originally assigned to: @JohnJyong on GitHub.

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

It is necessary to upgrade the weaviate client. When using Chinese full-text search, the current weaviate version does not support Chinese word segmentation, so the effect is not good. It needs to be upgraded to version 1.24. The gse or trigram word segmentation method is used to support Chinese word segmentation and improve the ability of weaviate Chinese full-text search.
weaviate tokenization link: https://weaviate.io/developers/weaviate/config-refs/schema#tokenization
weaviate client update link: https://weaviate.io/developers/weaviate/client-libraries/python/v3_v4_migration#installation

2. Additional context or comments

No response

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
Originally created by @jiandanfeng on GitHub (Sep 5, 2024). Originally assigned to: @JohnJyong on GitHub. ### Self Checks - [X] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [X] I confirm that I am using English to submit this report (我已阅读并同意 [Language Policy](https://github.com/langgenius/dify/issues/1542)). - [X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:） - [X] Please do not modify this template :) and fill in all the required fields. ### 1. Is this request related to a challenge you're experiencing? Tell me about your story. It is necessary to upgrade the weaviate client. When using Chinese full-text search, the current weaviate version does not support Chinese word segmentation, so the effect is not good. It needs to be upgraded to version 1.24. The gse or trigram word segmentation method is used to support Chinese word segmentation and improve the ability of weaviate Chinese full-text search. weaviate tokenization link: https://weaviate.io/developers/weaviate/config-refs/schema#tokenization weaviate client update link: https://weaviate.io/developers/weaviate/client-libraries/python/v3_v4_migration#installation ### 2. Additional context or comments _No response_ ### 3. Can you help us with this feature? - [ ] I am interested in contributing to this feature.
yindo added the 👻 feat:rag label 2026-02-21 18:10:52 -05:00
yindo closed this issue 2026-02-21 18:10:52 -05:00
yindo commented 2026-02-21 18:10:53 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Sep 5, 2024):

I found a similar discussion regarding the Weaviate database version and its support in Dify. You might find it relevant: Why doesn't Weaviate database use the latest version, still using version 1.19, and does Dify currently support higher versions of Weaviate? [1].

Currently, the Dify codebase uses Weaviate client version 1.19.0 [2]. The Weaviate client is integrated in the WeaviateVector class and utilized in integration tests [3][4].

For Chinese full-text search, the current implementation includes configurations for a Chinese lexer and uses Jieba for text segmentation [5]. The jieba library is used for word segmentation [6].

Upgrading to Weaviate version 1.24 to support Chinese word segmentation with gse or trigram methods would indeed improve the full-text search capabilities. If you are interested in contributing to this feature, you might want to start by updating the Weaviate client version in the docker-compose files and adjusting the relevant code to utilize the new segmentation methods.

To continue talking to Dosu, mention @dosu.

@dosubot[bot] commented on GitHub (Sep 5, 2024): <!-- Answer --> I found a similar discussion regarding the Weaviate database version and its support in Dify. You might find it relevant: [Why doesn't Weaviate database use the latest version, still using version 1.19, and does Dify currently support higher versions of Weaviate?](https://github.com/langgenius/dify/discussions/7692) <sup>[[1]](https://github.com/langgenius/dify/discussions/7692)</sup>. Currently, the Dify codebase uses Weaviate client version `1.19.0` <sup>[[2]](https://github.com/langgenius/dify/blob/main/docker/docker-compose.yaml)</sup>. The Weaviate client is integrated in the `WeaviateVector` class and utilized in integration tests <sup>[[3]](https://github.com/langgenius/dify/blob/main/api/core/rag/datasource/vdb/weaviate/weaviate_vector.py)</sup><sup>[[4]](https://github.com/langgenius/dify/blob/main/api/tests/integration_tests/vdb/weaviate/test_weaviate.py)</sup>. For Chinese full-text search, the current implementation includes configurations for a Chinese lexer and uses Jieba for text segmentation <sup>[[5]](https://github.com/langgenius/dify/blob/main/api/core/rag/datasource/vdb/oracle/oraclevector.py)</sup>. The `jieba` library is used for word segmentation <sup>[[6]](https://github.com/langgenius/dify/blob/main/api/core/rag/datasource/keyword/jieba/jieba.py)</sup>. Upgrading to Weaviate version `1.24` to support Chinese word segmentation with gse or trigram methods would indeed improve the full-text search capabilities. If you are interested in contributing to this feature, you might want to start by updating the Weaviate client version in the `docker-compose` files and adjusting the relevant code to utilize the new segmentation methods. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
yindo commented 2026-02-21 18:10:53 -05:00
Author
Owner
Copy Link
Copy Source

@Kevin9703 commented on GitHub (Sep 9, 2024):

I agree that we should upgrade the Weaviate version. Version 1.2x supports different compression methods and gRPC calls, which can significantly improve performance.

@Kevin9703 commented on GitHub (Sep 9, 2024): I agree that we should upgrade the Weaviate version. Version 1.2x supports different compression methods and gRPC calls, which can significantly improve performance.
yindo commented 2026-02-21 18:10:53 -05:00
Author
Owner
Copy Link
Copy Source

@fujita-h commented on GitHub (Sep 29, 2024):

I agree with this suggestion.
With the current (default) tokenizer settings, full-text search for Japanese barely works.
I tested the following steps and confirmed that the performance of full-text search in Japanese improved significantly.

  1. Set the weaviate version to 1.24.25
  2. Add USE_GSE: true to the weaviate container's environment variables
  3. Edit dify/api/core/rag/datasource/vdb/weaviate/weaviate_vector.py as follows
    def _default_schema(self, index_name: str) -> dict:
        return {
            "class": index_name,
            "properties": [
                {
                    "name": "text",
                    "dataType": ["text"],
                    "tokenization": "gse", # <- added this
                }
            ],
        }

When implementing, we also need to create a UI that switches the tokenizer depending on whether the document to be registered is in a language suitable for GSE.

@fujita-h commented on GitHub (Sep 29, 2024): I agree with this suggestion. With the current (default) tokenizer settings, full-text search for Japanese barely works. I tested the following steps and confirmed that the performance of full-text search in Japanese improved significantly. 1. Set the weaviate version to `1.24.25` 2. Add `USE_GSE: true` to the weaviate container's environment variables 3. Edit `dify/api/core/rag/datasource/vdb/weaviate/weaviate_vector.py` as follows ```python def _default_schema(self, index_name: str) -> dict: return { "class": index_name, "properties": [ { "name": "text", "dataType": ["text"], "tokenization": "gse", # <- added this } ], } ``` When implementing, we also need to create a UI that switches the tokenizer depending on whether the document to be registered is in a language suitable for GSE.
yindo commented 2026-02-21 18:10:53 -05:00
Author
Owner
Copy Link
Copy Source

@Scallions commented on GitHub (Oct 25, 2024):

https://weaviate.io/developers/weaviate/search/similarity#named-vectors Named-vectors is also needed.

@Scallions commented on GitHub (Oct 25, 2024): https://weaviate.io/developers/weaviate/search/similarity#named-vectors Named-vectors is also needed.
yindo commented 2026-02-21 18:10:53 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Nov 25, 2024):

Hi, @jiandanfeng. I'm Dosu, and I'm helping the Dify team manage their backlog. I'm marking this issue as stale.

Issue Summary

  • The issue was about upgrading the Weaviate client to version 1.24 for better Chinese full-text search.
  • You and other contributors, including @Kevin9703 and @fujita-h, agreed on the benefits of the upgrade.
  • @fujita-h shared successful test results and suggested UI adjustments for language-specific tokenization.
  • The issue seems resolved with the community agreeing on the improvements.

Next Steps

  • Please confirm if this issue is still relevant to the latest version of the Dify repository. If so, you can keep the discussion open by commenting here.
  • If there are no further updates, this issue will be automatically closed in 15 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Nov 25, 2024): Hi, @jiandanfeng. I'm [Dosu](https://dosu.dev), and I'm helping the Dify team manage their backlog. I'm marking this issue as stale. **Issue Summary** - The issue was about upgrading the Weaviate client to version 1.24 for better Chinese full-text search. - You and other contributors, including @Kevin9703 and @fujita-h, agreed on the benefits of the upgrade. - @fujita-h shared successful test results and suggested UI adjustments for language-specific tokenization. - The issue seems resolved with the community agreeing on the improvements. **Next Steps** - Please confirm if this issue is still relevant to the latest version of the Dify repository. If so, you can keep the discussion open by commenting here. - If there are no further updates, this issue will be automatically closed in 15 days. Thank you for your understanding and contribution!
yindo commented 2026-02-21 18:10:53 -05:00
Author
Owner
Copy Link
Copy Source

@fujita-h commented on GitHub (Dec 31, 2024):

I'm focused on #12223.

@fujita-h commented on GitHub (Dec 31, 2024): I'm focused on #12223.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 👻 feat:rag
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#5416
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?