langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Knowledge Retrieval with external knowledge base #5987

New Issue
Closed
opened 2026-02-21 18:13:32 -05:00 by yindo · 12 comments
yindo commented 2026-02-21 18:13:32 -05:00
Owner
Copy Link
Copy Source

Originally created by @akkaz on GitHub (Oct 9, 2024).

Originally assigned to: @YIXIAO0, @JohnJyong, @Yawen-1010 on GitHub.

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
  • Please do not modify this template :) and fill in all the required fields.

Dify version

0.9.1

Cloud or Self Hosted

Cloud

Steps to reproduce

I successfully connect an external knowledge base with the new feature provided in 0.9.1.

I can also test the knowledge base, in the dedicated section and it works fine.
image

When you try to insert the "Knowledge Retrieval" in a workwflow, you get this error
image

✔️ Expected Behavior

No response

❌ Actual Behavior

No response

Originally created by @akkaz on GitHub (Oct 9, 2024). Originally assigned to: @YIXIAO0, @JohnJyong, @Yawen-1010 on GitHub. ### Self Checks - [X] This is only for bug report, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [X] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [X] I confirm that I am using English to submit this report (我已阅读并同意 [Language Policy](https://github.com/langgenius/dify/issues/1542)). - [X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:） - [X] Please do not modify this template :) and fill in all the required fields. ### Dify version 0.9.1 ### Cloud or Self Hosted Cloud ### Steps to reproduce I successfully connect an external knowledge base with the new feature provided in 0.9.1. I can also test the knowledge base, in the dedicated section and it works fine. ![image](https://github.com/user-attachments/assets/449b0787-fa29-4829-9d0a-8574a83894af) When you try to insert the "Knowledge Retrieval" in a workwflow, you get this error ![image](https://github.com/user-attachments/assets/92781cd4-b513-4419-90a2-81c77dc83283) ### ✔️ Expected Behavior _No response_ ### ❌ Actual Behavior _No response_
yindo added the 🐞 bug label 2026-02-21 18:13:32 -05:00
yindo closed this issue 2026-02-21 18:13:32 -05:00
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Oct 9, 2024):

To resolve the "'NoneType' object has no attribute 'provider'" error when inserting "Knowledge Retrieval" in a workflow using Dify version 0.9.1, ensure that the reranking_model is properly initialized before accessing its provider attribute. This error likely occurs in the following section:

if node_data.multiple_retrieval_config.reranking_mode == "reranking_model":
    reranking_model = {
        "reranking_provider_name": node_data.multiple_retrieval_config.reranking_model.provider,
        "reranking_model_name": node_data.multiple_retrieval_config.reranking_model.model,
    }

Make sure that node_data.multiple_retrieval_config.reranking_model is not None and is correctly set up with the necessary attributes (provider and model). You might need to add a check or initialize it properly before this code block.

Additionally, review the _convert_to_knowledge_retrieval_node function in the workflow_converter.py file to ensure that the multiple_retrieval_config and its reranking_model are set up correctly, especially when the retrieval mode is MULTIPLE [1][2].

To continue talking to Dosu, mention @dosu.

@dosubot[bot] commented on GitHub (Oct 9, 2024): <!-- Answer --> To resolve the "'NoneType' object has no attribute 'provider'" error when inserting "Knowledge Retrieval" in a workflow using Dify version 0.9.1, ensure that the `reranking_model` is properly initialized before accessing its `provider` attribute. This error likely occurs in the following section: ```python if node_data.multiple_retrieval_config.reranking_mode == "reranking_model": reranking_model = { "reranking_provider_name": node_data.multiple_retrieval_config.reranking_model.provider, "reranking_model_name": node_data.multiple_retrieval_config.reranking_model.model, } ``` Make sure that `node_data.multiple_retrieval_config.reranking_model` is not `None` and is correctly set up with the necessary attributes (`provider` and `model`). You might need to add a check or initialize it properly before this code block. Additionally, review the `_convert_to_knowledge_retrieval_node` function in the `workflow_converter.py` file to ensure that the `multiple_retrieval_config` and its `reranking_model` are set up correctly, especially when the retrieval mode is `MULTIPLE` <sup>[[1]](https://github.com/langgenius/dify/blob/main/api/core/workflow/nodes/knowledge_retrieval/knowledge_retrieval_node.py)</sup><sup>[[2]](https://github.com/langgenius/dify/blob/main/api/services/workflow/workflow_converter.py)</sup>. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@Yawen-1010 commented on GitHub (Oct 11, 2024):

@akkaz This error may be caused by not successfully configuring the Rerank Model but turning on the switch. We are working on fixing this issue. This feature can still be used normally. You can choose to temporarily turn off the rerank model switch, or configure an available rerank model.

@Yawen-1010 commented on GitHub (Oct 11, 2024): @akkaz This error may be caused by not successfully configuring the Rerank Model but turning on the switch. We are working on fixing this issue. This feature can still be used normally. You can choose to temporarily turn off the rerank model switch, or configure an available rerank model.
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@BGFGB commented on GitHub (Oct 11, 2024):

@akkaz This error may be caused by not successfully configuring the Rerank Model but turning on the switch. We are working on fixing this issue. This feature can still be used normally. You can choose to temporarily turn off the rerank model switch, or configure an available rerank model.

In my case, the issue occurred because the knowledge retrieval returned an empty value, despite the status being a successful 200. Upon reviewing the code, I identified a potential problem here: https://github.com/langgenius/dify/blob/f4ce08211d3c614f6fbffb47d55e3a96678fb78d/api/core/workflow/nodes/knowledge_retrieval/knowledge_retrieval_node.py#L82. After commenting out that line, the issue was resolved.

Additionally, the documentation mentions that metadata should be a string (https://docs.dify.ai/zh-hans/guides/knowledge-base/external-knowledge-api-documentation), but in practice, the backend treats it as a dictionary (https://github.com/langgenius/dify/blob/3f1aa1f9e263f1134ba0a89c61a5b0dd14eac0ac/api/core/rag/models/document.py#L18). These inconsistencies didn't raise any errors during recall tests, but in actual workflows, they caused failures with empty data being returned.

After fixing these two points, everything is functioning correctly. However, regarding the first issue, simply commenting out that line might introduce other problems, so a more robust solution may be needed.

@BGFGB commented on GitHub (Oct 11, 2024): > @akkaz This error may be caused by not successfully configuring the Rerank Model but turning on the switch. We are working on fixing this issue. This feature can still be used normally. You can choose to temporarily turn off the rerank model switch, or configure an available rerank model. In my case, the issue occurred because the knowledge retrieval returned an empty value, despite the status being a successful 200. Upon reviewing the code, I identified a potential problem here: https://github.com/langgenius/dify/blob/f4ce08211d3c614f6fbffb47d55e3a96678fb78d/api/core/workflow/nodes/knowledge_retrieval/knowledge_retrieval_node.py#L82. After commenting out that line, the issue was resolved. Additionally, the documentation mentions that metadata should be a string (https://docs.dify.ai/zh-hans/guides/knowledge-base/external-knowledge-api-documentation), but in practice, the backend treats it as a dictionary (https://github.com/langgenius/dify/blob/3f1aa1f9e263f1134ba0a89c61a5b0dd14eac0ac/api/core/rag/models/document.py#L18). These inconsistencies didn't raise any errors during recall tests, but in actual workflows, they caused failures with empty data being returned. After fixing these two points, everything is functioning correctly. However, regarding the first issue, simply commenting out that line might introduce other problems, so a more robust solution may be needed.
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@Yawen-1010 commented on GitHub (Oct 11, 2024):

@JohnJyong

@Yawen-1010 commented on GitHub (Oct 11, 2024): @JohnJyong
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@sepa85 commented on GitHub (Oct 11, 2024):

For me also, enabling the rerank fixes the error, but always gives empty results.

@sepa85 commented on GitHub (Oct 11, 2024): For me also, enabling the rerank fixes the error, but always gives empty results.
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@JohnJyong commented on GitHub (Oct 11, 2024):

the cloud servcie has updated to the latest version ,pls try , thanks ~

@JohnJyong commented on GitHub (Oct 11, 2024): the cloud servcie has updated to the latest version ,pls try , thanks ~
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@sepa85 commented on GitHub (Oct 11, 2024):

I still have empty result, even if knowledge test gives results. I'm using cloud.

Screenshot_20241012-025710.jpg

Screenshot_20241012-025747.jpg

@sepa85 commented on GitHub (Oct 11, 2024): I still have empty result, even if knowledge test gives results. I'm using cloud. ![Screenshot_20241012-025710.jpg](https://github.com/user-attachments/assets/3e7991e9-f51a-4e84-992d-9bd34b743a76) ![Screenshot_20241012-025747.jpg](https://github.com/user-attachments/assets/b36d732f-084a-4cdf-8843-bb92d0c6d099)
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@BGFGB commented on GitHub (Oct 11, 2024):

the cloud servcie has updated to the latest version ,pls try , thanks ~

"I see that your fix has been merged into the main branch, but the cloud service is using Version 0.9.1-fix1, and it seems that the fix hasn't been integrated yet."

@BGFGB commented on GitHub (Oct 11, 2024): > the cloud servcie has updated to the latest version ,pls try , thanks ~ "I see that your fix has been merged into the main branch, but the cloud service is using Version 0.9.1-fix1, and it seems that the fix hasn't been integrated yet."
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@BGFGB commented on GitHub (Oct 11, 2024):

@JohnJyong I locally merged your fix branch into version 0.9.1, and so far the issue appears to be resolved. Thank you for the fix!

@BGFGB commented on GitHub (Oct 11, 2024): @JohnJyong I locally merged your fix branch into version 0.9.1, and so far the issue appears to be resolved. Thank you for the fix!
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@sepa85 commented on GitHub (Oct 14, 2024):

After updating to version 0.9.2, I'm still encountering issues with the workflow.

Now, whenever I click "Run," I receive a "Rerank model is required" error, regardless of whether rerank is enabled or disabled.

Screenshot_20241014-231240~2.jpg

Screenshot_20241014-231235~2.jpg

@sepa85 commented on GitHub (Oct 14, 2024): After updating to version 0.9.2, I'm still encountering issues with the workflow. Now, whenever I click "Run," I receive a "Rerank model is required" error, regardless of whether rerank is enabled or disabled. ![Screenshot_20241014-231240~2.jpg](https://github.com/user-attachments/assets/c5163990-cb2f-400f-aa0b-97d7ef3d46d1) ![Screenshot_20241014-231235~2.jpg](https://github.com/user-attachments/assets/047f7585-1171-4e94-80eb-c5724840ed76)
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@YIXIAO0 commented on GitHub (Oct 14, 2024):

Hello, thank you for bringing this issue to our attention. After reviewing it, it seems to be a frontend saving bug. For now, please try returning to the studio and then selecting the app. This should prevent the 'rerank model is required' issue from appearing. We'll address this bug in the next release. Thank you for your patience!

@YIXIAO0 commented on GitHub (Oct 14, 2024): Hello, thank you for bringing this issue to our attention. After reviewing it, it seems to be a frontend saving bug. For now, please try returning to the studio and then selecting the app. This should prevent the 'rerank model is required' issue from appearing. We'll address this bug in the next release. Thank you for your patience!
yindo commented 2026-02-21 18:13:33 -05:00
Author
Owner
Copy Link
Copy Source

@sepa85 commented on GitHub (Oct 15, 2024):

Going to studio and back to workflow seems to "fix" the front end issue, but the result array is still empty.

Screenshot_20241015-171020.jpg

@sepa85 commented on GitHub (Oct 15, 2024): Going to studio and back to workflow seems to "fix" the front end issue, but the result array is still empty. ![Screenshot_20241015-171020.jpg](https://github.com/user-attachments/assets/02e03855-5dba-4b1d-b499-a058acc9a2e2)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#5987
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?