langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Contaminated db commit message #8928

New Issue
Closed
opened 2026-02-21 18:28:40 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 18:28:40 -05:00
Owner
Copy Link
Copy Source

Originally created by @bowenliang123 on GitHub (Mar 3, 2025).

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

  • contaminated db migration commit message in e1944c35e15e , when running flask db upgrade
INFO  [alembic.runtime.migration] Running upgrade cf8f4fc45278 -> 11b07f66c737, remove unused tool_providers
INFO  [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model
Revision ID: e1944c35e15e
Revises: 11b07f66c737
Create Date: 2024-12-20 06:28:30.287197
INFO  [alembic.runtime.migration] Running upgrade e1944c35e15e -> d7999dfa4aae, remove workflow_node_executions.retry_index if exists
INFO  [alembic.runtime.migration] Running upgrade d7999dfa4aae -> e19037032219, parent-child-index

2. Additional context or comments

  • it should be fixed from
INFO  [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model
Revision ID: e1944c35e15e
Revises: 11b07f66c737
Create Date: 2024-12-20 06:28:30.287197

into

INFO  [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
Originally created by @bowenliang123 on GitHub (Mar 3, 2025). ### Self Checks - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report (我已阅读并同意 [Language Policy](https://github.com/langgenius/dify/issues/1542)). - [x] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:） - [x] Please do not modify this template :) and fill in all the required fields. ### 1. Is this request related to a challenge you're experiencing? Tell me about your story. - contaminated db migration commit message in `e1944c35e15e` , when running `flask db upgrade` ``` INFO [alembic.runtime.migration] Running upgrade cf8f4fc45278 -> 11b07f66c737, remove unused tool_providers INFO [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model Revision ID: e1944c35e15e Revises: 11b07f66c737 Create Date: 2024-12-20 06:28:30.287197 INFO [alembic.runtime.migration] Running upgrade e1944c35e15e -> d7999dfa4aae, remove workflow_node_executions.retry_index if exists INFO [alembic.runtime.migration] Running upgrade d7999dfa4aae -> e19037032219, parent-child-index ``` ### 2. Additional context or comments - it should be fixed from ``` INFO [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model Revision ID: e1944c35e15e Revises: 11b07f66c737 Create Date: 2024-12-20 06:28:30.287197 ``` into ``` INFO [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model ``` ### 3. Can you help us with this feature? - [ ] I am interested in contributing to this feature.
yindo added the 🐞 bug label 2026-02-21 18:28:40 -05:00
yindo closed this issue 2026-02-21 18:28:40 -05:00
yindo commented 2026-02-21 18:28:41 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Mar 3, 2025):

The migration with revision ID e1944c35e15e was intended to add a retry_index field to the workflow_node_executions model, but the actual changes were not implemented in the upgrade and downgrade functions. This is indicated by the commented-out code and the note that the change will be reverted in the next migration. The subsequent migration with revision ID d7999dfa4aae explicitly checks for the existence of the retry_index column and removes it if it exists, confirming that the changes associated with e1944c35e15e were not meant to be permanent [1][2].

If you want to address the issue with the commit message, you might consider updating the migration script to reflect the actual changes made, or lack thereof, in the upgrade and downgrade functions. This would ensure that the commit message accurately represents the migration's purpose and actions.

To continue talking to Dosu, mention @dosu.

Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@dosubot[bot] commented on GitHub (Mar 3, 2025): <!-- Answer --> The migration with revision ID `e1944c35e15e` was intended to add a `retry_index` field to the `workflow_node_executions` model, but the actual changes were not implemented in the `upgrade` and `downgrade` functions. This is indicated by the commented-out code and the note that the change will be reverted in the next migration. The subsequent migration with revision ID `d7999dfa4aae` explicitly checks for the existence of the `retry_index` column and removes it if it exists, confirming that the changes associated with `e1944c35e15e` were not meant to be permanent <sup>[[1]](https://github.com/langgenius/dify/blob/main/api/migrations/versions/2024_12_20_0628-e1944c35e15e_add_retry_index_field_to_node_execution_.py)</sup><sup>[[2]](https://github.com/langgenius/dify/blob/main/api/migrations/versions/2024_12_23_1154-d7999dfa4aae_remove_workflow_node_executions_retry_.py)</sup>. If you want to address the issue with the commit message, you might consider updating the migration script to reflect the actual changes made, or lack thereof, in the `upgrade` and `downgrade` functions. This would ensure that the commit message accurately represents the migration's purpose and actions. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.* --- <sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/d68d4170-c9af-4b21-b0a4-82dd3317c6b1?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/d68d4170-c9af-4b21-b0a4-82dd3317c6b1?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/d68d4170-c9af-4b21-b0a4-82dd3317c6b1?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/d68d4170-c9af-4b21-b0a4-82dd3317c6b1?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/d68d4170-c9af-4b21-b0a4-82dd3317c6b1?feedback_type=hallucination) | [Bug Report](https://app.dosu.dev/response-feedback/d68d4170-c9af-4b21-b0a4-82dd3317c6b1?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/d68d4170-c9af-4b21-b0a4-82dd3317c6b1?feedback_type=other)</sup>
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#8928
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?