ci: run release job even when a build job fails

Without always(), GitHub Actions' default skip-if-a-needed-job-failed
behavior meant a single failed build job (e.g. one CUDA sm_* matrix leg,
several of which use fail-fast: false) could skip the release job
outright, before the per-family completeness check ever ran — silently
producing no release instead of a correct partial one.

The other issue found in the equivalent llama.cpp fix (a hard-fail step
that could block unrelated families) doesn't apply here: this workflow
has no cross-job merge step comparable to llama.cpp's Windows CPU-into-
other-zips step, so there's nothing else that needs the same treatment.

Follow-up to #14.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
This commit is contained in:
Ken VanDineandClaude Sonnet 5 committed 2026-07-02 09:39:12 -04:00
1 parent 15ba36d3e6
commit 03e249db83
1 file changed
+6 -1
+6 -1
View File
@@ -921,7 +921,12 @@ jobs:
sd-${{ env.BRANCH_NAME }}-${{ steps.commit.outputs.short }}-bin-Darwin-arm64-metal${{ matrix.archive_suffix }}.zip
release:
if: ${{ github.event_name == 'schedule' || github.event.inputs.create_release == 'true' }}
# always() overrides the default behavior of skipping this job when a
# needed build job fails (e.g. one CUDA sm_* matrix leg fails while
# sibling legs succeed and upload). The job must still run so the
# per-family checks below can decide what's actually complete and safe
# to publish.
if: ${{ always() && (github.event_name == 'schedule' || github.event.inputs.create_release == 'true') }}
permissions:
contents: write