Files
MesenCE/Core/NES/NesControlManager.h
SourMesen 142884b598 NES: Ignore consecutive reads to 4016/4017 (#185)
The NES (and AV Famicom) both ignore consecutive reads to 4016/4017 (when the reads on 2 consecutive CPU cycles). This implements that behavior when the corresponding console type is selected.
These changes also simplify the DMA code, because a lot of extra code was in the DMA logic to simulate the same result. Moving this logic to the 4016/4017 reads makes the code simpler and allows it to work properly when a regular instruction reads from 4016/4017 twice in a row, too.
2026-06-21 19:17:51 -07:00

62 lines
1.5 KiB
C++

#pragma once
#include "pch.h"
#include "NES/INesMemoryHandler.h"
#include "Shared/BaseControlManager.h"
#include "Shared/SettingTypes.h"
#include "Utilities/SimpleLock.h"
#include "Utilities/ISerializable.h"
class BaseControlDevice;
class SystemActionManager;
class IInputRecorder;
class IInputProvider;
class Emulator;
class NesConsole;
enum class ControllerType;
class NesControlManager : public INesMemoryHandler, public BaseControlManager
{
private:
NesConfig _prevConfig = {};
uint16_t _writeAddr = 0;
uint8_t _writeValue = 0;
uint8_t _writePending = 0;
uint16_t _prevReadAddr = 0;
uint8_t ReadDevice(shared_ptr<BaseControlDevice>& device, uint16_t addr);
protected:
NesConsole* _console;
virtual void Serialize(Serializer& s) override;
virtual void RemapControllerButtons();
public:
NesControlManager(NesConsole* console);
virtual ~NesControlManager();
virtual uint8_t GetOpenBusMask(uint8_t port);
void UpdateControlDevices() override;
void UpdateInputState() override;
void Reset(bool softReset) override;
bool IsKeyboardConnected() override;
shared_ptr<BaseControlDevice> CreateControllerDevice(ControllerType type, uint8_t port) override;
void GetMemoryRanges(MemoryRanges& ranges) override
{
ranges.AddHandler(MemoryOperation::Read, 0x4016, 0x4017);
ranges.AddHandler(MemoryOperation::Write, 0x4016);
}
uint8_t ReadRam(uint16_t addr) override;
void WriteRam(uint16_t addr, uint8_t value) override;
__noinline void ProcessWrites();
__forceinline bool HasPendingWrites() { return _writePending > 0; }
};