(Netplay) Disable and hide stateless mode (#13915)

Stateless mode is nonfunctional at the moment, despite my attempts to get it working.
A significant amount of work is required to get it working.

For now, force-disable stateless mode and hide it from menus and the CLI's help text.
This commit is contained in:
Cthulhu-throwaway 2022-05-05 15:46:48 -03:00 committed by GitHub
parent 19b7ff81b9
commit 0a52964015
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 5 deletions

View File

@ -7818,7 +7818,7 @@ unsigned menu_displaylist_build_list(
{MENU_ENUM_LABEL_NETPLAY_ALLOW_PAUSING, PARSE_ONLY_BOOL, true},
{MENU_ENUM_LABEL_NETPLAY_ALLOW_SLAVES, PARSE_ONLY_BOOL, true},
{MENU_ENUM_LABEL_NETPLAY_REQUIRE_SLAVES, PARSE_ONLY_BOOL, false},
{MENU_ENUM_LABEL_NETPLAY_STATELESS_MODE, PARSE_ONLY_BOOL, true},
/*{MENU_ENUM_LABEL_NETPLAY_STATELESS_MODE, PARSE_ONLY_BOOL, true},*/
{MENU_ENUM_LABEL_NETPLAY_CHECK_FRAMES, PARSE_ONLY_INT, true},
{MENU_ENUM_LABEL_NETPLAY_INPUT_LATENCY_FRAMES_MIN, PARSE_ONLY_INT, true},
{MENU_ENUM_LABEL_NETPLAY_INPUT_LATENCY_FRAMES_RANGE, PARSE_ONLY_INT, true},

View File

@ -8354,7 +8354,8 @@ bool init_netplay(const char *server, unsigned port, const char *mitm_session)
net_st->data = netplay_new(
server, mitm, port, mitm_session,
settings->bools.netplay_stateless_mode,
/*settings->bools.netplay_stateless_mode,*/
false,
settings->ints.netplay_check_frames,
&cbs,
settings->bools.netplay_nat_traversal,

View File

@ -4242,8 +4242,8 @@ static void retroarch_print_help(const char *arg0)
"Port used to netplay. Default is 55435.\n", sizeof(buf));
strlcat(buf, " --nick=NICK "
"Picks a username (for use with netplay). Not mandatory.\n", sizeof(buf));
strlcat(buf, " --stateless "
"Use \"stateless\" mode for netplay (requires a very fast network).\n", sizeof(buf));
/*strlcat(buf, " --stateless "
"Use \"stateless\" mode for netplay (requires a very fast network).\n", sizeof(buf));*/
strlcat(buf, " --check-frames=NUMBER "
"Check frames when using netplay.\n", sizeof(buf));
#ifdef HAVE_NETWORK_CMD

View File

@ -433,7 +433,7 @@ QWidget *NetplayPage::widget()
slaveGroup->add(MENU_ENUM_LABEL_NETPLAY_ALLOW_SLAVES);
slaveGroup->add(MENU_ENUM_LABEL_NETPLAY_REQUIRE_SLAVES);
syncGroup->add(MENU_ENUM_LABEL_NETPLAY_STATELESS_MODE);
//syncGroup->add(MENU_ENUM_LABEL_NETPLAY_STATELESS_MODE);
syncGroup->add(MENU_ENUM_LABEL_NETPLAY_CHECK_FRAMES);
syncGroup->add(MENU_ENUM_LABEL_NETPLAY_INPUT_LATENCY_FRAMES_MIN);
syncGroup->add(MENU_ENUM_LABEL_NETPLAY_INPUT_LATENCY_FRAMES_RANGE);