libretro/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch.git synced 2024-11-26 17:50:56 +00:00
Code Issues Actions 44 Packages Projects Releases Wiki Activity

Check for shader parameter step set to 0.0 and handle it outside the otherwise neverending loop; should fix #16958 (#16962)

Browse Source
This commit is contained in:
Antonio Orefice 2024-09-05 07:53:24 +02:00 committed by GitHub
parent 43e5492002
commit 139f461d06
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 30 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
menu/menu_displaylist.c
View File

@ -11732,30 +11732,47 @@ static unsigned menu_displaylist_build_shader_parameter(
current_value = min;
original_value = param->current;
for (i = 0; current_value < (max + 0.0001f); i++)
{
if (half_step <= 0.0) { /* safety check */
char val_s[16], val_d[16];
snprintf(val_s, sizeof(val_s), "%.2f", current_value);
snprintf(val_d, sizeof(val_d), "%d", i);
if (menu_entries_append(list,
snprintf(val_d, sizeof(val_d), "%d", 0);
menu_entries_append(list,
val_s,
val_d,
MENU_ENUM_LABEL_NO_ITEMS,
setting_type,
i, entry_type, NULL))
i, entry_type, NULL);
count = 1;
checked = 1.0;
checked_found = true;
}
else
{
for (i = 0; current_value < (max + 0.0001f); i++)
{
if (!checked_found &&
(fabs(current_value - original_value) < half_step))
char val_s[16], val_d[16];
snprintf(val_s, sizeof(val_s), "%.2f", current_value);
snprintf(val_d, sizeof(val_d), "%d", i);
if (menu_entries_append(list,
val_s,
val_d,
MENU_ENUM_LABEL_NO_ITEMS,
setting_type,
i, entry_type, NULL))
{
checked = count;
checked_found = true;
if (!checked_found &&
(fabs(current_value - original_value) < half_step))
{
checked = count;
checked_found = true;
}
count++;
}
count++;
current_value += param->step;
}
current_value += param->step;
}
if (checked_found)