Remove 'automatically add content to playlist' option - causes

memory corruption; not worth it for now
This commit is contained in:
twinaphex 2020-01-22 17:08:02 +01:00
parent 6d0286efbd
commit 276b7a03f1
22 changed files with 2 additions and 111 deletions

View File

@ -1341,7 +1341,6 @@ static struct config_bool_setting *populate_settings_bool(settings_t *settings,
SETTING_BOOL("frame_time_counter_reset_after_load_state", &settings->bools.frame_time_counter_reset_after_load_state, true, false, false);
SETTING_BOOL("frame_time_counter_reset_after_save_state", &settings->bools.frame_time_counter_reset_after_save_state, true, false, false);
SETTING_BOOL("crt_switch_resolution_use_custom_refresh_rate", &settings->bools.crt_switch_custom_refresh_enable, true, false, false);
SETTING_BOOL("automatically_add_content_to_playlist", &settings->bools.automatically_add_content_to_playlist, true, DEFAULT_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST, false);
SETTING_BOOL("ui_companion_start_on_boot", &settings->bools.ui_companion_start_on_boot, true, ui_companion_start_on_boot, false);
SETTING_BOOL("ui_companion_enable", &settings->bools.ui_companion_enable, true, ui_companion_enable, false);
SETTING_BOOL("ui_companion_toggle", &settings->bools.ui_companion_toggle, false, ui_companion_toggle, false);

View File

@ -361,7 +361,6 @@ typedef struct settings
bool bluetooth_enable;
bool localap_enable;
bool automatically_add_content_to_playlist;
bool video_window_show_decorations;
bool video_window_save_positions;

View File

@ -3493,10 +3493,6 @@ MSG_HASH(MENU_ENUM_LABEL_VALUE_VIDEO_MESSAGE_COLOR_BLUE,
"屏显消息OSDRGB颜色 蓝色")
MSG_HASH(MENU_ENUM_LABEL_VALUE_FRAMECOUNT_SHOW,
"显示FPS帧数")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"自动添加内容到游戏列表")
MSG_HASH(MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"自动扫描游戏文件,并添加在游戏列表中。")
MSG_HASH(MSG_SCANNING_OF_FILE_FINISHED,
"文件扫描完成")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUDIO_RESAMPLER_QUALITY,

View File

@ -2580,10 +2580,6 @@ MSG_HASH(MSG_INPUT_KIOSK_MODE_PASSWORD_OK,
"密碼正確")
MSG_HASH(MSG_INPUT_KIOSK_MODE_PASSWORD_NOK,
"密碼錯誤")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"自動增加遊戲內容至 playlist")
MSG_HASH(MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Automatically scans loaded content so they appear inside playlists.")
MSG_HASH(MSG_SCANNING_OF_FILE_FINISHED,
"掃瞄檔案結束")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUDIO_RESAMPLER_QUALITY,

View File

@ -3388,10 +3388,6 @@ MSG_HASH(MENU_ENUM_LABEL_VALUE_VIDEO_MESSAGE_COLOR_BLUE,
"Blau-Anteil der Bildschirmmeldungen")
MSG_HASH(MENU_ENUM_LABEL_VALUE_FRAMECOUNT_SHOW,
"Zeige die aktuelle Anzahl an Einzelbildern an")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Inhalt automatisch zur Playlist hinzufügen")
MSG_HASH(MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Scant automatisch den geladenen Inhalt, so dass er in Playlisten angezeigt wird.")
MSG_HASH(MSG_SCANNING_OF_FILE_FINISHED,
"Scannen von Datei beendet")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUDIO_RESAMPLER_QUALITY,

View File

@ -7513,14 +7513,6 @@ MSG_HASH(
MSG_RUNAHEAD_FAILED_TO_CREATE_SECONDARY_INSTANCE,
"Error al crear la segunda instancia. La reducción predictiva solo usará una a partir de este momento."
)
MSG_HASH(
MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Autoagregar contenidos a listas de reproducción"
)
MSG_HASH(
MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Busca automáticamente los contenidos para que aparezcan en las listas de reproducción."
)
MSG_HASH(
MSG_SCANNING_OF_FILE_FINISHED,
"Archivo escaneado"

View File

@ -7494,14 +7494,6 @@ MSG_HASH(
MSG_RUNAHEAD_FAILED_TO_CREATE_SECONDARY_INSTANCE,
"Impossible de créer une deuxième instance. L'éxécution en avance utilisera désormais une seule instance."
)
MSG_HASH(
MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Ajouter automatiquement aux listes de lecture"
)
MSG_HASH(
MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Analyse automatiquement le contenu chargé avec le scanner des listes de lecture."
)
MSG_HASH(
MSG_SCANNING_OF_FILE_FINISHED,
"Analyse du fichier terminée"

View File

@ -3404,10 +3404,6 @@ MSG_HASH(MSG_INPUT_KIOSK_MODE_PASSWORD_OK,
"Password corretta.")
MSG_HASH(MSG_INPUT_KIOSK_MODE_PASSWORD_NOK,
"Password non corretta.")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Aggiungi automaticamente il contenuto alla playlist")
MSG_HASH(MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Esegue automaticamente la scansione dei contenuti caricati in modo che vengano visualizzati all'interno delle playlist.")
MSG_HASH(MSG_SCANNING_OF_FILE_FINISHED,
"Scansione del file completata")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUDIO_RESAMPLER_QUALITY,

View File

@ -7230,14 +7230,6 @@ MSG_HASH(
MSG_RUNAHEAD_FAILED_TO_CREATE_SECONDARY_INSTANCE,
"2つ目のコアをスタートに失敗しました。先読みが一つのコアを使用になります。"
)
MSG_HASH(
MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"自動的にコンテンツをプレイリストに追加"
)
MSG_HASH(
MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"ロードされたコンテンツは自動的にスキャンされ, プレイリストに表示されます。"
)
MSG_HASH(
MSG_SCANNING_OF_FILE_FINISHED,
"ファイルのスキャンは完了しました。"

View File

@ -7187,14 +7187,6 @@ MSG_HASH(
MSG_RUNAHEAD_FAILED_TO_CREATE_SECONDARY_INSTANCE,
"두 번째 인스턴스를 생성하는데 실패했습니다. 미리 실행 기능에서 하나의 인스턴스만 사용됩니다."
)
MSG_HASH(
MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"재생 목록에 컨텐츠 검색 후 자동 추가"
)
MSG_HASH(
MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"컨텐츠를 자동으로 검색해 재생 목록에 표시합니다."
)
MSG_HASH(
MSG_SCANNING_OF_FILE_FINISHED,
"파일 스캔 완료"

View File

@ -1824,8 +1824,6 @@ MSG_HASH(MENU_ENUM_LABEL_FRAMECOUNT_SHOW,
"framecount_show")
MSG_HASH(MENU_ENUM_LABEL_MEMORY_SHOW,
"memory_show")
MSG_HASH(MENU_ENUM_LABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"automatically_add_content_to_playlist")
MSG_HASH(MENU_ENUM_LABEL_VIDEO_WINDOW_OPACITY,
"video_window_opacity")
MSG_HASH(MENU_ENUM_LABEL_AUDIO_RESAMPLER_QUALITY,

View File

@ -3531,10 +3531,6 @@ MSG_HASH(MSG_GAME_REMAP_FILE_LOADED,
"Załadowano plik remapu gry.")
MSG_HASH(MSG_CORE_REMAP_FILE_LOADED,
"Załadowano plik wymiany rdzenia.")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Automatycznie dodawaj zawartość do listy odtwarzania")
MSG_HASH(MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Automatycznie skanuje załadowaną zawartość, aby pojawiły się w listach odtwarzania.")
MSG_HASH(MSG_SCANNING_OF_FILE_FINISHED,
"Skanowanie pliku zakończone")
MSG_HASH(MENU_ENUM_LABEL_VALUE_VIDEO_WINDOW_OPACITY,

View File

@ -7390,14 +7390,6 @@ MSG_HASH(
MSG_RUNAHEAD_FAILED_TO_CREATE_SECONDARY_INSTANCE,
"Falha ao criar uma segunda instância. O Adiantar Quadro agora usará apenas uma instância."
)
MSG_HASH(
MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Adicione automaticamente conteúdo à lista de reprodução"
)
MSG_HASH(
MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Verifica automaticamente o conteúdo carregado para que eles apareçam dentro das listas de reprodução."
)
MSG_HASH(
MSG_SCANNING_OF_FILE_FINISHED,
"Verificação do arquivo terminado"

View File

@ -3237,10 +3237,6 @@ MSG_HASH(MSG_INPUT_KIOSK_MODE_PASSWORD_OK,
"Palavra-passe correta.")
MSG_HASH(MSG_INPUT_KIOSK_MODE_PASSWORD_NOK,
"Palavra-passe incorreta.")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Adicionar conteúdo à lista de reprodução automaticamente")
MSG_HASH(MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Verificar automaticamente conteúdo carregado de forma a que apareça nas listas de reprodução.")
MSG_HASH(MSG_SCANNING_OF_FILE_FINISHED,
"Leitura do ficheiro terminada")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUDIO_RESAMPLER_QUALITY,

View File

@ -3200,10 +3200,6 @@ MSG_HASH(MSG_INPUT_KIOSK_MODE_PASSWORD_OK,
"Пароль верен.")
MSG_HASH(MSG_INPUT_KIOSK_MODE_PASSWORD_NOK,
"Пароль неверен.")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Автоматически добавлять контент в плейлист")
MSG_HASH(MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Автоматически сканировать загруженный контент и добавлять его в плейлист.")
MSG_HASH(MSG_SCANNING_OF_FILE_FINISHED,
"Сканирование файла завершено")
MSG_HASH(MENU_ENUM_LABEL_VALUE_AUDIO_RESAMPLER_QUALITY,

View File

@ -7012,14 +7012,6 @@ MSG_HASH(
MSG_RUNAHEAD_FAILED_TO_CREATE_SECONDARY_INSTANCE,
"Failed to create second instance. RunAhead will now use only one instance."
)
MSG_HASH(
MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Oynatma listelerine otomatik olarak içerik ekleyin"
)
MSG_HASH(
MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Oynatılan tarayıcı ile yüklü içeriği otomatik olarak tarar."
)
MSG_HASH(
MSG_SCANNING_OF_FILE_FINISHED,
"Dosyanın taranması tamamlandı"

View File

@ -7570,14 +7570,6 @@ MSG_HASH(
MSG_RUNAHEAD_FAILED_TO_CREATE_SECONDARY_INSTANCE,
"Failed to create second instance. RunAhead will now use only one instance."
)
MSG_HASH(
MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Automatically add content to playlists"
)
MSG_HASH(
MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
"Automatically scans loaded content with the playlist scanner."
)
MSG_HASH(
MSG_SCANNING_OF_FILE_FINISHED,
"Scanning of file finished"

View File

@ -1332,6 +1332,7 @@ void handle_dbscan_finished(retro_task_t *task,
static void content_add_to_playlist(const char *path)
{
#if 0
#ifdef HAVE_LIBRETRODB
settings_t *settings = config_get_ptr();
if (!settings || !settings->bools.automatically_add_content_to_playlist)
@ -1343,6 +1344,7 @@ static void content_add_to_playlist(const char *path)
settings->bools.show_hidden_files,
handle_dbscan_finished);
#endif
#endif
}
static int file_load_with_detect_core_wrapper(

View File

@ -125,7 +125,6 @@ default_sublabel_macro(action_bind_sublabel_crt_switchres, MENU_ENUM
default_sublabel_macro(action_bind_sublabel_crt_switchres_super, MENU_ENUM_SUBLABEL_CRT_SWITCH_RESOLUTION_SUPER)
default_sublabel_macro(action_bind_sublabel_crt_switchres_x_axis_centering, MENU_ENUM_SUBLABEL_CRT_SWITCH_X_AXIS_CENTERING)
default_sublabel_macro(action_bind_sublabel_crt_switchres_use_custom_refresh_rate, MENU_ENUM_SUBLABEL_CRT_SWITCH_RESOLUTION_USE_CUSTOM_REFRESH_RATE)
default_sublabel_macro(action_bind_sublabel_automatically_add_content_to_playlist, MENU_ENUM_SUBLABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST)
default_sublabel_macro(action_bind_sublabel_driver_settings_list, MENU_ENUM_SUBLABEL_DRIVER_SETTINGS)
default_sublabel_macro(action_bind_sublabel_retro_achievements_settings_list, MENU_ENUM_SUBLABEL_RETRO_ACHIEVEMENTS_SETTINGS)
default_sublabel_macro(action_bind_sublabel_saving_settings_list, MENU_ENUM_SUBLABEL_SAVING_SETTINGS)
@ -2771,9 +2770,6 @@ int menu_cbs_init_bind_sublabel(menu_file_list_cbs_t *cbs,
case MENU_ENUM_LABEL_CORE_SETTINGS:
BIND_ACTION_SUBLABEL(cbs, action_bind_sublabel_core_settings_list);
break;
case MENU_ENUM_LABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST:
BIND_ACTION_SUBLABEL(cbs, action_bind_sublabel_automatically_add_content_to_playlist);
break;
case MENU_ENUM_LABEL_DRIVER_SETTINGS:
BIND_ACTION_SUBLABEL(cbs, action_bind_sublabel_driver_settings_list);
break;

View File

@ -6271,7 +6271,6 @@ unsigned menu_displaylist_build_list(file_list_t *list, enum menu_displaylist_ct
{MENU_ENUM_LABEL_NAVIGATION_BROWSER_FILTER_SUPPORTED_EXTENSIONS_ENABLE, PARSE_ONLY_BOOL},
{MENU_ENUM_LABEL_USE_BUILTIN_PLAYER, PARSE_ONLY_BOOL},
{MENU_ENUM_LABEL_FILTER_BY_CURRENT_CORE, PARSE_ONLY_BOOL},
{MENU_ENUM_LABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST, PARSE_ONLY_BOOL},
};
for (i = 0; i < ARRAY_SIZE(build_list); i++)

View File

@ -14013,23 +14013,6 @@ static bool setting_append_list(
START_SUB_GROUP(list, list_info, "State", &group_info, &subgroup_info, parent_group);
#ifdef HAVE_LIBRETRODB
CONFIG_BOOL(
list, list_info,
&settings->bools.automatically_add_content_to_playlist,
MENU_ENUM_LABEL_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
MENU_ENUM_LABEL_VALUE_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
DEFAULT_AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST,
MENU_ENUM_LABEL_VALUE_OFF,
MENU_ENUM_LABEL_VALUE_ON,
&group_info,
&subgroup_info,
parent_group,
general_write_handler,
general_read_handler,
SD_FLAG_NONE);
#endif
CONFIG_BOOL(
list, list_info,
&settings->bools.multimedia_builtin_mediaplayer_enable,

View File

@ -1422,7 +1422,6 @@ enum msg_hash_enums
MENU_LABEL(INFORMATION),
MENU_LABEL(INFORMATION_LIST),
MENU_LABEL(USE_BUILTIN_PLAYER),
MENU_LABEL(AUTOMATICALLY_ADD_CONTENT_TO_PLAYLIST),
MENU_LABEL(NETPLAY_SETTINGS),
MENU_LABEL(CONTENT_SETTINGS),
MENU_LABEL(LOAD_CONTENT_LIST),