Add 'Scanline2x' CPU video filter

Makefile.common

@@ -1922,7 +1922,8 @@ ifeq ($(HAVE_STATIC_VIDEO_FILTERS), 1)
           gfx/video_filters/blargg_ntsc_snes.o \
           gfx/video_filters/lq2x.o \
           gfx/video_filters/phosphor2x.o \
-          gfx/video_filters/normal2x.o
+          gfx/video_filters/normal2x.o \
+          gfx/video_filters/scanline2x.o
 endif
 
 ifeq ($(WANT_IOSUHAX), 1)

gfx/video_filter.c

@@ -334,6 +334,7 @@ extern const struct softfilter_implementation *twoxbr_get_implementation(softfil
 extern const struct softfilter_implementation *darken_get_implementation(softfilter_simd_mask_t simd);
 extern const struct softfilter_implementation *scale2x_get_implementation(softfilter_simd_mask_t simd);
 extern const struct softfilter_implementation *normal2x_get_implementation(softfilter_simd_mask_t simd);
+extern const struct softfilter_implementation *scanline2x_get_implementation(softfilter_simd_mask_t simd);
 
 static const softfilter_get_implementation_t soft_plugs_builtin[] = {
    blargg_ntsc_snes_get_implementation,
@@ -347,6 +348,7 @@ static const softfilter_get_implementation_t soft_plugs_builtin[] = {
    epx_get_implementation,
    scale2x_get_implementation,
    normal2x_get_implementation,
+   scanline2x_get_implementation,
 };
 
 static bool append_softfilter_plugs(rarch_softfilter_t *filt,
@@ -488,6 +490,10 @@ void rarch_softfilter_free(rarch_softfilter_t *filt)
    }
    free(filt->thread_data);
 #endif
+
+   if (filt->conf)
+      config_file_free(filt->conf);
+
    free(filt);
 }
 

gfx/video_filters/Makefile

@@ -69,7 +69,7 @@ ASMFLAGS := -INEON/asm
 asflags += -mfpu=neon
 endif
 
-objects += blargg_ntsc_snes.$(DYLIB) phosphor2x.$(DYLIB) epx.$(DYLIB) lq2x.$(DYLIB) 2xsai.$(DYLIB) super2xsai.$(DYLIB) supereagle.$(DYLIB) 2xbr.$(DYLIB) darken.$(DYLIB) scale2x.$(DYLIB) normal2x.$(DYLIB)
+objects += blargg_ntsc_snes.$(DYLIB) phosphor2x.$(DYLIB) epx.$(DYLIB) lq2x.$(DYLIB) 2xsai.$(DYLIB) super2xsai.$(DYLIB) supereagle.$(DYLIB) 2xbr.$(DYLIB) darken.$(DYLIB) scale2x.$(DYLIB) normal2x.$(DYLIB) scanline2x.$(DYLIB)
 
 all: build;
 

gfx/video_filters/Scanline2x.filt

@@ -0,0 +1 @@
+filter = scanline2x

gfx/video_filters/scanline2x.c

@@ -0,0 +1,243 @@
+/*  RetroArch - A frontend for libretro.
+ *  Copyright (C) 2010-2014 - Hans-Kristian Arntzen
+ *  Copyright (C) 2011-2018 - Daniel De Matteis
+ *
+ *  RetroArch is free software: you can redistribute it and/or modify it under the terms
+ *  of the GNU General Public License as published by the Free Software Found-
+ *  ation, either version 3 of the License, or (at your option) any later version.
+ *
+ *  RetroArch is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;
+ *  without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+ *  PURPOSE.  See the GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License along with RetroArch.
+ *  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/* Compile: gcc -o scanline2x.so -shared scanline2x.c -std=c99 -O3 -Wall -pedantic -fPIC */
+
+#include "softfilter.h"
+#include <stdlib.h>
+
+#ifdef RARCH_INTERNAL
+#define softfilter_get_implementation scanline2x_get_implementation
+#define softfilter_thread_data scanline2x_softfilter_thread_data
+#define filter_data scanline2x_filter_data
+#endif
+
+struct softfilter_thread_data
+{
+   void *out_data;
+   const void *in_data;
+   size_t out_pitch;
+   size_t in_pitch;
+   unsigned colfmt;
+   unsigned width;
+   unsigned height;
+   int first;
+   int last;
+};
+
+struct filter_data
+{
+   unsigned threads;
+   struct softfilter_thread_data *workers;
+   unsigned in_fmt;
+};
+
+static unsigned scanline2x_generic_input_fmts(void)
+{
+   return SOFTFILTER_FMT_XRGB8888 | SOFTFILTER_FMT_RGB565;
+}
+
+static unsigned scanline2x_generic_output_fmts(unsigned input_fmts)
+{
+   return input_fmts;
+}
+
+static unsigned scanline2x_generic_threads(void *data)
+{
+   struct filter_data *filt = (struct filter_data*)data;
+   return filt->threads;
+}
+
+static void *scanline2x_generic_create(const struct softfilter_config *config,
+      unsigned in_fmt, unsigned out_fmt,
+      unsigned max_width, unsigned max_height,
+      unsigned threads, softfilter_simd_mask_t simd, void *userdata)
+{
+   struct filter_data *filt = (struct filter_data*)calloc(1, sizeof(*filt));
+   (void)simd;
+   (void)config;
+   (void)userdata;
+
+   if (!filt) {
+      return NULL;
+   }
+   /* Apparently the code is not thread-safe,
+    * so force single threaded operation... */
+   filt->workers = (struct softfilter_thread_data*)calloc(1, sizeof(struct softfilter_thread_data));
+   filt->threads = 1;
+   filt->in_fmt  = in_fmt;
+   if (!filt->workers) {
+      free(filt);
+      return NULL;
+   }
+   return filt;
+}
+
+static void scanline2x_generic_output(void *data,
+      unsigned *out_width, unsigned *out_height,
+      unsigned width, unsigned height)
+{
+   *out_width = width << 1;
+   *out_height = height << 1;
+}
+
+static void scanline2x_generic_destroy(void *data)
+{
+   struct filter_data *filt = (struct filter_data*)data;
+   if (!filt) {
+      return;
+   }
+   free(filt->workers);
+   free(filt);
+}
+
+static void scanline2x_work_cb_xrgb8888(void *data, void *thread_data)
+{
+   struct softfilter_thread_data *thr = (struct softfilter_thread_data*)thread_data;
+   const uint32_t *input = (const uint32_t*)thr->in_data;
+   uint32_t *output = (uint32_t*)thr->out_data;
+   unsigned in_stride = (unsigned)(thr->in_pitch >> 2);
+   unsigned out_stride = (unsigned)(thr->out_pitch >> 2);
+   unsigned x, y;
+
+   for (y = 0; y < thr->height; ++y)
+   {
+      uint32_t *out_ptr = output;
+      for (x = 0; x < thr->width; ++x)
+      {
+         /* Note: We process the 'padding' bits as though they
+          * matter (they don't), since this deals with any potential
+          * byte swapping issues */ 
+         uint32_t color            = *(input + x);
+         uint8_t  p                = (color >> 24 & 0xFF); /* Padding bits */
+         uint8_t  r                = (color >> 16 & 0xFF);
+         uint8_t  g                = (color >>  8 & 0xFF);
+         uint8_t  b                = (color       & 0xFF);
+         uint64_t color64          = (uint64_t)color;
+         uint64_t scanline_color64 =
+               (((p >> 1) + (p >> 2)) << 24) |
+               (((r >> 1) + (r >> 2)) << 16) |
+               (((g >> 1) + (g >> 2)) <<  8) |
+               (((b >> 1) + (b >> 2))      );
+
+         color64          |= (color64          << 32);
+         scanline_color64 |= (scanline_color64 << 32);
+
+         *(uint64_t *)(out_ptr)              = color64;
+         *(uint64_t *)(out_ptr + out_stride) = scanline_color64;
+
+         out_ptr += 2;
+      }
+
+      input  += in_stride;
+		output += out_stride << 1;
+   }
+}
+
+static void scanline2x_work_cb_rgb565(void *data, void *thread_data)
+{
+   struct softfilter_thread_data *thr = (struct softfilter_thread_data*)thread_data;
+   const uint16_t *input = (const uint16_t*)thr->in_data;
+   uint16_t *output = (uint16_t*)thr->out_data;
+   unsigned in_stride = (unsigned)(thr->in_pitch >> 1);
+   unsigned out_stride = (unsigned)(thr->out_pitch >> 1);
+   unsigned x, y;
+
+   for (y = 0; y < thr->height; ++y)
+   {
+      uint16_t * out_ptr = output;
+      for (x = 0; x < thr->width; ++x)
+      {
+         uint16_t color            = *(input + x);
+         uint8_t  r                = (color >> 11 & 0x1F);
+         uint8_t  g                = (color >>  6 & 0x1F);
+         uint8_t  b                = (color       & 0x1F);
+         uint32_t color32          = (uint32_t)color;
+         uint32_t scanline_color32 =
+               (((r >> 1) + (r >> 2)) << 11) |
+               (((g >> 1) + (g >> 2)) <<  6) |
+               (((b >> 1) + (b >> 2))      );
+
+         color32          |= (color32          << 16);
+         scanline_color32 |= (scanline_color32 << 16);
+
+         *(uint32_t *)(out_ptr)              = color32;
+         *(uint32_t *)(out_ptr + out_stride) = scanline_color32;
+
+         out_ptr += 2;
+      }
+
+      input  += in_stride;
+		output += out_stride << 1;
+   }
+}
+
+static void scanline2x_generic_packets(void *data,
+      struct softfilter_work_packet *packets,
+      void *output, size_t output_stride,
+      const void *input, unsigned width, unsigned height, size_t input_stride)
+{
+   /* We are guaranteed single threaded operation
+    * (filt->threads = 1) so we don't need to loop
+    * over threads and can cull some code. This only
+    * makes the tiniest performance difference, but
+    * every little helps when running on an o3DS... */
+   struct filter_data *filt = (struct filter_data*)data;
+   struct softfilter_thread_data *thr = (struct softfilter_thread_data*)&filt->workers[0];
+
+   thr->out_data = (uint8_t*)output;
+   thr->in_data = (const uint8_t*)input;
+   thr->out_pitch = output_stride;
+   thr->in_pitch = input_stride;
+   thr->width = width;
+   thr->height = height;
+
+   if (filt->in_fmt == SOFTFILTER_FMT_XRGB8888) {
+      packets[0].work = scanline2x_work_cb_xrgb8888;
+   } else if (filt->in_fmt == SOFTFILTER_FMT_RGB565) {
+      packets[0].work = scanline2x_work_cb_rgb565;
+   }
+   packets[0].thread_data = thr;
+}
+
+static const struct softfilter_implementation scanline2x_generic = {
+   scanline2x_generic_input_fmts,
+   scanline2x_generic_output_fmts,
+
+   scanline2x_generic_create,
+   scanline2x_generic_destroy,
+
+   scanline2x_generic_threads,
+   scanline2x_generic_output,
+   scanline2x_generic_packets,
+
+   SOFTFILTER_API_VERSION,
+   "Scanline2x",
+   "scanline2x",
+};
+
+const struct softfilter_implementation *softfilter_get_implementation(
+      softfilter_simd_mask_t simd)
+{
+   (void)simd;
+   return &scanline2x_generic;
+}
+
+#ifdef RARCH_INTERNAL
+#undef softfilter_get_implementation
+#undef softfilter_thread_data
+#undef filter_data
+#endif

griffin/griffin.c

@@ -919,6 +919,7 @@ FILTERS
 #include "../gfx/video_filters/lq2x.c"
 #include "../gfx/video_filters/phosphor2x.c"
 #include "../gfx/video_filters/normal2x.c"
+#include "../gfx/video_filters/scanline2x.c"
 
 #include "../libretro-common/audio/dsp_filters/echo.c"
 #include "../libretro-common/audio/dsp_filters/eq.c"