libretro/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch.git synced 2024-12-14 20:59:06 +00:00
Code Issues Actions 23 Packages Projects Releases Wiki Activity

Catch another edge case - this function is a mess and a minefield -

Browse Source 
we need additional helpers to file_path.c and we need to properly
clean this up
This commit is contained in:
twinaphex 2018-01-23 04:49:36 +01:00
parent 4a7bfa463f
commit a6ff88a094
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
menu/drivers/xmb.c
View File

@ -991,7 +991,7 @@ static void xmb_update_thumbnail_path(void *data, unsigned i)
else if (filebrowser_get_type() != FILEBROWSER_NONE)
{
xmb->thumbnail_file_path[0] = '\0';
xmb->thumbnail = 0;
xmb->thumbnail = 0;
goto end;
}
@ -1046,14 +1046,16 @@ static void xmb_update_thumbnail_path(void *data, unsigned i)
fill_pathname_join(tmp_new,
xmb->thumbnail_file_path,
tmp, PATH_MAX_LENGTH * sizeof(char));
strlcpy(xmb->thumbnail_file_path,
tmp_new, sizeof(xmb->thumbnail_file_path));
if (!string_is_empty(tmp_new))
strlcpy(xmb->thumbnail_file_path,
tmp_new, sizeof(xmb->thumbnail_file_path));
}
free(tmp);
strlcat(xmb->thumbnail_file_path,
file_path_str(FILE_PATH_PNG_EXTENSION),
sizeof(xmb->thumbnail_file_path));
if (!string_is_empty(xmb->thumbnail_file_path))
strlcat(xmb->thumbnail_file_path,
file_path_str(FILE_PATH_PNG_EXTENSION),
sizeof(xmb->thumbnail_file_path));
end:
menu_entry_free(&entry);