From d2aeba0a9279ca1b510d89c9d2439b356140943c Mon Sep 17 00:00:00 2001 From: libretroadmin Date: Fri, 22 Jul 2022 02:25:49 +0200 Subject: [PATCH] Cleanup - remove NULL-termination since we pass fullname now to strlcpy always at first --- menu/menu_driver.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/menu/menu_driver.c b/menu/menu_driver.c index e0e02cfd08..9b2f2b36ee 100644 --- a/menu/menu_driver.c +++ b/menu/menu_driver.c @@ -3756,25 +3756,19 @@ bool menu_shader_manager_save_preset_internal( enum rarch_shader_type type = RARCH_SHADER_NONE; char *preset_path = NULL; size_t i = 0; - - fullname[0] = buffer[0] = '\0'; - if (!shader || !shader->passes) return false; - if ((type = menu_shader_manager_get_type(shader)) == RARCH_SHADER_NONE) return false; + buffer[0] = '\0'; preset_ext = video_shader_get_preset_extension(type); if (!string_is_empty(basename)) - { strlcpy(fullname, basename, sizeof(fullname)); - strlcat(fullname, preset_ext, sizeof(fullname)); - } else - snprintf(fullname, sizeof(fullname), "retroarch%s", - preset_ext); + strlcpy(fullname, "retroarch", sizeof(fullname)); + strlcat(fullname, preset_ext, sizeof(fullname)); if (path_is_absolute(fullname)) {