mirror of
https://github.com/libretro/RetroArch.git
synced 2026-11-22 10:50:15 -10:00
codex/android-native-streaming
167
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
abd275b917 |
ci: validate extended shaders with current Vulkan feature rules
The unsized uniform-buffer fixture uses a Vulkan extension added after the system standalone validator. Running it through the old Vulkan 1.0 profile rejects a legal Uniform/Block runtime array. Its std430 layout also needs the standard uniform-buffer layout feature enabled during independent validation. Use a pinned current SPIRV-Tools validator and matching headers in a dedicated cached CI job. Keep Vulkan 1.0 for ordinary fixtures and Vulkan 1.1 for subgroup operations; apply the extension fixture's required rules only to that module. Do not skip incompatible-validator failures or relax other shaders' checks. Deliberately misalign a member of the emitted UBO and require its rejection. Validation: all 40 emitted SPIR-V modules pass current standalone validation; the corrupted UBO fails alignment validation. Extended compiler and builder contracts pass ASan/UBSan, and all five emitted GLSL programs pass glslang. The pinned setup helper passes cold-source and cached-build runs. No production shader compiler or device-feature admission is changed. |
||
|
|
f1675e7f4f |
core signatures: the load check's gate and check task
core_load_check.c checks a core before it is opened: the quick check on the main thread, else a task hashes it in slices of the shared I/O window and keeps the result for the load, bound to the file it checked. A refusal tells whether it only waits for the first run's seed. Built with HAVE_CORE_LOAD_CHECK; nothing calls it yet. Its unit harness runs in the samples-tasks job, under ASan and UBSan, TSan and mingw-w64. On Windows the check reads the file LoadLibraryW will load: a name with no '.' is read as <name>.dll, and a \\?\ path ending in '.' is refused, since CreateFileW opens that name as written while LoadLibraryW may drop the dot and map another file. |
||
|
|
f1df7cf157 |
core signatures: check a core staged for install
Adds the check the install paths will use: a core is staged under the name it is installed as, checked there and only then moved into place. The check hashes the staged file even when a record or the folder rule would pass the file in place: those vouch for the file, not the download. A check reads as failed until it ends, so a cancel is a failure. The old .sig is set aside as <core>.sig.old while the core is renamed in, then deleted, or renamed back when the rename fails; the new .sig is placed and the identity read again after the rename. A crash in between leaves a core without a .sig, never a new core beside the old one's .sig, and a stray .sig.old is never put back. A core that passed by its trusted hash keeps its staged .sig only if that .sig verifies on its own. |
||
|
|
3e010f2ce6 |
core signatures: keep the trust store in RetroArch
core_trust_runtime owns the one store: loaded at startup before any core is opened, saved by a task after each change with one write out at a time, and written once more at quit, within the exit drain's limit, if a change didn't go through. A store that can't be read is left alone and the session's changes stay in memory. With no keys compiled in, nothing is loaded and the feature acts as if it weren't built. A test-key build says so at every launch. Test-key builds keep their store in core_trust.testkey, so what they record never reaches a release build's store on the same account. On macOS the store always lives in ~/Library/Application Support/RetroArch, whatever portable.txt, RAPortableInstall or a Steam build say about the app's folder. |
||
|
|
7e8aeb9d61 |
core signatures: build switches
HAVE_CORE_SIGNATURES builds the signature check and its trust store, HAVE_CORE_LOAD_CHECK the check at every core load, and HAVE_CORE_SIGNING_TEST_KEY the public test key. The first defaults on where dynamic loading and the crypto library are, a line to turn off for one target; the load check and the test key default off. configure has --disable-core_signatures, --enable-core_load_check and --enable-core_signing_test_key. griffin stops with an #error when HAVE_CORE_SIGNATURES is set without HAVE_CRYPTO, as it does for HAVE_S3, rather than failing on crypto/pk.c's missing symbols. |
||
|
|
155c1d8f59 |
retro_posix_source.h: ask old glibc for BSD and SVID names too
glibc before 2.19 ignores _DEFAULT_SOURCE, and the _POSIX_C_SOURCE set here turns off its implicit _BSD_SOURCE, so strcasecmp(), M_PI, syscall(), MAP_ANONYMOUS and SA_ONSTACK go undeclared. webOS ships glibc 2.12, where a core's net_http.c no longer compiled. _BSD_SOURCE and _SVID_SOURCE are what such a glibc enables by default; newer ones accept them silently beside _DEFAULT_SOURCE. The webOS job compiles every file including the header with the SDK's compiler and no feature macros of its own. |
||
|
|
a86d86a22c |
HAVE_RGIF: GIF images through image_texture, image_transfer and the tasks
rgif now loads GIFs wherever RetroArch loads images: thumbnails and
backgrounds through task_image, the image viewer core, the file browser
and the image_texture/image_transfer layer underneath them all.
rgif:
- the image_transfer interface the other decoders have:
rgif_set_buf_ptr, rgif_set_avail, rgif_header_ready and
rgif_process_image, giving a 32-bit texture of its own, ARGB32 or
ABGR32 in native byte order
- RGIF_ABGR, for ABGR32 on big-endian targets
- a file not all read yet gives IMAGE_PROCESS_WAIT and is not touched;
the image is decoded in one call once it is all in
Wiring, as HAVE_RTGA is wired:
- IMAGE_TYPE_GIF (image.h) and NBIO_TYPE_GIF (task_file_transfer.h),
both appended so no other value moves
- image_texture_get_type: .gif
- image_transfer: new, free, start, is_valid, set_buffer_ptr, process,
set_avail; the support matrix gains a GIF column
- task_image and task_file_transfer: GIF is an image task
- FILE_TYPE_GIF ("gif", "GIF"): opened as image content
- the file browser's image extensions, the image viewer core's
extensions, the System Information list ("GIF (RGIF)") and
--features ("RGIF"); SUPPORTS_RGIF in config.features.h
- griffin.c, Makefile.common (rgif.o), configure (HAVE_RGIF=yes), and
next to HAVE_RTGA in every platform Makefile, the Android, Apple,
MSVC, UWP and QNX projects and the CI compile matrix
- tools/settings_check.py and tools/stack_budget.py check with it
Also: menu_displaylist's image viewer extension list wrote "tga"
without moving its length on, so "webp" and "dds" landed on top of it
and TGA dropped out of the list; it moves on now.
Tests: rgif_test checks the texture in both byte orders against
rgif_decode, the wait before the whole file is in, and a refused file;
image_decode_fuzz sweeps GIF too (every byte of a small GIF set to
edge values, and every truncation), under ASan and UBSan. The griffin
unity build with every codec, the touched objects in a configured
build, the MinGW/C89 syntax check, the overlap check and the stack
budget pass.
|
||
|
|
6e59d31074 |
audio: stream native WMA through mixer and media player
Add borrowed ASF and RIFF/xWMA streams with bounded fragment assembly. Drain decoder planes directly into audio_transfer output and reuse the mixer's streaming voices. Route music input through VFS-backed moving windows. The builtin player uses source-rate integer intervals, float callbacks when supported and a legacy S16 fallback. Respect partial callback acceptance and reset without retaining a growing output queue. Gate the feature with HAVE_RWMA, disabled by default, and preserve FFmpeg/MPV selection. Test analytic PCM, packet fragments and refill, loop reset, implicit xWMA setup, truncated objects, sample-rate cadence, callback backpressure and codec-disabled builds. |
||
|
|
21e43db393 |
CI: measure the hot-function budget under GCC 15
menu-harness failed its hot-function budget on Ubuntu 26.04: audio_driver_sample_batch came out at 623 bytes against a 512 ceiling, with runloop_iterate and video_thread_frame a few bytes short of theirs. Built from the same tree, GCC 13 emits 511, 6911 and 4319 bytes for the three and GCC 15 623, 8026 and 4825, so the step is the compiler and not the source. The reference now holds what GCC 15 measures on the runner, frames included; the quarter of slack above it is for the next real change. |
||
|
|
a4838c9cb1 |
CI: put wineserver on the PATH where Wine's packages do not
Wine 10's Ubuntu packages keep wineserver in Wine's library directory with nothing on the PATH, and the jobs start and stop it by name: the network clients' Windows builds stopped at 'wineserver: command not found', and every 'wineserver -k' and 'wineserver -w' elsewhere quietly did nothing. apt-install.sh links it into /usr/local/bin when it finds it there and not on the PATH. |
||
|
|
8360f25509 |
CI: run the slow audio samples' real-time lanes at once
Three steps of Linux-samples-audio took six minutes between them, and two of them spent it waiting: pipeline_rate_control's eight runs and pipeline_clocked's fill cap lanes are seconds of audio each against a device that drains in real time, on almost no CPU, run one after another. .github/workflows/scripts/run-parallel.sh starts commands at once and, when all are done, prints each one's output in order with a pass or FAIL line, failing the step if any failed. The rate control step builds its ASan and TSan binaries in turn and runs all eight at once; the fill cap step runs its five lanes at once, pipeline_clocked_test taking PACED_ONLY=<lane> to run one (PACED_ONLY=1 still runs them all). discrete_multichannel_test is CPU-bound - most of it building Kaiser tables - so it is now built at -O1 instead of -O0, and its plain and ASan runs share the runner's cores. Measured on two cores: pipeline_rate_control 162 -> 33 s of runs, the fill cap lanes 116 -> 36 s, discrete_multichannel 87 -> 40 s. Each new arrangement passed three times in a row there. |
||
|
|
0fc5e5356d |
audio: no state lock where the atomics have pointer operations
Without the threaded pipeline, the thread that submits the core's audio holds the inline state: a submit takes inline_busy with a compare-and- swap and records itself as the owner. The main thread's pause, resume, format change and stop reset are published as request words, as the threaded pipeline's already are, and carried out by that thread at its next submit - before its gates, so a silenced core's thread writes its pause tail - or at once by the main thread when it is the submitter, or nothing has submitted yet. A callback core's thread settles them in its loop. A submit that finds the main thread carrying a request out drops its batch rather than wait. The core format the mixer follows is published by the flush. audio_driver_sample_batch grows by the call that settles requests on the submitting thread, and its hot-function reference moves with it. With that, every holder of the state lock is a pass that no other runs beside, and the lock is only made where the atomics have no pointer operations; elsewhere audio_driver_state_lock() counts the pass and nothing more. ff_speedup pauses a core that submits from its own thread and checks the main thread writes no tail and that thread writes it at its next submit. |
||
|
|
f23cc50ca4 |
android: play_feature_delivery/ to os/android
The Play Feature Delivery glue is Android's alone - JNI calls into RetroActivityCommon - and the last platform directory of its kind at the tree's root. It joins the other OS layers under os/; includes, the Makefile, griffin, the compile matrix and the two samples that build it follow. |
||
|
|
8f1e421733 |
wiiu: take in what it used of libiosuhax, drop deps/libiosuhax
RetroArch used libiosuhax for three things: opening the IOSU handle and an FSA client in os/wiiu/main.c, the storage_usb devoptab, and the raw SD/USB sector access libfat reads sd: and usb: through. Those now live in os/wiiu/fs/iosuhax.c, with everything but what main.c and libfat call made static. deps/libiosuhax is gone. Never used, so not taken: IOSU memory and kernel read/write, the SVC call, volume flush, FSA mount/unmount (main.c always registered an already-mounted path), and chmod, which newlib never reached - the devoptab table had the chmod handler in the deviceData slot, which mount_fs then overwrote. The table now has newlib's order, as libfat's does. No locks: every FSA call is one IPC request the iosuhax server carries out on its own, and nothing is shared between threads once a device is mounted, so the per-device OS mutex is gone. The one shared resource left is a data buffer, claimed with a retro_atomic exchange; a thread that finds it held stages through the stack instead. No allocation per call: every call used to memalign one or two buffers, every path was malloc'd, and every directory entry too. Requests are now built in aligned stack buffers and paths written straight into them. File and sector data go through a stack buffer up to 1 KB, the shared 128 KB buffer made at mount up to that, and beyond it straight into the caller's buffer: the server puts its reply header in front of the data, so the 0x40 bytes in front of the stretch being read are kept aside and put back. A large ROM read no longer allocates a buffer its own size and copies it; the data is never copied. Bugs fixed: - statvfs had the device info call write 0x64 bytes into an 8-byte stack variable - stat read the path after freeing it - fstat passed the file state's address as the FSA file handle - open checked the wrong pointer for allocation failure - seek with an unknown origin returned with the mutex held - the device lookup used strtok, which is not thread safe - read reported an error as end of file; it now returns -1 - seeking from the end after writing past it used the old length Requests are byte for byte what libiosuhax sent: both were run on 32-bit big-endian PowerPC against a recorder and compared. The data paths were run against a fake server for every size and alignment, with the shared buffer free and held, short reads and reads past the end, under AddressSanitizer, with guard bytes around the caller's buffer. A compile-matrix lane now builds the file against a stand-in for newlib's sys/iosupport.h. |
||
|
|
9c20573bc3 |
CI: build an aarch64 Linux binary with OpenXR (#19917)
A job on the ubuntu-24.04-arm runner builds RetroArch with OpenXR and uploads the stripped binary, so aarch64 testers, such as Steam Frame users, can download a build of any commit or pull request. The apt cache key now carries the runner's architecture off x86-64, so an arm job never restores an amd64 entry; x86-64 keys are unchanged and their caches stay warm. When a download stalls, apt-install.sh retries architectures other than amd64 and i386 from ports.ubuntu.com, since archive.ubuntu.com carries no arm64 packages. |
||
|
|
e6e0404029 |
go2 drm context: take in what it used of libgo2, drop deps/libgo2
Only one file in RetroArch ever used libgo2: the ODROID-GO Advance GL context, gfx/drivers_context/drm_go2_ctx.c. The oga video driver already talks to librga and DRM itself, and libgo2's audio, input, backlight, PNG and queue code was never called. What the context used - open the panel, make the EGL/GBM surface, and have the RGA scale and rotate each frame into a portrait buffer for the CRTC - now lives in the context itself, and deps/libgo2 is gone. No thread, queue, mutex or semaphore remains. libgo2 ran a render thread, a mutex-guarded queue and two semaphores only to hide a full drmModeSetCrtc modeset every frame. Frames are now page-flipped with drmModePageFlip, which the kernel already does asynchronously, so the only wait left is for the previous flip to land before the next is queued - the vsync throttle itself - and the RGA work for the new frame runs before that wait instead of after it. That is also one frame less latency than the old three-deep queue. A driver that refuses page flips falls back to drmModeSetCrtc. Overhead taken out of the frame: - the whole-screen RGA colour fill before every blit is gone; the borders beside the picture are cleared once per buffer when the picture's size or position changes, and never when it fills the panel - each GBM buffer's prime fd is exported once and kept on the buffer (gbm_bo user data) instead of a per-frame search of a malloc'd list - the scanout buffers' fds, strides and formats are worked out at init, not per blit - nothing is allocated per frame With vsync off (swap interval 0, e.g. fast-forward) a frame whose flip would have to wait is not shown rather than waited for, so the core runs uncapped without tearing; before, the interval was ignored. The EGL context now comes from egl_common like drm_ctx's, so egl_bind_hw_render works on it (a hardware core gets its shared context) instead of being handed an empty egl_ctx_data_t. It is still GLES 3. Fixed on the way: the context data was never freed, prime fds were leaked, and the console's CRTC is put back on exit. -lpng and -lz are no longer linked for HAVE_ODROIDGO2; only libgo2's unused PNG writer needed them. A compile-matrix lane now builds the context against the librga stand-in; nothing compiled it before. |
||
|
|
43ce599231 |
compile-matrix: build every x86 SIMD unit for the PS4 and PS5 targets
PlayStation clang declares in immintrin.h only the intrinsics of the ISAs a whole build enables, so a kernel under a per-function AVX2 or AVX-512 target compiles on every host and fails on Orbis. The matrix now finds each unit carrying a per-function target or 256/512-bit intrinsics by content and compiles it for x86_64-scei-ps4 (AVX) and x86_64-sie-ps5 (AVX2, no AVX-512), so a new one is checked the day it lands. A clang without the targets reports the lane skipped. |
||
|
|
00a3de3cd7 |
Temporal upscaler: HAVE_TEMPORAL_UPSCALER gates the subsystem
HAVE_NGX gated the whole temporal upscaler - the interface handed to cores, the settings, the threaded wrapper's carry and the DLSS, FSR and XeSS backends alike - under the name of one vendor's library. A MetalFX backend on the Metal driver would have to be built under a define that reads as NVIDIA's. The subsystem is now HAVE_TEMPORAL_ UPSCALER wherever HAVE_NGX stood, in the build files, the drivers, the menu, the samples and the compile matrix; nothing changes in what is built. |
||
|
|
d97736342a |
Wii U: the runtime moves to os/wiiu
The tree's Wii U layer (the coreinit, GX2, AX and friends headers, the RPX import stubs, startup and linker scripts, the newlib hooks, the exception handler, the SD devoptab, the HBL loader and the elf2rpl and slang-cafe host tools) lives under os/wiiu, beside os/gekko. Makefile.wiiu builds from there with -Ios/wiiu -Ios/wiiu/include, so <wiiu/...> headers resolve as before; the few includes that reached files through the tree root name os/wiiu. |
||
|
|
a025681d84 |
salamander: link only what the launchers use
No launcher calls into lrc_hash.c, and on x86 its SHA dispatch reaches cpu_features_get(), which no launcher links: the DOS salamander, whose link keeps every section, cannot resolve it. lrc_hash.o leaves every salamander object list. The Wii launcher's logger build links net_socket.c, which reads cpu_features_get_time_usec(), so that build links features_cpu.o as well. compile-matrix.sh now links each launcher's libretro-common list, read from its Makefile, with frontend_salamander.c and a host frontend driver (tools/platform_stubs/salamander_frontend.c), so a unit in a list that needs one outside it fails there. |
||
|
|
aca5868b04 |
Temporal Upscaler: FSR and XeSS beside DLSS
The setting gains AMD FSR and Intel XeSS, on the Vulkan and Direct3D 12 drivers as DLSS is. Each runs on its vendor's library, loaded at run time from a directory of the user's and never bundled: FSR through the FidelityFX API (amd_fidelityfx_vk.dll for Vulkan, FSR 3.1; SDK 2's amd_fidelityfx_loader_dx12.dll or SDK 1.1's amd_fidelityfx_dx12.dll for Direct3D 12, where the newest version the library offers the device is taken, FSR 4 on the GPUs that have it), XeSS through libxess.dll on either driver. The FSR and XeSS directories are settings beside the DLSS one, upscalers/fsr and upscalers/xess in the RetroArch directory by default. libretro-common gains the loaders (gfx/amd/ffx_loader, gfx/intel/ xess_loader), C89, with the SDKs' descriptor layouts and type numbers declared so no SDK header is needed, and samples that pin those layouts to the SDKs' sizes and offsets and drive the loaders against stand-in libraries. The drivers go through one dispatch (vulkan_upscaler, d3d12_upscaler) over the three backends, which share the output image, the layout moves around a dispatch and the ring that retires an image and context after the frames in flight. XeSS builds its pipelines in the library's background thread and the frames are shown as they are until they are ready; nothing on the frame path waits. The frontend's mode word carries the quality and preset as set and each backend translates it, so the DLSS preset keeps its meaning and the others ignore it. The upscaler samples run FSR and XeSS behind the dispatch on lavapipe and on Wine's D3D12 against the stand-ins, with the inputs' flags, formats, states, scales and reset read back from the descriptors the libraries were given. |
||
|
|
9a13b897bb |
Cg: reuse GLES declarations in the shader backend
Use the Cg header switch to reuse the GL declarations already supplied by gl2_common. This prevents a desktop function declaration from colliding with the GLES3 symbol wrapper. Cover GLES2 and GLES3 Cg combinations with Linux and MinGW compilers in the compile matrix. |
||
|
|
c93e833c8b |
D3D12: DLSS Super Resolution through NGX
The Direct3D 12 driver gets the temporal upscaler the Vulkan driver has: a core that brought motion vectors and depth through the upscaler interface has its frame evaluated by DLSS on the frame's command list, and the output takes the core's texture's place for the copy into the filter chain. gfx/common/d3d12_ngx.c mirrors vulkan_ngx.c: one session per device, a feature per output size and mode made for the mode's full dynamic range, inputs moved to shader-readable states and back, the output a copy source, retired features and outputs released after the frames in flight. samples/gfx/d3d12_upscaler drives the real backend on Wine's D3D12 (vkd3d over lavapipe) against a stand-in NGX core library whose evaluate copies the colour into the output, so the feature and evaluate parameters, the states and the readable output are pinned on every runner. Compile-matrix lanes build the backend and the driver with HAVE_NGX, with and without threads. |
||
|
|
f7d82e4c0e |
media: decode AVC and HEVC tracks in Matroska
Retain container timing and hidden-picture state through incremental reads, reordered output and native frame leases. Route supported tracks through the existing decoders and GPU imports, with software, mock and native regression coverage. |
||
|
|
ccffeb553a |
slang: drop vendored glslang and SPIRV-Cross
rslc is the slang compiler everywhere. ./configure --enable-glslang --enable-spirv_cross links the system's glslang and SPIRV-Cross next to it when both are found, and only then does Settings > Drivers offer a Shader Compiler choice between the two: one setting read per stage picks the path, with nothing copied. The MSVC 2010 project builds Vulkan and rslc. Samples that used the vendored copies run on rslc or the system's SPIRV-Cross. |
||
|
|
1d4655730c |
CI: one Wine server for each Wine step that needs no display
Each program run under Wine started a server that left after it, and a
program started as the last server was leaving was cut off before
main() ("wine client error:0: recvmsg: Connection reset by peer"),
failing the job with nothing wrong in the tree. Steps that run Wine
programs and need no display now source scripts/wine-server.sh, which
keeps one server up for the step and starts Wine's services at once
with no output, so they cannot hold a step's pipe open. Steps that
open windows under Xvfb, start the server themselves or use a prefix
of their own are left as they are: Wine's desktop process, started by
their first window, would hold their output.
|
||
|
|
0b78073eb1 |
Revert "CI: one Wine server for each step that runs programs under Wine"
A server kept for the whole step keeps the Wine services the step's first program starts, and they hold that program's output: a step that pipes a Wine program into tee or grep waits for an end of output that does not come while the server lives. Linux-msvc6-standin's Win32 input step passed its test and then hung for an hour. Back to a server for each program until the race is fixed without that. |
||
|
|
a7f7adc5c9 |
CI: one Wine server for each step that runs programs under Wine
Each program run under Wine started a server that left after it, and a
program started as the last server was leaving was cut off before
main() ("wine client error:0: recvmsg: Connection reset by peer"),
failing the job with nothing wrong in the tree. Steps that run Wine
programs now source scripts/wine-server.sh, which keeps one server up
for the step and ends it with the step. Steps that already manage the
server, or set their own trap, are left as they are.
|
||
|
|
74b7b06fa5 |
Android second display output for video views (gl and vulkan) (#19905)
* android: drain the sensor queue with both sensors off
Losing focus disables the accelerometer and gyroscope, but an event
already in the sensor queue stays there, and android_input_poll_user()
only read the queue while a sensor was on. The queue's fd stays
readable, so ALooper_pollOnce() keeps returning LOOPER_ID_USER and
android_input_poll() spins at full CPU. The pause and stop
acknowledgements wait for the next runloop iteration, which never
comes: RetroArch logs "App thread did not acknowledge activity state",
the launcher shows late and the app hangs until it gets focus back.
A swipe home hits it often, since focus is lost before onPause.
Always drain the queue and apply the events only while a sensor is on.
* gl2: make a regrown pass texture as the pass's first one
gl2_recreate_fbo() gave the larger texture no filter, so it kept GL's
default GL_NEAREST_MIPMAP_LINEAR with a single level. On GLES that
texture is incomplete, and once a viewport-scaled pass grew, the next
pass sampled black; desktop GL with texture storage gets a complete
one-level texture. Make it with gl2_create_fbo_texture(), as at init, so
it also keeps the pass's filter, wrap mode and float or sRGB format. The
feedback texture is regrown the same way.
* video: per-screen window settings and the screens' window plan
Each screen gets window settings in the config,
video_screenN_window_mode, _x, _y, _width, _height, _monitor and
_fullscreen: Attached, Separate or Hidden, and where a window of its own
goes and how big it is. Screen 1 is always Attached; the others default
to Separate. video_windows_enable, off by default, is the switch that
lets screens leave the main window at all.
video_windows_plan() turns those settings into a frame's plan: the
screens the main window draws, the ones that go to windows of their own
and the hidden ones. A screen stays in the main window while the switch
is off, where the driver has no windows, or once the renderer has sent
it back. The views layout takes exclude_screens, so the main window lays
out only the screens it keeps, and a window only its own.
This is the base the desktop secondary windows and the Android second
display share. The video_windows harness, run in the Linux gfx samples
workflow, checks the plan and a layout with screens left out.
* video: contract for secondary screens' native windows
A context can offer windows of their own for secondary core screens
through an optional gfx_ctx_window_driver_t, the last member of
gfx_ctx_driver_t: create, update, poll and destroy, and bind and
present for GL contexts. Requests, native handles and events carry a
generation from video_driver_window_generation(), a frontend counter
that a driver or context restart does not reset, so an event that
outlives its window cannot be taken for its replacement's.
GFX_CTX_FLAGS_VIDEO_WINDOWS is what a video driver will report once it
draws to such windows; nothing sets it yet.
* egl: window surfaces for secondary screens
egl_window_surface_new/bind/swap/free give a secondary screen's window
a surface on the main context's display and config, with the main
window's attributes. Bind makes the context current on it at swap
interval 0, or on the main surface again; free puts the main surface
back first where the freed one is current. None of them log.
* video: share the secondary windows' event bookkeeping
What a native layer keeps of each secondary window for the frontend -
its owner, record, request, position, the events waiting one bit per
kind, and whether it closed - is a video_window_common_t at the start
of its own state, and the rules on it live once in gfx/video_windows.c:
marking a window closed (CLOSE, with FOCUS_LOSS where it had the focus,
a waiting gain or resume dropped), poll's drain in its fixed order with
whatever has no room left waiting, and the sweep of an owner's windows
at context teardown.
* video: one placement clamp for secondary windows
video_window_place_rect() puts saved bounds on a monitor or its work
area: bounds partly on it are moved onto it, automatic ones and those
not on it at all are centred, and the size is clamped. Whether bounds
are on it is judged as saved, before the size is clamped, so an
oversized window partly on it keeps its position on the other axis.
* video: frame snapshot for secondary windows
A frame presented with views now carries what a driver needs to make,
place and lay out the screens' own windows without reading settings:
each screen's window settings, the window plan, the core's own map and
frame size, the layout parameters and a restore count, from which
video_driver_window_layout() lays out one screen's window. The snapshot
lives in video_driver_state_t and video_frame_info_t points at it, NULL
while windows are off or the driver cannot make them; the threaded
wrapper copies it into the frame's slot, as it does the statistics text.
While the driver can make windows, the main window's layout leaves out
the screens that have one of their own or are hidden.
video_driver_restore_windows() clears the screens a close attached and
counts the request, and window generations can be taken on any thread.
* video: published layouts and translate for secondary windows
A renderer publishes each secondary window's layout as drawn, with the
core map it was made from and the window's client size, through
video_driver_publish_window_layout() from the thread that runs the
context. Latest wins with no lock: each window has three slots handed
over by index exchange, as the window title is, and NULL clears it.
video_driver_translate_window_point() maps a point in a window to the
core's frame: window 0 through the viewport, as before, and a secondary
through its published layout, scaled from client to drawn pixels. A
point in a window that has no layout, was cleared or has another
generation is not mapped.
* input: window-aware pointer and touch publication
input_driver_publish_window_pointers() and _touches() take each device's
and each touch's window: 0 for the main window, else a screen's own with
its generation. A device in a screen's window is placed through that
window's layout for the pointer and the lightgun, and has no place on
the main window's screen; one whose window is gone reads off-screen.
Relative motion, buttons and the ports' devices are as they were.
input_driver_publish_pointers() and _touches() publish into the main
window, so the input drivers that call them need no change.
* samples: video_screens harness for the screens' own windows
The shared windows base is tested against the shipping configuration,
video and input objects: per-screen window settings across saves and
overrides, a screen's own layout, the frame snapshot and its copy
under the threaded wrapper, published layouts and point translation,
window-aware pointers and touches, and window generations. build.py
links the test with a configured non-Qt build's objects; the OpenXR
desktop jobs, which make one, run it.
* video: the window plan can keep a screen other than 0 attached
video_windows_plan() takes the screen that stays in the main window
whatever its mode, and screen 0 takes that screen's mode. Callers pass
0, which plans as before. Android's external monitor rule needs it:
screen 0 goes to the monitor and screen 1 stays on the device, where
the touch screen is.
* video: route the separate screens to a platform's displays
video_windows_route() chooses the display a platform's Separate
screens go to, from a list the platform publishes. A screen's monitor
setting N names the display of ordinal N; 0 is Auto, which takes an
on, valid and physical display that is neither private nor the main
window's: an external one (DIRECT or TRANSITIVE) first, then the
lowest ordinal. On an external monitor Auto puts screen 0 there and
keeps screen 1, so the touch screen stays on the device. One display
takes screens at a time; a screen bound for another stays attached.
Each display also carries its size, for the menu's display picker.
* samples: a touch through a second output's layout
A touch on a second display's surface, mapped through the layout drawn
there, lands in the touched screen's part of the packed frame: one
screen on a 1240x1080 panel, two screens sharing it, and screen 0 on a
monitor; the letterbox reads off-screen when asked.
* samples: pin the attached screen, picker and pillar cases
The plan keeps a screen other than 1 attached with screen 0 in its
mode, and falls back to Attached with no settings. The picker refuses a
private display but takes one that is off, and Auto never takes an
entry without an ordinal. A touch in a pillar beside two screens, not
reported off-screen, is held to the nearer one.
* video: route the screens' windows through a platform's display list
A platform publishes its displays from its UI thread, latest wins,
through three slots as the window layouts are handed over. Each frame
takes the newest list, routes the Separate screens with
video_windows_route() and plans with the screen it keeps attached; a
screen with nowhere to go stays in the main window. All screens bound
for one display share one window, led by the lowest one, and the frame
says which screens each window shows. Taking a list restores the screens
a failed window sent back, and video_driver_attach_windows() lets a
renderer send them back from any thread. A request names its display,
and Android gets a native window kind.
A screenshot or GPU recording through the threaded wrapper draws the
cached frame again on the video thread. That redraw takes no list: it
keeps the app thread's last route, as it reads the forced and restore
state, so a renderer keeps the second display's window and the capture
shows the right screens. The route is written only when it changes, so
Win32, which routes nothing and whose modal redraw runs beside the app
thread, never writes it while it is read.
The video_screens harness redraws the cached frame through the real
threaded wrapper and checks that it keeps the frame's route and plan.
* video: let a platform take the secondary windows back
video_driver_windows_retire() has the renderer let go of every
secondary window, through a new optional poke hook. It is for a
platform command such as Android's second surface going away, never a
frame. With the threaded wrapper up it is queued to the video thread
behind the frame being drawn, and nothing waits for it: a hook the
caller passes runs there just before and just after, for the platform
to hold its own requests back and to hear when it is done. Without the
wrapper all of it runs before the call returns. One is queued at a
time; false says the video thread cannot take it yet.
video_screens checks that a retire queued behind a frame being drawn
returns at once, and runs after the frame, between the hook's calls.
* video: one slot hand-over for the window layouts and displays
The window layouts and the display list are handed over the same way,
through three slots. Two small helpers publish and take a slot for both,
with the same memory orders. No behaviour change.
The harness adds two display list checks: a longer list keeps its first
VIDEO_WINDOW_DISPLAYS_MAX, and a get of capacity 1 fills only the first
entry.
* android: native side of the second display
The Java controller hands native code the display list and the second
display's surface through three natives. The list goes to
video_driver_publish_window_displays(). A surface becomes a node holding
one ANativeWindow reference, exchanged in for the video thread to take,
with a generation the touches carry. A size change of the same window
keeps the generation; a different window first gives up the old one.
Giving one up uses the main window's ticket handoff: the UI thread waits
while the app thread drops the node and queues the renderer's letting go
of its windows. The thread that lets go of them acknowledges once it is
done, so the UI thread is not left waiting for the app thread's next
poll; a retire the video thread cannot take yet is tried again from the
input poll. Native code asks Java to show or hide the display through
setSecondDisplay(), which posts and never waits, and asks nothing while
the renderer is letting go of a surface. The app state gets a 64-record
ring for the display's touches.
The natives run on the UI thread and read its own app state,
g_android_early, which android_app_free() clears unless a re-created
activity has already replaced it, so a callback after onDestroy finds
none. A display name GetStringUTFChars cannot read leaves no exception
pending for the next JNI call.
* android: second display windows for the gl and vulkan contexts
Both Android contexts give the renderer the secondary-window table.
Creating a window asks Java to show the display it is routed to and
returns unconfigured. Until Java publishes its first display list a
Separate screen resolves to display 0, which names no display, so its
window is refused and the renderer keeps the screen attached until a
list arrives. An update takes only the request's settings; another
screen or request generation is a new window, the renderer's to make.
Its poll hands it the newest surface native code received, raising
GEOMETRY and publishing which window and surface the input poll maps
touches through. The EGL context makes the window's surface on the main
context the first time it is bound after a surface arrives, at swap
interval 0, with the native visual id queried once at init, since the
query logs on failure and binding sits on the present path; the Vulkan
context gives the renderer the ANativeWindow and leaves the surface to
it.
Each request native code sends Java carries a number, and each surface
comes back with the number of the request it was made for. Destroying
the window drops the surface it held, then asks Java to hide the
display. When it was the last window, that hide gives up every surface
made for an earlier request, including one that reaches native code
after it: no window takes one, and its surfaceDestroyed frees what is
left and returns without the ticket handoff. A hide native code starts,
for closing or switching content or reinitialising the video driver,
never holds the UI thread.
* android: touches on the second display reach the core
Each touch on the second display crosses from the UI thread in the ring
with the generation of the surface it was on. nativeTouch sits with the
other second display natives and reads the UI thread's own app state,
which android_app_free() clears. A down or a move goes in only when it
leaves room for an up of every finger the input driver tracks, and an up
only when its down went in, so a full ring never drops a lift and leaves
a finger pressed for the core. MAX_TOUCH moves to platform_unix.h for
the native and the input driver to share.
The input poll drops the touches of any surface but the one the renderer
shows, maps the rest through that window's published layout into the
core's frame, and keeps the fingers after the main display's in the
core's pointer list. They never move the mouse, count as a quick tap or
reach the frontend's own screen pointer, so the menu and overlay stay on
the main display.
* input: the second display's fingers on a device of their own
With an overlay's pointer on, or one of its buttons held, the frontend
answers RETRO_DEVICE_POINTER from the overlay or not at all, and a
windowed overlay polls that device as its own touches. So the second
display's fingers cannot share it: the Android driver answers them on a
frontend-only RARCH_DEVICE_POINTER_SECOND and keeps RETRO_DEVICE_POINTER
to the main display. The frontend lists them for the core after the main
list's pointers, whoever answers for those: the overlay, none while the
pointer is blocked, or the driver. A driver with no second list answers
with its main list alone.
The pointer_second harness checks those answers against a stand-in
driver with both lists, through input_state_device() and the overlay's
pointer answer extracted from input_driver.c.
* android: a Presentation for the second display
SecondDisplayController lists the displays for native code - whether
each is the Activity's own, valid, on, private, a real panel or monitor
(product info, API 31+), its connection, name and size - and shows a
Presentation with a SurfaceView on the display native code asks for. The
window is not focusable and not touch modal and the view is not
focusable, so touching it neither pauses the core nor takes the gamepad;
it keeps the screen on and, on API 29+, keeps system gestures off it. It
follows the Activity from onStart to onStop, holding a request made
while stopped, and a frame after a display or configuration change
publishes the list again when it changed. A display it cannot show on
stays invalid until the list changes, so the display events a
Presentation coming or going may fire do not retry the failing show in a
loop. Each Presentation carries the number of the show request it was
made for and hands its surfaces to native code with it; touches go with
the surface's generation.
* android: second display failures and Presentations Android dismisses
Every display a show failed on stays invalid until the list changes or
the Activity starts again. A single failed id would not do: of two
displays that both refuse a Presentation, marking one failed makes the
other valid again, native code routes back to it, and the two take turns
failing forever. Starting again retries a one-off failure when the app
returns.
Android cancels a Presentation itself when its display's metrics change
(API 17-29). A dismiss we did not make clears it, so the dead
Presentation does not leave its display counted as shown. While native
code still wants that display, it is shown on again if the dismissed
Presentation's view had a surface. One cancelled before that cancels
itself, for example on stale display metrics, and rebuilding it would
loop at message rate; it counts as a failed show, so its display is
published invalid until the list changes or the Activity starts again.
* video: which screen windows a renderer makes and lets go each frame
video_windows_steps() tells a renderer, from one frame's snapshot,
which of its windows to let go of (no screens now, or another
display) and which to make. A window that closed or failed is not
made again until the restore count moves, so frames already queued
do not bring it straight back. Renderers share the rule instead of
each keeping its own.
* gl2: views draw into a given output; the preset's targets can grow
gl2_views_render() takes the layout, size and canvas it draws with
instead of reading the main window's, and the loop that grows the
preset's targets on a resize becomes a function of its own. Nothing
changes for the main window; a screen's own window will draw through
both.
* gl2: draw the screens' own windows
With a context that can make windows of their own for screens, gl2
reports GFX_CTX_FLAGS_VIDEO_WINDOWS while it may draw views. Each frame
it makes and lets go of the windows the frame's snapshot asks for and
draws each one's screens through the views compositor, with the preset's
passes where one is loaded. A window's pass targets grow only once its
surface is bound, so a failed bind has nothing to undo. A window is
drawn after the main window's frame and swapped at interval 0 before the
main swap, which stays the only one that can wait. The menu, OSD,
widgets and overlay stay in the main window.
A window that cannot be made or drawn hands its screens back to the main
window until the next restore and logs once. A window its context closes
hands them back too, and a restore that lands in the same frame does not
make it again; one closed with no screens left is not marked failed, so
it can be made again when its screens come back before the next restore.
The poke's windows_retire lets go of every window at once, for a
platform that takes a surface back.
The gl2_pbo_readback and gl_last_pass_fbo samples include gl2.c; neither
draws windows, so their shared stubs answer the frontend's window calls
with no-ops.
* samples: views test core logs a second finger, and asks for GLES 3
With a finger on each of two displays the second display's finger is
pointer 1. The core reads, maps and logs pointers 0 and 1 through one
helper, each with its own last state; pointer 0's lines and crosshair
are unchanged. Android's gl driver only gives GLES contexts, so a gles3
value of video_views_test_hw lets the core render through hardware there
too. gles3 with the checker or noise pattern logs an error at load:
those patterns upload a BGRA texture, which GLES 3.0 does not take.
* vulkan: the window-system surface switch as a helper
vulkan_surface_create() made the VkSurfaceKHR for each window system
in line. The switch moves into vulkan_wsi_surface_create(), which
takes the instance and returns the surface, so a second output on the
same device can make its own surface the same way. VULKAN_WSI_DISPLAY
stays where it was, since it needs the context's GPU. No behaviour
change.
* vulkan: a second output on the context's device
A vulkan_output_t is a surface of its own with a swapchain on the
context's device and queue, for a screen shown on another display. It
never waits in a frame. The acquire takes no time and uses a fence,
never a semaphore, so nothing the second display's presentation engine
signals ever enters the queue the main output's frames share. The fence
is polled, and an image not yet free is kept for the next frame. Out of
date remakes the swapchain at once; suboptimal remakes it once and then
keeps it, as the main chain does. On Android the swapchain takes the
size the window reports, since the surface's currentExtent can lag an
in-place resize and Android scales any extent to the window. A lost
surface is dropped. A swapchain let go of is destroyed once a fence
queued behind its last present has signalled. Only teardown waits, on
the output's own fences.
The harness runs the real code against a fake device and checks that no
frame-path call waits, that only completed objects are destroyed, and
that everything made is freed.
* vulkan: draw screens in windows of their own
Where the context has a windows table (Android's second display), a
screen the plan sends to a window of its own is drawn there with its
views' chains, sized for the window, and the frame's own view copies.
The window is drawn in the frame's command buffer, after the main pass
and before the chains end their frame. Its image comes from a fence
already signalled, so the frame's submission waits on nothing new; it
signals the window's semaphore, and the window presents after the
submission and before the main present, which stays the only one that
waits. The menu, OSD, widgets and overlay stay in the main window.
A window that can't be made, drawn or kept puts its screens back in
the main window until the next restore. One whose output is not done
yet is let go of on a later frame; the poke's windows_retire and the
driver's teardown wait for it, on the output's own fences.
* video: separate screen windows on by default on Android
On Android a Separate screen goes to a second display, which is what a
device with two panels is for, so the switch starts on there. Desktop
windows stay opt-in. The settings table records the Android default;
the harness checks that an override carries the switch and a screen's
mode.
* menu: a window mode and a display for each screen from 2 on
Each screen past the first gets two settings rows: Attached, Separate or
Hidden, and the display it goes to when it is Separate. The display
picker offers Auto and the displays the platform has published, shown as
the monitor index is ("2 (Screen-2 1240x1080)"), and keeps a display set
elsewhere until it is changed. It widens only up to the most displays
that can be published, so a hand-edited value in the thousands cannot
build a list that long on the main thread. The row's sublabel says that
the display RetroArch is on keeps the screen attached. Each screen's
rows have their own enum, as the per-port input rows do, so the dropdown
and the sublabel find the right one. A change to any of the rows gives a
screen the renderer sent back to the main window another try.
The settings harness checks the rows, the left key's clamp, and that a
change to any of them restores closed windows.
* menu: show the screens' window rows where the driver has windows
Stereo 3D & Screens shows Separate Screen Windows when the video
driver reports secondary windows. While it is on, it also shows the
mode and display of screen 2 and of each further screen the core has.
On Android the switch reads "Show secondary screens on another
display". A screen row's dropdown takes that row's label as its
title.
* android: show the second display again after its metrics change
On Android 10, a density or size change on the second display left it
empty until the app restarted. Android cancels a Presentation when its
display's metrics change, and the one made to replace it got the
display's resources from a cache keyed by display id, still holding the
old metrics. Presentation.onStart() found them stale and cancelled it
before it drew, so the display was marked failed and both screens stayed
on the main display.
Bring the new Presentation's resources up to the display's current
metrics before showing it. The refresh runs only before Android 12; from
then on a Presentation has a window context of its own.
* android: read input queue keys and sticks through their fields
The key and stick helpers of the input queue take the few fields
they read instead of the event, and the default loop's slot lookup
and key path become functions of their own. Nothing changes for the
queue; the second display's window can then hand its keys and stick
moves to the same code.
* android: a focus rule for the Activity and the second display's window
Once the second display's window can take focus, RetroArch's focus
comes from two windows. Where each display has its own focus, the
second window keeps its display's focus while the keys go elsewhere,
so it counts only while in use: after a key, stick move or touch from
it, a focus it gained while the Activity had none, or a hand-off of
the one focus from the Activity. Any other change of the Activity's
focus ends that, so a notification shade still pauses as before.
The rule is a header without NDK types; a host test replays the
sequences the AYN Thor's focus modes and a one-focus system produce.
* android: keys and sticks from the second display's window
Keys and joystick moves the second display's window receives cross
from the UI thread in a ring of their fields; the input poll handles
them with the input queue's own code, so mapping, device ids, axes,
hats and hotplug behave the same. The window's focus comes in as two
commands, and the focus of both windows is acted on once per poll by
the focus rule, only when it changes.
A paused app thread sleeps in its looper, so writing to either of the
second display's rings wakes it, and the poll reads both rings after
the looper so the woken poll acts on what woke it. The app thread
keeps a reference on its looper for those wakes until the activity is
freed.
* android: the second display's window takes focus and passes keys on
The second display's Presentation can take focus, so a tap on it or a
focus mode that locks the gamepad to its display (the AYN Thor's Bottom)
gives it the pad. Its keys and joystick moves go to native input as the
Activity's do. Each key gets native code's answer, so Android makes no
fallback key (BUTTON_B as BACK, BUTTON_MODE as HOME) of a key RetroArch
uses. It is not cancelable, so BACK stays with native code, and it never
becomes the soft keyboard's target. The IME refuses the Activity's text
field while the second display's window holds the focus, so the Activity
asks for the soft keyboard again when it regains focus.
When RetroArch dismisses the Presentation while it holds the focus, it
first brings its own task to the front, which takes REORDER_TASKS
(granted at install). Android keeps one focus for all displays, so it
would otherwise pass to that display's launcher and leave RetroArch
without focus until the next tap on the main display.
* android: hand the second display's surface back without waiting
surfaceDestroyed and a window change on the second display return at
once. The renderer's own ANativeWindow references keep the window
alive; a frame still drawing into it gets an error from the abandoned
queue, and the next frame's poll finds the surface gone, drops it and
lets the EGL surface or Vulkan output go, the output on later frames
while the presentation engine still holds an image. Nothing waits on
the video thread or the GPU, so the UI thread can't stall into an ANR
behind a slow frame, and the window keeps its display for the next
surface. The going surface also gives the windows another try, so a
failure it caused is not held against the next.
vulkan_output_finish() is the driver's teardown only. An acquire it
gave up on keeps its fence, which is never destroyed while it may still
be signalled.
* video: build the screens' own windows only where a platform has them
HAVE_VIDEO_WINDOWS gates the secondary windows: their state in the
video driver and the threaded wrapper's slots, the drivers' window code
and its per-frame calls, the second output and EGL window surfaces,
the input layer's second pointer list and window places, and the
per-screen settings with their menu rows and config keys. Android
defines it; elsewhere ./configure --enable-video_windows does, and the
CI job that runs video_screens_test builds that way. A build without it
compiles none of this and carries none of its state, which is about
15 KB of the video driver's state alone.
* video: a window failure counts only for the restore it was drawn under
A renderer reports a window it could not make or keep with the restore
count of the frame it was drawing. Failures travel in one word, the
screens beside that count, and the main thread takes them only when
the count is still its own. Under threaded video a frame laid out
before a display or surface change can fail after that change; its
failure no longer keeps the screen on the main display until some
later event.
* android: the jelly-bean package may reorder tasks too
It builds the same second display controller, which brings RetroArch's
task back to the front when it dismisses the second display's window on
a one-focus system; without REORDER_TASKS that call throws and the focus
stays on that display's launcher.
---------
Co-authored-by: libretroadmin <[email protected]>
|
||
|
|
337c3fdfd8 |
CI/webOS: retry and cache the release downloads
The webOS tools and NDKs came from four release-downloader calls to the GitHub releases API, and any one HTTP 500 failed the job. They are now fetched by webos-deps.sh, which retries each call and keeps the assets in actions/cache keyed by the latest release tags: a warm cache needs no download, and an outage that outlasts the retries builds with the cached releases. webos-deps-test.sh checks both paths against a stub gh. |
||
|
|
deebdf6a4c |
libretro-common: stop exporting MD5 and krb5 symbols (#19892)
* libretro-common: stop exporting MD5 and krb5 symbols libretro-common's MD5_Init/Update/Final and krb5_encrypt/decrypt/ string_to_key share their names with OpenSSL's libcrypto and MIT krb5's libk5crypto. When either library is in the link, ld exports the executable's definitions and their callers bind to them instead: libssl's MD5_Init lands in RetroArch's copy, whose MD5_CTX is 152 bytes against OpenSSL's 92, and so do the MD5 calls of a core that bundles LibreSSL (citra). Compile md5.c and net_krb5.c with -fvisibility=hidden so these definitions stay inside the executable. * libretro-common: hide MD5 and krb5 in the sources, check it in CI Hide md5.c and net_krb5.c's definitions with a visibility pragma in the sources instead of a Makefile.common flag, so griffin builds and cores carrying libretro-common get it too. net_krb5.c's includes move above the pragma, which would otherwise hide libc and socket declarations. The pragma is popped at the end of each file, so nothing after them in griffin.c is affected. The Linux CI job checks that neither object exports a function. --------- Co-authored-by: libretroadmin <[email protected]> |
||
|
|
7a3bcbdc28 |
media: route image and movie activation to the internal viewer
Open supported external media in the fullscreen menu viewer and keep image confirmation there across all four menu drivers. Disable the legacy imageviewer core in normal build configurations while preserving its sources and Griffin guard. |
||
|
|
fbb4548c7c |
exynos: read frames from the core's memory, blend the input overlay
Where the G2D sits behind an IOMMU, it reads a core's frame from the core's own memory as userptr, and the frame is not copied. The kernel keeps a mapping per address and size and syncs the caches only when it makes one, reusing it unsynced after that, so each frame gives its address another size and is mapped afresh. Memory the kernel will not map is copied from then on, as is a frame that leaves no room on its last page for a second size. Without an IOMMU frames are copied as before. The input overlay's images each get a GEM buffer, premultiplied, with their alpha applied when it changes, and the G2D scales and blends them over the page, behind the menu or over it. Where an image lies outside the frame, that area is cleared first so it is not blended over what it left there on that page. exynos_g2d_test models the kernel's reused mappings and checks both; the overlay setter check now reads this driver, and the compile lane builds its overlay code. |
||
|
|
2a782ed953 |
ci: every runner job installs its packages through the apt cache
Each job lists its Ubuntu packages in APT_PKGS and installs them once, early, with apt-install.sh: a bounded fetch with the main archive as fallback, and on later runs an install from the actions cache with no network at all. The installs scattered through later steps fold into that list. The cache is keyed by package set and runner image, so jobs asking for the same packages share one entry, and apt-install.sh takes --no-install-recommends for the jobs that relied on it. tools/ci_apt_check.py, run by the CI runner workflow, fails any other apt-get in a runner job; container jobs keep their image's own bounded installs. tools/ci_local.py skips the cache restore and save steps as it does actions/cache, so the converted jobs still run locally. |
||
|
|
e0698da9aa |
ci: samples/gfx in two jobs, its packages from an apt cache
The samples/gfx job ran out of its 30 minutes with gfx_thumbnail_preview (5 to 9 minutes on its own) and a package install that took 7.5 on a slow mirror. gfx_thumbnail_preview becomes a job of its own, running beside it. Both install through apt-install.sh, which keeps the package lists and the .deb files a job fetched in an actions/cache entry keyed on the job, the runner image and the package list: warm, nothing is fetched and only the unpacking is left; cold, or when the cached lists no longer resolve, it refreshes, fetches with the stalled-mirror fallback the job had, and the entry is saved again. A later plain apt-get install in the job resolves from the same lists, and every package samples/gfx installs in its steps is in its list. |
||
|
|
9480e559a6 |
gl2: sample a software core's frame where it was written, on KMS
On KMS the gl driver lends a software core linear GBM buffers, each mapped once and imported as an EGLImage, and the frame texture takes the one the core wrote as its storage: the frame reaches the GPU with no upload. A frame from anywhere else gets the texture's own storage back and goes up as before. A buffer a texture holds, one a draw may still read and the last frame's are never lent, and a smaller frame's buffer is blanked where a larger one wrote. Before a format is first used, two patterns written in turn through the one mapping are sampled and read back; a driver that maps through staging memory, or cannot sample the buffer as written, keeps uploading for the rest of the run. Hardware cores, mipmaps, 10-bit sources and a core that reads its frame back are not lent the buffers. |
||
|
|
4381dc33a6 |
metal: convert HDR movie planes and present linear scRGB
Convert explicit BT.2020 nonconstant-luminance PQ/HLG NV12/P010 into FP16 linear scRGB on the GPU. Use FP16 movie history and a dedicated HDR10/scRGB presentation fragment, preserving absolute luminance and the existing core HDR uniform ABI. The retained backend capability gates HDR activation; unsupported renderer/color combinations retain software fallback. Generic planar texture imports use the same HDR conversion. Restore history, staging texture, dimensions and movie state if destination allocation or encoder setup refuses an import. Persistent history scratch avoids a history-sized stack allocation. CPU/deferred frames clear movie color state and reinitialize history when leaving HDR. Validation: complete GCC/Clang portable Metal jobs, final 128 movie and 96 planar mock cases, Windows C89/GDB, 94 workflow selftests, 44-driver thread-state check, complete compile matrix with ARC/MRC Metal rows, final focused Metal rows and scoped native-presentation Objective-C syntax. Native PQ/HLG conversion/history and stock-MSL presentation pixel fixtures are added; actual Apple GPU and full player acceptance remain pending. |
||
|
|
1e3507cbc9 |
metal: register the device-bound HEVC backend during startup
Publish the retained Metal device only when the SDR conversion pipeline and shared-event OS gate are available. Withdraw by owner at teardown and retire decoder sessions on a process-lifetime serial dispatch queue. Capability queries remain atomic; hardware settings are checked during decoder setup. Link CoreMedia and VideoToolbox in the Metal build routes. Annotate HEVC setup availability so older deployment targets can include the guarded startup path. Exercise the shipping bootstrap in the native registered-stream fixture and add a macOS 10.13 compile probe. Validation: complete GCC/Clang portable Metal jobs, final selected HEVC sanitizer lanes, Windows C89/GDB, 94-workflow selftest, 44-driver thread-state check and complete compile matrix including feature-enabled Metal. Apple SDK/runtime and full player acceptance remain pending. |
||
|
|
c827f9082d |
video: retain HEVC device snapshots across backend replacement
Protect device publication, setup acquisition and withdrawal with a setup-only registry lock. Retain each snapshot while protected; capability ownership queries remain lock-free and decode/output/retirement never acquire this lock. Add compare-and-withdraw for HEVC offers and use it in D3D11/Vulkan teardown so an old driver cannot remove a replacement backend. Exercise stale owners, foreign offers and a held snapshot spanning 1000 replacements with concurrent acquisitions; native registered streams now use the registry too. Fix the Metal compile-matrix regression exposed by broader validation: include the existing dispatch stubs and declare the queue priority and CoreVideo cache factory used by shipping code. Preserve the strict Metal row and native acceptance gates. |
||
|
|
189aad0611 |
ci: account for driver pacing in runloop code budget
The upstream Driver Pacing release and latency-marker dispatch intentionally grows runloop_iterate to 6527 bytes in the menu-harness release build, beyond the old 6255-byte ceiling. Follow the existing budget policy by updating its code-size reference from 5004 to the measured size. Keep the 25 percent margin, stack reference and all other function budgets unchanged. No runloop or pacing behavior changes. |
||
|
|
8e11fa0326 |
Decode AV1 Main 8/10 on Vulkan Video
Register a HAVE_RAV1 backend with capability-based extension and queue selection. Reuse nonblocking decode/transfer timelines and leased NV12/P010 outputs, retaining sequence parameter storage through decoder retirement. Add native raw and RGBA shader oracles covering 16 streams, accepted-input overwrite, replay, backpressure, unsupported opens and output leases after close. Grain, HDR, size changes and builtin container/player routing remain unsupported. |
||
|
|
54dd0d3c02 |
Framebuffer and KMS drivers: views
drm, dispmanx, sunxi, omap, exynos and oga draw a core's views, each laid out on the screen, which every one of them now reports as its output size, and the viewport is the whole screen while they draw. The drivers whose display hardware scales a surface to the screen - drm's plane, dispmanx's element, sunxi's layer and omap's overlay - compose the views on the CPU at the scale that draws no view larger than it is, and let that hardware do the enlarging. The composer they share with xshm is video_views_cpu_compose() in video_views_cpu.h, which xshm now uses too: each placement cut to its own eye's area, anaglyph and interlaced through a canvas of both eyes that is then blended. sunxi and omap at 32 bits compose straight into the page that is scanned out; omap at 16 bits converts as it goes, and lowers the scale as far as its overlay's memory needs. drm and dispmanx compose into a surface of their own, set up beside the frame's and given back to it when the views end. The blitters scale each placement straight from the frame: exynos with the G2D from the GEM buffer the frame is already copied to, oga with the RGA into an upright surface the size of the screen that one more blit turns onto the panel, so a turned panel needs no arithmetic of its own. video_views_cut_source() gives both the part of a view a cut placement shows. Neither blends eyes: anaglyph, interlaced and, on oga, a turned core draw the frame whole. omap's menu buffer now grows with the mode it is scaled to; it stayed 320x240 while a core's larger frame was scaled into it. The compile matrix builds drm, dispmanx, exynos and oga, against stubs of the VideoCore userland, libdrm's exynos module and librga where none of those are installed; libdrm-dev is added to its packages. The unit test covers the composer and the cut, and the drm harness the views surface's lifetime and its pixels. |
||
|
|
cc4f80a2a8 |
tools/platform_stubs: the one tree of compile-only SDK stand-ins
The compile matrix's stubs move into tools/platform_stubs and the matrix takes them from there. Where both trees had a header, the one left declares what both sets of users need: ctr/3ds/os.h the clock and the memory-region queries, ps3/ppu-lv2.h the scalar types and the lv2syscall1 macro. The libnx stub carries the pad, Joy-Con and rumble surface switch_joypad.c uses, and samples/input/switch_joypad builds against it instead of a copy of its own. Every compile-matrix lane gives the verdict it gave before. |
||
|
|
d67324c157 |
CI: faster slow steps, and ccache that hits (#19819)
* CI: run the qemu sinc kernel tests side by side
The four NEON sinc tests ran one after another under qemu-user on the
aarch64, aarch64+crc and armv7 legs, five to six minutes a leg, with
the runner's other CPUs idle. Each is one single-threaded qemu
process, so they now run at once, and each one's output is printed
when it is done. A failing test still fails the step.
On CI the step went from 300s to 102s on aarch64, 329s to 169s on
aarch64+crc and 318s to 249s on armv7, where one test alone sets most
of its length.
* tools/tsan-samples.sh: build each suite with every CPU
The suites were built one compile at a time. Built with -j on four
CPUs, the 68 directories in the list took 29s instead of 77s, and none
that builds without -j failed with it. The suites themselves still run
one at a time, so on CI the whole step went from 737s to 622s.
* views e2e: under Wine, each worker gets a prefix of its own
Cases run side by side in one prefix share its wineserver and moved
each other's pointer, so the Wine cases ran one at a time. Each worker
now takes a copy of the prepared prefix, and Wine runs four cases at
once like Xvfb.
On CI the D3D11 and D3D12 cases went from 1457s to 479s, all 120
passing; the pointer cases passed in three more runs on four CPUs.
* CI: one gl harness job per build, and one job for the wait checkers
The gl harness ran as 13 jobs, one per driver, API and sanitizer, but
the build depends only on the API and the sanitizer: each job set up a
runner, installed the same packages and built the same tree as two
others before its one or two minutes of harness. It now runs as 6
jobs, one per build, each running the harness on every driver that
build serves. Every driver runs even when one before it fails.
The three wait and teardown checkers, each under a minute of work,
ran as three jobs; they now share one, every checker running even
when one before it fails.
On CI these 16 jobs became 7, and 27.1 runner-minutes became 24.5.
* CI: MSYS2 installs Qt's base package only
The MSYS2 lanes installed about 40 Qt 6 modules, though configure
reports Qt support disabled on all four of them, so none of it is
built.
qt6-base still brings in the libraries configure does find (FFmpeg,
SDL2, FreeType, fontconfig, libass, glslang, SPIRV-Tools, OpenSSL).
The MinGW packages fetched drop from 198 (597MiB) to 152 (319MiB). On
CI the install steps of the four lanes went from 772s to 523s, and
configure found the same libraries on each.
* CI: sanitizer and debug builds of the tree use -g1
The samples moved to -g1 in
|
||
|
|
ceedc745a4 |
CI: link with lld on the ubuntu runners
lld ships with the runner image under a versioned name. A step after checkout in each ubuntu job (83 jobs; container jobs are left alone) runs .github/workflows/scripts/use-lld.sh, which finds it and puts a small "ld" first on PATH that the host gcc then links with. Cross compilers keep their own prefixed linkers and clang its own. GNU ld still does the links lld cannot stand in for: any link with --wrap (lld also wraps calls inside the defining object, which the wrapping samples do not expect), and gcc -flto objects, which lld cannot read - those fail under lld and are run again with GNU ld. No lld on the runner leaves the job on GNU ld. RetroArch's link here: 1.6s with GNU ld, 0.9-1.2s with lld. The samples that wrap, use -flto, --gc-sections or -Map build and pass their checks through it. |
||
|
|
421a4279ac |
compile-matrix: a failing tree check is reported, not a silent exit
The platform makefile and console object checks captured their status after a plain command substitution, which under set -e ends the script on the first failure before the status is read: no FAIL line, exit 1, and every lane after it - the video drivers, the gates, the unity build - never run. A host missing one package the checks compile against made the whole matrix look run when two thirds of it had not. The status is now taken in the same list as the substitution, so the check prints its FAIL and the lanes after it run. |
||
|
|
838e23591c |
CI: reject a directive inside a macro's arguments
MSVC's preprocessor takes it as tokens; GCC accepts it. The clang lanes that compile every driver now make -Wembedded-directive an error. |
||
|
|
5103a232df |
OpenXR: one core for the desktop and Quest headsets, with head tracking, controllers, settings and desktop OpenGL (#19811)
* menu: the cursor stays on Headset Output when Stereo Mode comes and goes Stereo 3D & Screens lists Stereo Mode above Headset Output only while the headset is off. Turning it on moved Headset Output up a row and left the cursor on the row below it, Headset Refresh Rate, so a second OK meant to turn the headset off opened the rate list instead. The cursor follows the row, as it does for Mapped Port when Device Type comes and goes. samples/menu/stereo_headset checks it for OK, right and Start. Co-authored-by: Craig <[email protected]> * openxr: a session without focus is not logged as controllers not read xrSyncActions answers XR_SESSION_NOT_FOCUSED, a success code, while the runtime's dashboard or another application has focus. It was logged as a warning each time focus went; only a failure is now. The test layer answers a sync with a scripted result (sync <n>), and the headset suite gains input-sync-unfocused. Co-authored-by: Craig <[email protected]> * libretro: a TRACKED view map, and HMD is how a core finds a headset A map's shape could not tell a head-tracked eye pair from a stereoscopic screen sent alone. The new flag says which. HMD now means tracking works, and a core learns of a headset from it only. REQUEST_FLAT is a map without the flag, and OpenXR always gives real eye poses, so the flag and the IPD hint go; nothing read either. Co-authored-by: Craig <[email protected]> * openxr: the runtime, session, swapchains and frame loop are shared units The desktop Vulkan host's instance and headset, its session state machine, its swapchain slots and its frame loop with pacing move into gfx/common/openxr_*, which name no graphics API, so every headset host can use them. vulkan_openxr keeps only what is Vulkan's. Co-authored-by: Craig <[email protected]> * video: the headset's host says how it is, and answers the pose calls One host interface reports the headset's state on the desktop and the Quest alike. HMD comes with PRESENTS and STEREO, and only while the session runs. The pose calls go to the host, and a view map sent again unchanged is not applied again. Co-authored-by: Craig <[email protected]> * openxr: a TRACKED map's eyes are the desktop headset's projection Tracked content gets a space of its own, LOCAL or STAGE as the core asks, and the poses sampled in it. The eyes the core draws are submitted as a projection layer with the poses it was given, and the screens a headset leaves to that projection are hidden. A recenter moves a seated world with the screens; a standing one stays where the room puts it, and the core is told RECENTERED. A paused core's tracked world comes back after a driver reinit. The views test core can draw a world-locked grid, for checks made in a headset. Co-authored-by: Craig <[email protected]> * vulkan: the Quest's headset runs on the shared OpenXR core The runtime starts Android's loader and tells the instance of it. A headset frame can be begun and ended inside the video frame, so vulkan_openxr runs in-line for a headset's own context, which says so in its flags. The units that name no graphics API build without Vulkan, and a GLES binding is ready for the GL host. A space a core asks for again is kept, so a cached context keeps its paused world. Co-authored-by: Craig <[email protected]> * gl: the Quest's headset runs on the shared OpenXR core The Quest's ES3 context is its own in-line host: gl2 draws into a window the context owns, shown as a screen in the room, and copies a tracked map's eyes into the headset's projection. The window shows until the first projection. The kept view pair lives in openxr_host, so the GL host keeps a paused world across a reinit as Vulkan does. The quest flavour builds with GLES=3. A stand-in runtime test runs the in-line host. Co-authored-by: Craig <[email protected]> * input: one headset controller module for the desktop and the Quest The headset input's hooks belong to the frame, so any host attaches the module, and the Quest's own controller module goes. Touch's menu button is Start from its press, and opens the RetroArch menu when let go after a second. The menu's laser can point at a window shown whole, mapped through the area the core is drawn in. The stand-in test runs the shared module. Co-authored-by: Craig <[email protected]> * video: headset settings for every headset driver, and Screen Placement The headset's rows show for every driver with a headset path. Recenter works in the menu and reaches the Quest's GL host, and a seated recenter moves a paused world with the screens in the same headset frame. Screens are placed from an anchor of their own: Fixed in Room, Follow Head or Lazy Follow. The Quest asks for a refresh rate that fits the content and repeats each core frame for whole headset frames. Co-authored-by: Craig <[email protected]> * input: the headset's controllers are a controller They take joypad slots with built-in profiles, so hotkeys, port binds, remaps and rumble use the normal input path on the desktop and the Quest. They take the next free slot like any pad, and keep their port when a gamepad is plugged in, without saving that exchange. A saved "Meta Quest Touch Plus Controller" profile and its remaps no longer apply. Co-authored-by: Craig <[email protected]> * gl: headset output for the desktop OpenGL drivers glcore and gl show a headset on Linux. The XR thread holds a context in the window's share group, made by the X11, X11 EGL and Wayland context drivers, and the session binds it through XR_KHR_opengl_enable or XR_MNDX_egl_enable. The video thread draws each image into shared textures and hands it over with a fence through a triple buffer; the XR thread copies the newest into the swapchain and shows it with the quads or the eye poses it was drawn with. glcore draws the screens and the menu through chains of its own and a tracked map's eyes as the projection, as Vulkan does. gl shows its window, whole or cut into an untracked map's screens, as the Quest does, and tracked eyes as the projection. Both follow the headset's pacing: the XR thread wakes the core for its next frame after taking the last, so none is shown a headset frame early. OpenXR configures with OpenGL alone, without Vulkan. The test layer captures OpenGL swapchain images, and the headset end-to-end runner has lanes for both drivers on GLX and EGL. Co-authored-by: Craig <[email protected]> * docs: OpenXR headset output, and how a headset or graphics API is added What the headset path does and how to build and turn it on, what a core sees, which units are shared and what each of the three hosts adds, and the steps for another headset, graphics API or platform. Co-authored-by: Craig <[email protected]> * audio: pass the reinit flag to MMDevice watchers XAudio2 and DirectSound must give mmdevice_thread the frontend atomic flag. Passing the driver object overwrites its watcher handle when an endpoint changes. Exercise both thread backends against the extracted production spawn functions. * test: reject video backend fallback in the threaded harness Fail early when HARNESS_VIDEO_DRIVER differs from the initialized backend so a missing driver cannot qualify another backend's lanes. * Animated previews: keep high-bitrate audio fed across loops Size the audio lookahead from the preview bitrate, prime it before playback, and refill the full window on rewind. The audio demuxer walks interleaved video packets too; a fixed 2 MiB window stalled on large H.264 packets and left high-bitrate previews silent or delayed after looping. Add a real feeder/mixer regression using generated oversized video packets. Verify that audio continues through three complete loops; the previous feeder fails this test. Validate both reported 4K clips locally on Windows and Linux. * wdmks: bound threaded writes by the device fragment A small write can exhaust its request-sized wait budget before a healthy WaveRT pin's next notification. Size the threaded ring waits from rt_ahead instead, and cover writable waits and blocking writes against a 64 ms fragment. * CI: views end to end on glcore and Vulkan under Xvfb run.py gains RA_E2E_XVFB (Xvfb in place of gamescope, llvmpipe and lavapipe) and RA_E2E_ONLY (a case filter). The validation job runs a subset of the cases. * Views: one compositor for gl3 and Vulkan gfx/video_views_draw.h holds the chain pick, the placement loop with the interlaced row shift, and the canvas and UI target lifetime. Each driver includes it with its own calls bound in by macros, so nothing goes through a function pointer. The UI layer's predicate, per-eye test and dims swap move to video_views.h. Output is unchanged. * Threaded video harness: the frame on screen is the core's newest A frame lag lane checks, end to end, that what the driver draws is the frame the core pushed last: the harness core stamps each frame with its number in eight full-height bands that survive scaling and filtering, and the lane reads back the driver's own upload (the cached frame dropped first) and decodes it. Copied, lent and lent as a cropped window, with threaded video off and on: with nothing in flight it must be the newest pushed frame, and with frames still in the wrapper's ring at most one behind. A zero-copy path that draws a buffer the core has since rewritten, or skips an upload, or a wrapper that holds frames back, fails it. It runs on vulkan, gl and glcore, desktop and GLES 3, in the existing harness jobs (release, ASan+UBSan, TSan, the validation layer). * Fix MSVC preprocessing of video views UI checks Move widget conditionals outside VIDEO_VIEWS_UI_WANTED calls in the GL3 and Vulkan drivers. The traditional MSVC preprocessor treats directives inside macro arguments as tokens, breaking the Windows build. * Provide audio state in the DirectSound pump harness The device notification thread now uses the audio state reinit request. Supply a persistent harness-owned state through audio_state_get_ptr so the standalone MinGW test links. * Preserve RetroArch when building the threaded video harness Request the link command with make -W instead of deleting the frontend executables. The later video views end-to-end tests need the existing RetroArch binary to launch. * ATRAC3plus: accept implicit master code-table indices Master channel code-table mode 3 has no payload and uses zero indices. Return before consuming the optional value count bit, rather than rejecting valid frames and losing bit alignment. Add a synthetic regression covering float, s16 and reset decoding. * Expose hardware H.264 decoding with CPU planes to cores Provide an experimental versioned frontend decoder interface with Vulkan and D3D11 I420 readback. Reserve private video queues through Vulkan device negotiation v2, and retain the decoder backend with cached devices across video driver reinitialization. Keep software fallback for unavailable or disabled hardware decoding and cover readback in decoder and GPU tests. * ATRAC3plus: distinguish coded and declared subband flags Use coded subbands for stereo swap and negation flags and declared subbands for window shapes. Add a synthetic audible stereo regression to detect parser misalignment when fewer subbands carry spectra. * D3D11: views The driver draws a core's views through video_views_draw.h, straight from the frame as the stock chain draws it: placed in each eye's area, blended through a canvas for anaglyph and interlaced, with the UI drawn once into a layer composited into each eye. With a preset or HDR output the frame is drawn whole. Windows-wine-views.yml runs the views end to end on it: run.py gains RA_E2E_WINE, for retroarch.exe under Wine with vkd3d's shader compiler, and the test core builds as a DLL. * D3D12: stock pipes made for the swap chain's format The pipes were made before the swap chain, whose formats were still unset, so every stock draw had an UNKNOWN target format: Windows drivers draw it anyway, vkd3d (Wine) draws nothing. They are made after it now. * D3D12: views The driver draws a core's views through video_views_draw.h as the D3D11 driver does: straight from the frame, through a canvas for anaglyph and interlaced, with the UI drawn once into a layer composited into each eye. Its SDR pipes keep coverage in alpha, which the layer is composited by. With a preset or HDR output the frame is drawn whole. Windows-wine-views.yml runs the views end to end on it as well, on Wine's vkd3d over lavapipe. * openxr: apply unified headset support to current master Apply PR #19811 at |
||
|
|
920eaf90b4 |
D3D12: H.264 previews decoded on the GPU
The D3D11 video backend's frames, opened on the D3D12 device through the same NT handles: the shared NV12 texture as two plane views, the fences as ID3D12Fences. Each frame converts in a command list of its own, executed at once on the driver's queue behind the decoder's fence and signalling the reader's, so nothing waits on the CPU; with all four lists still in flight the frame is dropped. They signal a fence of their own, as a signal on the queue fence between a frame's recording and its execution would take the value that frame's resources wait for. The backend starts on the D3D12 driver's adapter and loads d3d11.dll itself. The GPU oracle in samples/gfx/d3d11_video_decode now reads every stream through D3D12 as well, where there is a device. |
||
|
|
2db49be6b4 |
D3D11: H.264 previews decoded on the GPU
rh264's hardware backend on D3D11 video (DXVA), as the Vulkan one is on Vulkan Video. Each decoder has a device of its own on the driver's adapter, so the driver's device stays on its own thread. A picture to be shown is copied into a shared NV12 texture behind a shared fence; the driver opens both by their NT handles, waits on the GPU, converts with the planar compute shader and raises the texture's own fence. Needs Windows 10 1703 and NV12 sharing; anything less, or a stream the GPU will not take, decodes on the CPU as before. The DXVA buffers are written byte by byte (gfx/common/dxva_h264.h), so no dxva.h is needed. samples/gfx/d3d11_video_decode checks them against one, runs the backend on a D3D11 that records what it is told, and has an oracle that compares a GPU's frames with software's. |