mirror of
https://github.com/libretro/RetroArch.git
synced 2026-11-22 10:50:15 -10:00
codex/android-native-streaming
267
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
0108ade537 |
input: a pointer read walks a port's users only while the laser points
With OpenXR built, every RETRO_DEVICE_POINTER and LIGHTGUN read walked the core port's users to gather their slots before asking the headset, which answers false at once whenever its laser does not drive a core's pointer - nearly always without a headset. The headset is now asked first whether it does, and the walk is skipped when not. openxr_input_test checks the answer with the laser off and on. |
||
|
|
5756db8659 |
Input: Plays As, several controllers on one player, with hotkeys of their own (#19916)
* OpenXR: the controllers' slots are not read from the driver's view
A joypad driver that keeps its pads' state lends it to the snapshot
bridge through view(), and the bridge reads that in place of a copy
(
|
||
|
|
6ebf66b643 |
OpenXR: per-screen placement for headset screens, and Edit Screens to arrange them by hand (#19945)
* video: per-screen geometry for the headset's floating screens Each floating screen, by the core's logical screen id, gets its own offsets, yaw, pitch, roll, scale and visibility (video_screen_xr_t), applied on top of where the layout puts it. video_views_xr_reset gives the defaults and video_views_xr_normalize clamps each value to its range: offsets to 10 m either way, angles to 180 degrees, scale from 0.1 to 10. A planner given no screens uses the defaults, so nothing moves until a setting does. * configuration: save per-screen headset geometry video_screen<N>_xr_x, _y, _z, _yaw, _pitch, _roll, _scale and _visible keep each floating screen's adjustments for screen ids 1 to 8, and survive configuration overrides like the other video settings. A minimal save writes only the values that differ from the defaults. The video_screens settings sample checks the round trip and the override cases, and runs in the OpenXR input and Wine views jobs. The defaults fixture now links video_views.c, which the reset uses. * menu: per-screen controls for the headset's floating screens Stereo 3D & Screens gains Screen, which picks a floating screen by its logical id among those in the current frame's map, and for it Horizontal, Vertical and Depth Offset, Yaw, Pitch, Roll, Scale and Visible, with Reset Screen and Reset All Screens. The rows apply live and are hidden where they cannot apply, such as a tracked projection's eyes. Stepping between screens reads one snapshot of the map and is bounded, so a tracking change mid-step cannot leave it walking an empty map. docs/openxr.md describes the controls; the video_screens sample drives them through the shipping menu actions. * video: apply per-screen headset geometry to the frame snapshots Each XR planner, Vulkan's and GL's, takes the normalized screen settings with the frame snapshot, so a screen moves, turns, scales or hides as its rows change, while paused too; recentering and tracked projections are unaffected. Screen images are kept between frames, so shader feedback survives a placement change. A retained XR target that cannot be allocated is skipped quietly, remembered by its size so it is not retried every frame; only the desktop UI and canvas targets log the failure. Covered by openxr_core_test, the video_screens sample, the e2e runner's feedback shader case and the new vulkan_views_target sample. * android: keep the OpenXR EGL context C89 gl_xr_egl_init declared its extension string after statements. * video: pose inverse, layout spots and grab maths for headset edit mode Each item's layout spot comes from one helper that placement uses and the quad set records per slot, so a shown pose turns back into the settings that placed it. Grab maths: the item follows the aim, level unless tilting, offsets clamped to the settings' range; the stick pushes along the ray and resizes. Edit picking sees every item and takes the menu by a handle bar under it. * video: a frame without a view map is screen 1 in the headset A core without a views map (SNES, say) had no screen to select, so its frame could not be moved. Its whole frame now takes screen 1's offsets, turn, scale and visibility, and the selector lists Screen 1. gl's window stays as laid out while the menu is open over it. * video: the headset's menu in front of screen 1, or where it was put The menu sat at a fixed spot, so moving screen 1 closer left the menu behind it. It now floats 10 cm in front of screen 1, facing as it does, at its default angular size and never nearer than 0.4 m, while screen 1 floats and shows, and is still submitted after the screens. A menu place (video_openxr_menu_xr_* with video_openxr_menu_placed) overrides that; it is saved like the per-screen keys, and Reset All Screens clears it. * input: Edit Headset Screens mode for the OpenXR controllers Edit Screens starts from a hotkey, a headset action, the HEADSET_EDIT_SCREENS command or a Stereo 3D & Screens row, and stops on the same, on opening the menu, on a video reinit or when the session ends. It syncs its own action set in place of the game's, points the lasers at every item whatever the Laser Pointer setting, keeps the menu's quad up while editing, and with While Editing Screens set to Pause pauses only content that was running. A runtime that refuses its bindings keeps the game's and leaves edit mode unavailable. The setting reaches the headset's poll with the others, and the pause and resume are asked of the frontend as platform requests, so the input driver issues no command and takes no settings itself. A Laser Pointer value past its choices, which a hand-edited config can hold, reads as Auto rather than as edit mode's. * input: grab, tilt, push and resize headset screens in edit mode A grip on an item takes it in the screens' frame: it keeps its pose relative to the hand, stays level unless the trigger is held, and the stick pushes it along the laser and resizes it, past a deadzone. Each poll writes the item's offsets, turn and scale where the menu's rows write them, through named frontend calls, clamped so it waits at a limit and resumes from there. The menu is taken by its handle; a menu that follows screen 1 is placed as large as it shows. The main button resets a free item as Reset Screen does, or puts the menu back in front of screen 1. A recenter, a screen leaving the map and leaving edit mode let go, counted for the frame snapshot; an untracked hand holds its item still. * openxr: held screens follow the hand at the headset's rate The main thread publishes what each hand holds through a seqlock; each headset frame re-places a held item, both eyes of a stereo screen, from that frame's own aim, so it no longer waits for the next video frame. An item let go stays where the hand left it until a quad set planned at or after its release (an edit count carried in the frame snapshot) shows it, even once the hand holds another item, so nothing steps back. Lazy Follow holds its glide while anything is held. Edit mode outlines every item, brightly the one under a laser, and draws the menu's handle bar under it, from the laser's image, now an atlas of the dot, two outlines and two handle bars. They take only the layers the screens leave after the dots. * openxr: edit mode end-to-end cases and documentation The test layer's aim can roll, and the e2e runner drives edit mode against Monado: grabs that follow the hand on every headset frame and stay where they are let go, level and tilt, the stick, resets of a screen and of the menu, the menu taken by its handle and following Screen 1 at its size, outlines and the handle, a no-map core, a views core's fallback frame, Follow Head, Lazy Follow, recentering, two hands, pausing, and what starts and ends edit mode, including the headset's hotkey bits with no command interface. The cases whose work is a host's or driver's own run on glcore and gl too. docs/openxr.md explains editing screens in the headset and where the menu goes. * openxr: a laser beam from each controller to its dot A thin strip runs from each hand's aim to its dot, or 1.5 m into nothing, turned about its own axis each headset frame to face the head so it never shows edge on. It comes from the laser's image, so it needs no new swapchain, and uses layers left after the dots and edit mode's outlines, so it is the first to go when the runtime has few. The new Laser Beam setting shows it in edit mode only (the default), always, or never; outside edit mode, Laser Pointer and its hotkey hide it with the dot. * openxr: edit mode outlines in three bands, outside the item A light band between two dark ones shows on white, black and busy borders alike. The rim now sits wholly outside its item, 5 mm clear of it even after filtering, so it never covers the picture; its region grows to keep two texels a band at about the old thickness. Screens' outlines are submitted before the screens, so a neighbour placed flush covers the part of a rim over its picture, while the menu's outline and handle bar stay on top. The handle bar moves 5 mm below the menu's outline, which it would otherwise cover, and gets the same bands, faint and bright. * input: choose a headset edit item with Select Next and Previous Edit mode steps from the laser through the screens it can move and the menu. A chosen item is the one lit, either hand's grip takes it from wherever the hand is, and Reset resets it, so a screen hidden behind another can be moved. Whatever a hand holds stays lit. A ray on the menu's handle bar takes the menu before any screen in front of it. Within 3 cm of the bar, a ray that came from the bar keeps the menu even over a screen, and one that came from elsewhere takes it only where no screen is hit. * openxr: snap a held headset screen to the screens near it Snap to Screens, on by default, turns a held screen parallel or square to a nearby screen and lines up its plane, edges or centre. Each pull is exact within 3 cm or 5 degrees and fades out over as far again, so the screen catches up with the hand rather than jumping, and snapping fades in over the first 5 cm or 10 degrees after a grab, so taking a screen never moves it. With several screens near, the snap that leaves the least error wins, so a near screen's exact pull beats a far one's fading pull whatever their order. One stateless function inside the grab serves the main thread and the headset's thread, so a screen is saved where it was shown. The holding hand buzzes as a snap takes hold, once, and not again until the screen has left that pull. * input: turn a held headset item with the free hand's stick A quarter turn of a held screen needed the controller turned a quarter turn, which swung the screen round the hand on its long reach, so a square snap could not be reached. Now the stick of the hand holding nothing turns what the other hand holds about the vertical through its middle, faster the further it is pushed, and snapping still catches it parallel or square. A carried item keeps its pitch and roll and its angle to the way the hand points across the floor, so raising, lowering or twisting the hand no longer tips or swivels it; the trigger lets it ride the hand rigidly. * openxr: smooth the controller aim in edit mode A screen held about 2 m out on the laser magnified every tremor of the hand. In edit mode each hand's aim now goes through a One Euro filter, which smooths a slow hand hard and a fast one little, with its rate taken from the headset frame's own time step. The headset's thread filters once a frame and hands the result to the main thread, which grabs, moves and lets go from it, so a screen is saved where it was shown. The new Edit Smoothing setting picks Off, Low, Medium (the default) or High; outside edit mode the lasers are never smoothed. * openxr: name the chosen edit item beside the controller Edit mode now shows a faint tag just above the hand that last pressed Select Next or Previous, reading Laser, Screen N or Menu, so what the grip will take is plain without a notice. The words are drawn once into the laser's image in the default font and the interface language, light over a dark halo like the outlines so they read on any background, and the tag is one more headset layer; when the runtime is short of layers the beams are dropped before it. On a runtime whose swapchains are too narrow for the words, the laser's image keeps its old width and there is no tag. * input: tilt a held headset item with the free hand's stick In edit mode the free hand's stick already turns the item the other hand holds. Its up and down now tilt that item too, about the item's own left-right line through its middle, at the turn's rate and with no limit: up tips the top back, as when pushing a monitor's top back. It works whether the item is carried or rides the hand with the trigger held, and snaps as the turn does. Within about 25 degrees of left or right the stick only turns, and within about 25 degrees of up or down it only tilts, so a push meant for one does not drift into the other. Edit mode's starting notice lists the turn and tilt and stays about 8 seconds. * input: snap a turned or tilted headset item to angle steps While the free hand's stick turns or tilts a held item in edit mode, the item clicks into steps of the new Snap to Angles setting (15 degrees by default; 30, 45, 90 or Off), so it is easy to set straight. The turn counts from facing the user's head across the floor, the tilt from upright. Within about 2 degrees of a step the item holds there and the holding hand buzzes once; the stick's own angle keeps adding up, so pushing on leaves the step. Only the stick steps: carrying an item or tilting it with the trigger never clicks, and a snap to another screen that would engage wins over a step. * openxr: show the back of a headset screen turned away Runtimes draw only the front of a quad layer, so a screen or the menu turned away from the head vanished. When the head is behind a quad's plane, the frame now submits a plain dark panel in that quad's place: a solid grey cell of the laser's image, at the quad's size, turned to face the head. It takes the quad's own layer, so the layer count and cap are unchanged. Edit mode picks either face, so an item turned away stays grabbable, and its outline, handle and dot turn with its back. * input: keep a screen snap's angle once the free stick lets go A snap to another screen shows a held screen square or parallel to it, but the item's own angle stays where the stick or the hand took it, up to several degrees off. The next turn with the free hand's stick started from that hidden angle, so the screen left the snap early on one side, late on the other, and caught up with a lurch. Now, as the free stick returns to its deadzone and as a push starts, a snap engaged on the turn becomes the item's own angle: the carried turn, or the orientation the trigger tilts. A snap still fading in never does, since that would hop the screen into it. The place is left to the hand, and carrying alone never keeps the angle, so pointing still pulls a screen out of a snap. Letting go of the grip leaves the item where it shows, as before. * openxr: hinge a held headset screen to a neighbour's edge Snap to Screens now also hinges a held screen to another along a shared edge at any angle between them, so a DS or 3DS pair can be opened at a slant: an edge within 5 degrees of parallel to one of the other's, within 3 cm of its line and sharing some length with it, turns exactly parallel and moves onto it, centres or ends level, its angle left free. The pull fades in over the first 3 cm of shared length, so a screen slides off the end of the other's edge without a jump, and a diagonal neighbour never hinges. Screens that would overlap do not hinge; the pull is whole from flat to square and fades out folded shut. Flat and square snap as before and report a hinge at 0 and 90. A turn to the same screen pivots on the shared edge, so the edge stays on the line as the screen leaves flat or square. The snap still keeps nothing between calls; its result carries a hinge bit, and video_xr_snap_hinge also says which edge and line, for the stick to swing about. * input: swing a hinged headset screen about the shared edge While a held screen is hinged to another, the free hand's stick axis that turns nearest the shared edge, the tilt for a top or bottom edge and the turn for a side one, now swings it about that edge, so it stays attached; the other axis still turns or tilts it and can pull it off. Where the swing leaves it, angle and place, it stays as the stick lets go. Snap to Angles counts a hinged screen's steps from flat with the other screen. A hinge counts only while the screen's own edge is within its range, not when other snaps alone hold it on the line, so a swing never carries a screen round a line it is far from. A square corner is a side hinge at 90 degrees, so the turn stick there now swings the screen about the corner's edge. Main thread only; nothing new reaches the frame loop, which still shows the grab through video_xr_grab_pose. * openxr: leave a gap between hinged headset screens Edges that meet in edit mode, side by side, at a corner or hinged at any angle, now click to a set gap from within 1 cm and otherwise keep the gap the hand gives them, still hinged, up to 10 cm (letting go by 13). Screens no longer have to touch, which made them overlap. Each grab carries the gap, so the edit poll and the frame loop snap alike; until a setting sets it, it is 0. Pushed past touching, a hinged edge stops there for the first centimetre of the push, the stop fading out by 3 cm, and ticks once per push. A swing pivots on the held screen's own edge, so the gap keeps through it, and a commit keeps the hand's gap unless the click holds it. After a swing lets go past square, that stick axis and its steps keep pivoting on the same edge until the edge leaves the hinge's reach, so a flick past square and back does not creep. Of two neighbours within the 5 degree turn snap, the nearer edge wins the turn and the hinge, by one measure for every screen, so a screen stacked behind, one off the ends of the edge or a side wall at a corner never outranks a hinge the turn holds. * menu: add Hinge Gap for headset screens Hinge Gap (0, 1, 2, 3, 5 or 10 cm, default 2) sets the gap edit mode's Snap to Screens leaves between screens that meet edge to edge, side by side, at a corner or hinged. Edit mode takes it as it starts and gives it to each grab; the click to it buzzes like the other snaps. * menu: put Edit Screens under Headset Output Stereo 3D & Screens now lists Edit Screens and its snaps right under the switch that reveals them, then the headset's own setup, then where the screens go, with the per-screen rows last and Visible first among them. * openxr: track each held screen's hinge on the frame loop The frame loop already re-snaps each held screen every frame. It now also keeps, per hand, the hinge that snap holds whole, until the edge leaves the hinge's 4.5 cm reach, where the frame draws it, so edit mode can mark it. A kept hinge whose target no longer matches is dropped. video_xr gains the hinge line's ends, along the overlap of the two real edges and midway across the gap, an outline cut that drops one edge's rim, and a green strip in the laser's image, before the tags. * openxr: mark a hinged headset screen with a green line While a held screen's hinge holds, the two edges that meet drop their outline rim and a 6 mm green line runs along the hinge where they overlap, midway across the gap, so it is clear when the hinge has taken hold. The line is drawn as the beam is, a centimetre nearer the eye than the edges, since SteamVR does not keep the order of overlapping quad layers, and comes after the outlines in the layer budget; hidden rims cost no layer. * input: buzz longer as a headset screen hinges A hinge taking hold now gets one 150 ms buzz at 0.8 on the hand carrying the screen, against the 20 ms snap tick, so the attach can be felt. It fires again only after the edge leaves the hinge's reach, hinges elsewhere, or the other hand takes the screen it hinges on, so a swing past square and back does not repeat it. Ticks due while it plays are skipped rather than cutting it short. * openxr: find headset screens resting in a hinge Two screens no hand holds rest in a hinge when their poses pass the test that engages a carried screen's hinge, with either one carried, and the hinge, held whole with nothing else pulling, leaves the carried one where it is. So a hinge found at rest stays hinged when its screen is taken. The engaged test moves into its own function so both use the same one, and one target can pull whole whatever the grab's fade. * openxr: keep a headset screen's hinge shown at rest In Edit Screens, two screens no hand holds that rest in a hinge keep the green line and their hidden rims, whether let go hinged or loaded that way. The main thread counts them only when a resting screen changes and sends them with the hands' record, so a release and its resting pair arrive together; the frame loop places each line from the screens it shows. A screen hinged at rest on two adjacent edges still keeps one of those rims. The hands' record now outgrows the quads, so the seqlock's copy is sized to the larger of the two. * openxr: pick up a hinged headset screen still hinged Taking up a screen that rests in a hinge starts the carry on that hinge, whole from the first poll, with no buzz and no jump, until it leaves the hinge's reach, another hinge takes hold, or the other hand takes the screen it hinges on. Until the grab's own snapping has faded in, the kept hinge's target still pulls whole, so a straight pull out does not hop. The grab carries the hinge so both threads hold it the same; of several, the one the snap ranks best carries over, and only where holding it moves nothing. While the other screens fade in, the hinge's screen also leads the turn, so a nearer one still fading does not take it. * openxr: end a headset screen's hinge where a push passes the stop Pushing a hinged screen into its neighbour holds the edge at touching for 3 cm of push, fading out by 5.5 cm. Where it stops holding, the hinge ends: the line goes, the rims come back, and the lid and buzz are cleared, so screens pushed into each other show no hinge that a let-go there would not rest in. Pulled back, the hinge takes hold again 5 mm short of where it ended, with the long buzz, so a tremor there does not flicker it. The grab carries that through flag, and the frame loop keeps its line until the main thread sets it, so the two threads never disagree for more than a poll. At Hinge Gap 1 a pair let go touching rests hinged and is taken up hinged, as at every other gap. A screen swung into a square corner gets the long buzz on arrival, and the other hand taking the target does not hop the carried screen by the push's depth. * input: let go of a headset screen where it was before the grip opened Opening the grip twitches the hand, and the poll that sees the grip open would move the screen by that twitched aim. Half a degree of pitch moves a screen 1.8 m out by 1.6 cm, enough to knock it off its hinge's gap or out of level, so it would not rest hinged. Each hand keeps a short trail of where, turned and as large as its screen showed, entries at least 10 ms apart, and a grip let go puts the screen as it showed 80 ms before (INPUT_OPENXR_EDIT_REWIND_US), or as it was taken if held for less. Edit mode's end and a recenter let go where the screen shows. * openxr: find where a let-go headset screen settles in its hinge A screen let go while its hinge shows should land exactly in that hinge, so the hinge still shows at rest and a pick-up is hinged. video_xr_hinge_settle holds the hinge whole from the hand's pose, then moves the edge to the set gap from within 3 cm of it (touching stays where the stop holds it) and levels it along the edge within the level pull's reach. Its result must pass the rest test, and it turns no further than a grab's hinge engages, which shares that test. A pair resting inside a settle band but off its point is no longer listed at rest, since a pick-up and let-go would move it. A touching rest is taken 5 mm deeper into the push stop, at every Hinge Gap, so a hand that drifts less than that apart before letting go settles touching rather than at the gap. * openxr: settle a let-go headset screen into its hinge A screen let go while its hinge shows now goes exactly into that hinge: to the set gap from within 3 cm of it, touching from the stop's hold, and level along the edge from within the level pull's reach. It then rests there, listed and green, in the same publish, and is saved there. Elsewhere it stays where it shows, as before. Each trail entry also records where the hand put the screen with no snap and whether a let-go there settles. At the let-go the rewound entry is settled again against the screens as they are now, at that entry's size, and put in one go. * openxr: let a hinged headset screen rest at any fold Snap to Screens' turn to flat, and its turn to square at a corner, is whole within 5 degrees and fades out by 10, so a hinged screen held there shows at twice its angle off less 10. No fold shown in that fade read as a rest: the pair was not listed, a let-go there did not settle into its hinge, and taking it up would have moved it. Where a hand takes a rest, it now holds the screen at the angle the turn's fade shows it from, the inverse of the turn's pull, so every fold rests, is listed and is taken up unmoved. Held snapping is unchanged. * input: keep a headset screen's hinge through a shaking hand Edit Screens' hinge buzz, lid and push stop followed the snap's own engage and reach on every poll. A hand shaking half a degree (1.6 cm at the screen) about a hinge's edge flipped them many times a second, each flip a long buzz. Each hold now keeps one mark: the hinge a let-go would settle into. It takes hold at once, with the long buzz, and lets go only once polls have seen the hand out of where a let-go would settle for 150 ms, each poll counting at most 50 ms, so a stalled main thread or a spell untracked never lets it go alone. The other hand taking its target, hinged elsewhere or not, the target leaving and the let-go end it at once. The lid waits for the mark to go, the push stop follows it, and a let-go while it shows settles into it from where the hand last would have, edit mode's end and a recenter included. * openxr: draw a held screen's hinge as the main thread marks it The grab carries the main thread's hinge mark, and the frame loop draws a held screen's green line and cuts its rims from that mark alone, through video_xr_grab_marked, while it snaps the screen every frame. A frame loop taking the hinge by itself between polls would flicker the line for a hand shaking at the edge of the hinge's range while the mark held. A mark whose target the frame does not show cuts no rim. The other hand taking the mark's target ends it, and the lid, on any poll, tracked or not, so a lost hand's line does not come back when that hand lets go. video_xr_grab_near_hinge loses its past argument, which only the frame loop's keep used. * openxr: keep edit mode's hinge layers in place SteamVR does not keep submission order for overlapping quad layers, so a layer added, dropped or moved to another index can pop the edit outlines in front of the screens, as a wobble at a hinge would do to its line's layer. The hinge lines are fixed slots: one for each hand holding a screen, hand 0 first, then one for each pair at rest. A slot with no line to show is drawn in place from its screen's middle, at rows of the laser image that are empty either way up. The layer count and every index change only at a grab, a let-go or a re-count of the pairs at rest; a mark only changes crops and which rows a slot shows. * input: date a let-go's trail by frame and stop it at a stall Each trail entry is dated by the frame its aims are from, one a frame and per hand, and the release poll records a new frame's aims first. The rewind stops at a stall, entries more than 2.5 frames apart, a frame counted as at least 20 ms so a fast headset's close entries never read as one. Under load a stall of 0.1 to 0.3 s can come just before the release; the entry from 80 ms back would then hold the pose from before it and step the let-go back across all the stall's motion. With Edit Smoothing on, which damps the twitch, a let-go that does not settle into a hinge stays where and as large as it shows: a rewind there would step back by what the smoothed aim still lags. The hinge decision and the settle use the trail either way. * openxr: cut edit outlines from cells instead of turning them Cutting a top or bottom rim from the one outline image turns both outline quads a quarter turn and swaps their width and height, and on SteamVR that can blink every edit outline as the hinge takes hold or lets go; side cuts, which never turn, do not. The laser's image carries twelve pre-cut outline cells after the tags, faint and bright, for a cut top, bottom, left, right, top and bottom, or left and right, so a cut only picks a cell and the quads keep their pose and size. The image is then 5582 texels wide. A runtime whose swapchains are narrower, or that does not say how wide they can be, keeps the turned and cropped outline at 2498 or 1208 wide. One log line at the laser's creation gives the width chosen and the runtime's limit. GL writes the top and bottom cells swapped for its bottom-up rows, and Android's copy of the image is allocated rather than static. The edit-hinge-3ds-narrow e2e case runs the turned cut at RA_XR_LAYER_MAX_WIDTH=4096, on Vulkan and the GL EGL lanes. * video: draw headset screens straight into the runtime's images Each headset screen was drawn into an image of the driver's own and copied from it into the runtime's on every new frame, Vulkan with a render pass and GL3 with a blit. Screens are now drawn into the runtime's image itself, as before per-screen placement, with no image of the driver's and no copy. A screen drawn again with no new frame - resized, made again or moved while paused - replays the last frame's final pass from the chain: build_viewport_pass_replay draws it at the new size from what it read then, the passes' outputs, their feedback and the history that frame saw, with that frame's count. Nothing else runs, feedback does not swap and history stays, so a feedback or history preset holds still while paused. A chain made to replay keeps one more history image, so the frame's end writes where the last frame did not read; the window's chains keep what they did. This also has movie frames reach the headset, which the copy held at the first one, and draws a screen resized while paused at its new size rather than stretching the old image. * openxr: leave what users who never edit see as it was Screens seen from behind turn to their grey backs only while Edit Screens is on, where screens are turned around; outside it nothing changes and no head is located for them. The grabs carry whether editing is on. The menu opens at its own spot, straight ahead of the anchor, as it did. Menu in Front of Screen 1, off by default, keeps it just in front of screen 1 and moving with it. The frame loop copies the main thread's grabs only once their stamp moves, so outside edit mode no frame copies them. A new session clears the frame loop's own copy and passes over what was published before it, rather than publishing itself: the main thread stays the grabs' one writer. On Touch, the left menu button that opens the menu from edit mode is spent until let go: held on as edit mode ends, it is no Start and does not toggle the menu again after a second. --------- Co-authored-by: libretroadmin <[email protected]> |
||
|
|
45dc0a99c3 |
input: Dingux rumble through evdev and the output writer; drop libShake
libShake was used by one driver, sdl_dingux, for its vibration motor, and linked on webOS for nothing. What it did there is a few evdev calls: find the node that plays a periodic sine, upload a sine per motor, play and stop it, set the gain. input/common/linux_ff.h does those with no allocation (libShake scanned /dev/input with scandir and malloc'd a node per entry) and none of its bugs (an open that failed was taken as success). The uploads and plays now go out from the shared output writer, as udev's and XInput's rumble do, so a motor's driver never holds the frame; the frontend's thread notes the strengths, both in one word, and returns. A core asking the same strength each frame costs no call at all. On MIPS (-O2, mips32) that path is 15 to 19 instructions with no stack frame, where it was about 32 with a frame and four spills. Every SDL Dingux target gets the motor now, not only the three that built libShake; one without a motor finds none and has no rumble, as before. The output writer makes no syscall for a wake while one is still on its way, which every driver on it gains from. xinput_rumble_test says a call did not wait by the write not being done yet, not by a time a loaded runner can overrun. samples/input/dingux_rumble runs the real driver against a stand-in /dev/input and SDL, with threads and without. |
||
|
|
5c82bce0ed |
overlay: D-pad and face buttons read a finger's contact area (Android)
A touchscreen reports each finger as an ellipse, not a point; Android gives its axes and orientation (AMotionEvent_getTouchMajor/Minor and getOrientation). A thumb laid across up and right, or resting between two face buttons, covers both - and read by its centre alone presses one. After RetroArch-Lite's contact-area input. "D-Pad Input Method" and "ABXY Input Method" choose how each reads a touch: "Direction" - the way the centre lies, as always, and the default - "Contact Area", every way the contact covers, or "Both". Each tip of the ellipse's two axes presses the way it lies from the area's middle, past a small dead zone there. "Contact Area Size" scales how large a contact counts. Measured in pixels per axis against the pointer's own space; RetroArch-Lite measured both against the screen's height, which skews a contact on a wide screen. Android's reader keeps each pointer's contact beside its position, and the driver hands them to the frontend each poll (input_driver_publish_touch_contacts). A finger with no contact size, and every other driver, read by the centre's way. The rows show on Android, where an overlay has the area they apply to. overlay_contact_test holds the geometry: fingertips, thumbs across two ways, upright and level contacts, magnification, wide screens. |
||
|
|
a21637debe |
input: ignore a controller from Input Information
Some duplicates nothing can tell apart: a remapper (DS4Windows, reWASD, x360ce) reads a controller and shows a virtual one of it, and nothing in the virtual pad's identity says so. Only the user knows, so the user chooses. Information > Input Information has a row under each controller, "Ignore This Controller": that model is left out by every joypad driver that knows a controller's ids - raw input, DirectInput, the hybrid driver, udev and the HID drivers - the way the controllers Steam Input stands in for already are. The controller driver restarts so it goes at once. Each model left out is listed after the controllers, a row to read it again. The list is the input_ignore_devices setting, written as SDL's SDL_GAMECONTROLLER_IGNORE_DEVICES is, and read beside that variable. input_device_ignored() moves into input_driver.c, as it now reads the settings; the check itself stays in input_ignore_devices.h with the list's helpers, which ignore_devices_test covers. The driver tests that link a driver are given the frontend's function. |
||
|
|
40583200c8 |
dinput: one port for a pad on cable and Bluetooth at once
A DualShock 4 or DualSense on Bluetooth and plugged in to charge is two devices to DirectInput, and both the DirectInput driver and the hybrid driver's DirectInput pads gave it two ports. Raw input already told the links apart by the pad's Bluetooth address; DirectInput gives the device's HID path too (DIPROP_GUIDANDPATH), so the enumeration reads the address the same way and leaves a pad's second link out. The address read moves to win_pad_ident.h, shared by raw input and DirectInput. It finds HID's two calls in hid.dll, so a build that links no HID library has it, and it runs where a pad connects - on the enumeration's task for DirectInput - never on a frame. win_pad_ident_test now holds a pad on both links to one port under every Windows joypad driver. The raw input rumble test counted every library load as XInput's; it counts XInput's. |
||
|
|
9696bef97a |
udev: player lights through the pad's LED devices
The udev joypad driver lit nothing: it had no set_player, unlike the other desktop drivers. It now finds the LED class devices under each pad (its HID device, or an Xbox 360 pad's USB device) and lights them as each console does: a DualSense's five player lights, a DualShock 4's light bar in the player's colour, a DualShock 3's four, a Switch pad's four and an Xbox 360 pad's ring. A DualSense's light bar is left alone, as are lights it never lit; ones it lit go out when no port reads the pad. Four rings under one wireless receiver are not told apart, and are left. Writing a light can wait on the pad (a Switch pad answers a request), so the rumble writer's thread writes them: the lights are opened where a pad arrives and handed over through atomic slots, with the player wanted an atomic of its own. Without threads the caller writes them, as with rumble. A driver that adds a pad's lights just after its input nodes is looked at again a few times. The kernel makes these files root's. pkg/linux/70-retroarch-player-lights.rules makes them writable by the user; without it the pad is left as it is, and the log says so. samples/input/udev_player_lights runs the real driver against a directory laid out as /sys is, under ASan and TSan. |
||
|
|
17d8ad9f86 |
input: one port for a pad Windows shows more than once
Which of Windows' views reads a controller is now decided in one place
(input/common/win_pad_ident.h) instead of four copies that disagreed.
The XInput-hybrid driver matched "IG_" in capitals only, so an Xbox pad
whose raw input path came lower case ("ig_") was read through XInput
and DirectInput both: two ports. The check is now case-insensitive
everywhere, and Bluetooth paths are told the same way, classic and LE.
A DualShock 4 or DualSense on Bluetooth and plugged in to charge is two
devices to Windows. Raw input now reads the pad's Bluetooth address
from each link at connect (the serial string over Bluetooth, a feature
report over USB, on a handle opened with no access): the second link of
a pad already there is kept aside and not read; when the first goes,
it carries on in the same port with no disconnect. DirectInput gives
no path to tell them by, and is left as it was.
samples/input/win_pad_ident holds a table of real controllers - Xbox
pads on USB, Bluetooth and Bluetooth LE with paths in either case,
8BitDo X and D modes, Sony pads on one or both links, Switch Pro,
WinUSB pads, Steam Input's - to one port each under every Windows
joypad driver.
|
||
|
|
fac37bac1e |
input: leave the controllers Steam Input stands in for
Steam Input, starting a game with a controller it translates, makes a
virtual pad of it and puts the real one's USB ids in
SDL_GAMECONTROLLER_IGNORE_DEVICES ("0x054c/0x09cc,..."), so that the
game reads only the virtual pad. SDL's games honour it; RetroArch's own
drivers did not, and read the controller twice: once as itself, once
through Steam.
The drivers that know a controller's ids at connect now pass over one
that is listed: winraw, DirectInput, the XInput and DirectInput driver,
udev, and the hid layer under every HID backend. A user can set the
variable too, for a controller another program mirrors. It is read
when a controller connects, never on a frame. ignore_devices_test holds
the list to how Steam writes it and SDL reads it.
|
||
|
|
e160e2ab67 |
udev joypad: a pad's other nodes, listed once under its HID device
A DualShock 4, a DualSense or a Wii Remote comes out of the kernel as several nodes beside the pad's: motion sensors, a touchpad, raw reports. At each connect the driver searched every input or hidraw device on the system for each of them in turn - up to four scans - and kept those whose HID parent was the pad's. It now lists the pad's HID device's own nodes once, and a table (linux_pad_members.h) gives each its role: the node tagged as an accelerometer for the sensors, else the untagged ones in order, as for a Wii Remote; the one tagged as a touchpad for the touchpad, never tried as the sensors; the hidraw node for a DualShock 3's pressures. The pad's own node takes none. linux_pad_members_test holds the choice to that. |
||
|
|
707a29fb6e |
hid: read the DualShock 4's and DualSense's touchpad fingers
Only the DualSense's touchpad click was read, as a button. Both pads send two fingers in every full report: each one's place, and whether it is down. The handlers now keep them in the pad's view, where the pointer device puts a place, with the pad's press beside them, so the frontend reads them with the buttons at the poll, through the view the joypad driver already lends, with nothing copied. A finger's x and y are packed into one word. The two pads share the layout, read by sony_pad_touch.h, with the reach SDL gives each. Other makes' pads are not known to lay theirs out the same and are taken to have none. |
||
|
|
fa433ba816 |
Input: motion from the hid DualShock 4, DualSense and DualShock 3
The PlayStation pads' hid handlers now give a core their motion sensors while it asks for them, through the same handler ops as the Switch Pro Controller. - DualShock 4: the gyroscope and accelerometer after the triggers, in USB's report 0x01 and Bluetooth's full report 0x11. - DualSense: from byte 16 of USB's report and Bluetooth's 0x31. - Both use the nominal scale and libretro's axes, through sony_pad_motion.h, as winraw reads the same pads. - DualShock 3: the accelerometer, as SDL reads it: big-endian from byte 41, 113 counts per g around 511. Its one-axis gyroscope is not given, as in SDL. input/common/pad_motion.h holds what the handlers share: a core's ask as a mask, and SDL's axes turned into libretro's as the sdl3 joypad driver turns them. The Switch Pro handler now uses it too. |
||
|
|
01f1aa65d5 |
Input: rumble pads on WiseGroup's PlayStation adapters on Windows
The MP-8866 Dual USB Joypad, SmartJoy PLUS and Super Joy Box 3 rumble the pads in them through an output report Windows' own HID driver never sends. As Linux's hid-sjoy has it, its first three values are on, the small motor on or off and the large motor's force; Windows' parser places them from the device's own descriptor, so no driver and no byte layout is needed. winraw writes it from its rumble thread, and winusb's generic pads at the poll, through the shared input/common/hid_sjoy_output.h. The log says whether the adapter's report was found. |
||
|
|
547fa2369c |
Input: winraw reads a DualShock 3 on Sony's sixaxis.sys
A DualShock 3 on Sony's own driver, sixaxis.sys, or on DsHidMini in the mode that stands in for it, sends no input reports: its state is feature report 0, asked for. Under the raw input joypad driver such a pad showed up and did nothing. The driver's own thread now asks a DualShock 3 for that report every 4 ms and hands the newest to the poll through three buffers swapped with an atomic exchange; the poll lays it out as the pad's own HID description does - buttons 1 to 19, the sticks X, Y, Z and Rz - so a profile for the pad binds it. Its motors and player light go as that driver's commands. A DualShock 3 on Windows' own HID driver, which has not started it, has no report 0: it is asked once and left alone, and one whose input reports come after all is no longer asked. With no such pad nothing changes: the thread waits on wakes alone, and the poll looks at one counter. The writer thread's timed wait now goes through a high resolution waitable timer on Windows, where a short wait was otherwise a whole timer tick. winraw_joypad_sixaxis_test runs the driver under Wine with the pad's driver faked. |
||
|
|
e1dfae341a |
Linux: the hid driver reads pads with no handler from their descriptor
On Linux the hid joypad driver took only pads with a handler in input/connect; Linux gives a pad's report descriptor but, unlike Windows and the Mac, does not parse it. input/common/hid_report_desc.h does: it reads the gamepad, joystick and multi-axis collections of a descriptor into a layout of fields, made once when the pad arrives, and decodes each report into buttons, axes and a hat at the poll with nothing allocated. Report IDs, signed fields, push and pop, usage ranges and four-byte usages are read; output and feature reports, arrays and constant fields are passed over. hidraw now opens a node with no handler when its descriptor, read from sysfs (which any user may read), holds such a pad, and reads it through that layout, the pad known by the name it gives. It is numbered as the Mac numbers such a pad, so its profiles bind on all three: buttons in usage order, axes X, Y, Rx, Ry, Z, Rz then rudder, throttle, steering, accelerator and brake, the first hat as the D-pad. An axis named twice is given the first free axis once every other has its own, as the Mac does; the Windows path gave it one at once, and now does the same. hid_report_desc_test reads a common USB pad's descriptor, which names X four times, a pad split across two reports with a signed axis and a hat counted from 1, and a keyboard's, which is no pad; every cut of a descriptor and a short report are read without going past them. It runs in CI under ASan and UBSan. hidraw_hid_test reads a pad with no handler, and winusb_hid_test an axis named twice. |
||
|
|
d0a696916e |
OpenXR: no new pull across a session restart; rumble kept together
A trigger held while the session restarted counted as a new pull: a session's start cleared every trigger as let go. It now starts as after a loss of focus, with no pull until the trigger is let go. A pad's strong and weak rumble were two atomics, so the haptics read could pair one call's strong with another's weak. They are now one word, strong in the high half and weak in the low, each set by a compare-and-swap that keeps the other. Rumble may be asked for from any thread, but it found the pad by the main thread's slot array. The slots are now also published as one word whenever the main thread changes them, and rumble and input_openxr_has_slot() read that. openxr_input_test holds a trigger across a session restart and checks it presses nothing until let go and pulled again; openxr_haptics_test checks both motors are kept in the one word. |
||
|
|
2c961c0ef6 |
openxr: add v hotkey to toggle flat, stereoscopic or immersive (#19840)
* openxr: add v hotkey to toggle flat, stereoscopic or immersive * openxr: Headset View only narrows a presenting headset The Headset View hotkey and its status filter apply only while a headset presents, so a desktop Stereo Mode keeps its STEREO bit and the hotkey stays silent without a headset. The bind follows the other headset hotkeys: always in the bind list, hidden from the menu without OpenXR, reachable from a headset controller action, and defaulted to V for player 1 only. --------- Co-authored-by: LibretroAdmin <[email protected]> |
||
|
|
0501d0a8d2 |
openxr: locate the hands only for a core that asks
A sample no longer locates the hands. The first RETRO_ENVIRONMENT_GET_VR_CONTROLLER_POSES locates them at the head's sample on the drawing thread, and every sample after it does too until the core's content goes. The interaction profile's string is looked up when its path changes, the joint order is checked against OpenXR's at compile time, and an optional instance extension is only enabled while the list has room, the platform's kept last. |
||
|
|
e4f550ae44 |
openxr: explicit initialization of the hand tracking structs
The hand tracker, joint, pose and interaction profile structs are written field by field, as the rest of the OpenXR code is; the input harness's xrLocateSpace fills a chained XrSpaceVelocity as a runtime does. |
||
|
|
f8899526b3 |
openxr: add hand tracking API and implementation
Closes #19831 |
||
|
|
1412b3d8ac |
input: explicit initialization of fixed-ABI structs in place of memset
The OpenXR action, space, state, haptics and layer structs, winmm's JOYINFOEX, the raw-input message window class, the udev sensor absinfo fallback, SDL2's left/right haptic effect, the synthesized X button event and the XInput state resets are set member by member. OVERLAPPED, struct input_event and struct sigaction keep their memset, their member names differing between SDKs and C libraries. |
||
|
|
5103a232df |
OpenXR: one core for the desktop and Quest headsets, with head tracking, controllers, settings and desktop OpenGL (#19811)
* menu: the cursor stays on Headset Output when Stereo Mode comes and goes Stereo 3D & Screens lists Stereo Mode above Headset Output only while the headset is off. Turning it on moved Headset Output up a row and left the cursor on the row below it, Headset Refresh Rate, so a second OK meant to turn the headset off opened the rate list instead. The cursor follows the row, as it does for Mapped Port when Device Type comes and goes. samples/menu/stereo_headset checks it for OK, right and Start. Co-authored-by: Craig <[email protected]> * openxr: a session without focus is not logged as controllers not read xrSyncActions answers XR_SESSION_NOT_FOCUSED, a success code, while the runtime's dashboard or another application has focus. It was logged as a warning each time focus went; only a failure is now. The test layer answers a sync with a scripted result (sync <n>), and the headset suite gains input-sync-unfocused. Co-authored-by: Craig <[email protected]> * libretro: a TRACKED view map, and HMD is how a core finds a headset A map's shape could not tell a head-tracked eye pair from a stereoscopic screen sent alone. The new flag says which. HMD now means tracking works, and a core learns of a headset from it only. REQUEST_FLAT is a map without the flag, and OpenXR always gives real eye poses, so the flag and the IPD hint go; nothing read either. Co-authored-by: Craig <[email protected]> * openxr: the runtime, session, swapchains and frame loop are shared units The desktop Vulkan host's instance and headset, its session state machine, its swapchain slots and its frame loop with pacing move into gfx/common/openxr_*, which name no graphics API, so every headset host can use them. vulkan_openxr keeps only what is Vulkan's. Co-authored-by: Craig <[email protected]> * video: the headset's host says how it is, and answers the pose calls One host interface reports the headset's state on the desktop and the Quest alike. HMD comes with PRESENTS and STEREO, and only while the session runs. The pose calls go to the host, and a view map sent again unchanged is not applied again. Co-authored-by: Craig <[email protected]> * openxr: a TRACKED map's eyes are the desktop headset's projection Tracked content gets a space of its own, LOCAL or STAGE as the core asks, and the poses sampled in it. The eyes the core draws are submitted as a projection layer with the poses it was given, and the screens a headset leaves to that projection are hidden. A recenter moves a seated world with the screens; a standing one stays where the room puts it, and the core is told RECENTERED. A paused core's tracked world comes back after a driver reinit. The views test core can draw a world-locked grid, for checks made in a headset. Co-authored-by: Craig <[email protected]> * vulkan: the Quest's headset runs on the shared OpenXR core The runtime starts Android's loader and tells the instance of it. A headset frame can be begun and ended inside the video frame, so vulkan_openxr runs in-line for a headset's own context, which says so in its flags. The units that name no graphics API build without Vulkan, and a GLES binding is ready for the GL host. A space a core asks for again is kept, so a cached context keeps its paused world. Co-authored-by: Craig <[email protected]> * gl: the Quest's headset runs on the shared OpenXR core The Quest's ES3 context is its own in-line host: gl2 draws into a window the context owns, shown as a screen in the room, and copies a tracked map's eyes into the headset's projection. The window shows until the first projection. The kept view pair lives in openxr_host, so the GL host keeps a paused world across a reinit as Vulkan does. The quest flavour builds with GLES=3. A stand-in runtime test runs the in-line host. Co-authored-by: Craig <[email protected]> * input: one headset controller module for the desktop and the Quest The headset input's hooks belong to the frame, so any host attaches the module, and the Quest's own controller module goes. Touch's menu button is Start from its press, and opens the RetroArch menu when let go after a second. The menu's laser can point at a window shown whole, mapped through the area the core is drawn in. The stand-in test runs the shared module. Co-authored-by: Craig <[email protected]> * video: headset settings for every headset driver, and Screen Placement The headset's rows show for every driver with a headset path. Recenter works in the menu and reaches the Quest's GL host, and a seated recenter moves a paused world with the screens in the same headset frame. Screens are placed from an anchor of their own: Fixed in Room, Follow Head or Lazy Follow. The Quest asks for a refresh rate that fits the content and repeats each core frame for whole headset frames. Co-authored-by: Craig <[email protected]> * input: the headset's controllers are a controller They take joypad slots with built-in profiles, so hotkeys, port binds, remaps and rumble use the normal input path on the desktop and the Quest. They take the next free slot like any pad, and keep their port when a gamepad is plugged in, without saving that exchange. A saved "Meta Quest Touch Plus Controller" profile and its remaps no longer apply. Co-authored-by: Craig <[email protected]> * gl: headset output for the desktop OpenGL drivers glcore and gl show a headset on Linux. The XR thread holds a context in the window's share group, made by the X11, X11 EGL and Wayland context drivers, and the session binds it through XR_KHR_opengl_enable or XR_MNDX_egl_enable. The video thread draws each image into shared textures and hands it over with a fence through a triple buffer; the XR thread copies the newest into the swapchain and shows it with the quads or the eye poses it was drawn with. glcore draws the screens and the menu through chains of its own and a tracked map's eyes as the projection, as Vulkan does. gl shows its window, whole or cut into an untracked map's screens, as the Quest does, and tracked eyes as the projection. Both follow the headset's pacing: the XR thread wakes the core for its next frame after taking the last, so none is shown a headset frame early. OpenXR configures with OpenGL alone, without Vulkan. The test layer captures OpenGL swapchain images, and the headset end-to-end runner has lanes for both drivers on GLX and EGL. Co-authored-by: Craig <[email protected]> * docs: OpenXR headset output, and how a headset or graphics API is added What the headset path does and how to build and turn it on, what a core sees, which units are shared and what each of the three hosts adds, and the steps for another headset, graphics API or platform. Co-authored-by: Craig <[email protected]> * audio: pass the reinit flag to MMDevice watchers XAudio2 and DirectSound must give mmdevice_thread the frontend atomic flag. Passing the driver object overwrites its watcher handle when an endpoint changes. Exercise both thread backends against the extracted production spawn functions. * test: reject video backend fallback in the threaded harness Fail early when HARNESS_VIDEO_DRIVER differs from the initialized backend so a missing driver cannot qualify another backend's lanes. * Animated previews: keep high-bitrate audio fed across loops Size the audio lookahead from the preview bitrate, prime it before playback, and refill the full window on rewind. The audio demuxer walks interleaved video packets too; a fixed 2 MiB window stalled on large H.264 packets and left high-bitrate previews silent or delayed after looping. Add a real feeder/mixer regression using generated oversized video packets. Verify that audio continues through three complete loops; the previous feeder fails this test. Validate both reported 4K clips locally on Windows and Linux. * wdmks: bound threaded writes by the device fragment A small write can exhaust its request-sized wait budget before a healthy WaveRT pin's next notification. Size the threaded ring waits from rt_ahead instead, and cover writable waits and blocking writes against a 64 ms fragment. * CI: views end to end on glcore and Vulkan under Xvfb run.py gains RA_E2E_XVFB (Xvfb in place of gamescope, llvmpipe and lavapipe) and RA_E2E_ONLY (a case filter). The validation job runs a subset of the cases. * Views: one compositor for gl3 and Vulkan gfx/video_views_draw.h holds the chain pick, the placement loop with the interlaced row shift, and the canvas and UI target lifetime. Each driver includes it with its own calls bound in by macros, so nothing goes through a function pointer. The UI layer's predicate, per-eye test and dims swap move to video_views.h. Output is unchanged. * Threaded video harness: the frame on screen is the core's newest A frame lag lane checks, end to end, that what the driver draws is the frame the core pushed last: the harness core stamps each frame with its number in eight full-height bands that survive scaling and filtering, and the lane reads back the driver's own upload (the cached frame dropped first) and decodes it. Copied, lent and lent as a cropped window, with threaded video off and on: with nothing in flight it must be the newest pushed frame, and with frames still in the wrapper's ring at most one behind. A zero-copy path that draws a buffer the core has since rewritten, or skips an upload, or a wrapper that holds frames back, fails it. It runs on vulkan, gl and glcore, desktop and GLES 3, in the existing harness jobs (release, ASan+UBSan, TSan, the validation layer). * Fix MSVC preprocessing of video views UI checks Move widget conditionals outside VIDEO_VIEWS_UI_WANTED calls in the GL3 and Vulkan drivers. The traditional MSVC preprocessor treats directives inside macro arguments as tokens, breaking the Windows build. * Provide audio state in the DirectSound pump harness The device notification thread now uses the audio state reinit request. Supply a persistent harness-owned state through audio_state_get_ptr so the standalone MinGW test links. * Preserve RetroArch when building the threaded video harness Request the link command with make -W instead of deleting the frontend executables. The later video views end-to-end tests need the existing RetroArch binary to launch. * ATRAC3plus: accept implicit master code-table indices Master channel code-table mode 3 has no payload and uses zero indices. Return before consuming the optional value count bit, rather than rejecting valid frames and losing bit alignment. Add a synthetic regression covering float, s16 and reset decoding. * Expose hardware H.264 decoding with CPU planes to cores Provide an experimental versioned frontend decoder interface with Vulkan and D3D11 I420 readback. Reserve private video queues through Vulkan device negotiation v2, and retain the decoder backend with cached devices across video driver reinitialization. Keep software fallback for unavailable or disabled hardware decoding and cover readback in decoder and GPU tests. * ATRAC3plus: distinguish coded and declared subband flags Use coded subbands for stereo swap and negation flags and declared subbands for window shapes. Add a synthetic audible stereo regression to detect parser misalignment when fewer subbands carry spectra. * D3D11: views The driver draws a core's views through video_views_draw.h, straight from the frame as the stock chain draws it: placed in each eye's area, blended through a canvas for anaglyph and interlaced, with the UI drawn once into a layer composited into each eye. With a preset or HDR output the frame is drawn whole. Windows-wine-views.yml runs the views end to end on it: run.py gains RA_E2E_WINE, for retroarch.exe under Wine with vkd3d's shader compiler, and the test core builds as a DLL. * D3D12: stock pipes made for the swap chain's format The pipes were made before the swap chain, whose formats were still unset, so every stock draw had an UNKNOWN target format: Windows drivers draw it anyway, vkd3d (Wine) draws nothing. They are made after it now. * D3D12: views The driver draws a core's views through video_views_draw.h as the D3D11 driver does: straight from the frame, through a canvas for anaglyph and interlaced, with the UI drawn once into a layer composited into each eye. Its SDR pipes keep coverage in alpha, which the layer is composited by. With a preset or HDR output the frame is drawn whole. Windows-wine-views.yml runs the views end to end on it as well, on Wine's vkd3d over lavapipe. * openxr: apply unified headset support to current master Apply PR #19811 at |
||
|
|
1c54ecd3e1 |
Wayland Vulkan: negotiate live fullscreen changes asynchronously
Keep mapped Vulkan windows rendering while the compositor configures fullscreen changes. Apply geometry only after configuration, acknowledge before surface commits, and retain blocking negotiation for initial setup and reinitialization. |
||
|
|
26d96469d3 | input: relax independent illuminance value publication | ||
|
|
24b39c4640 |
input: publish OpenXR pointer settings as one word
Pack frontend-owned laser mode and menu-open state into one atomic configuration. Headset frames now read a coherent pair with one acquire load; both poll publication sites use one release store. Any-thread motor publication remains unchanged. Extend the portable shipping-source fixture to force a publication between consumer reads and cover supported mode/menu pairs, yield and completed navigation polls. |
||
|
|
765479b0ea |
input: reject invalid OpenXR rumble effects
Validate the effect before writing desired strength, so an unsupported effect cannot overwrite the weak motor. Cover invalid positive and negative effects and invalid ports in the desktop haptic fixture. |
||
|
|
efc2131d39 |
input: retry unaccepted OpenXR haptic requests
Keep the last accepted amplitude when apply or stop fails, including the positive XR_SESSION_NOT_FOCUSED result. Retry unchanged requests at the existing refresh interval; changed amplitudes and observed focus return proceed immediately. Retry state remains frontend-owned. Add a portable fixture using the shipping desktop implementation and scripted runtime results, with sanitizer and MinGW CI coverage. |
||
|
|
2167e58d4d |
input: retry interrupted output writer wake writes
A pipe write interrupted before sending its byte can otherwise leave pending output asleep indefinitely. Retry EINTR, while retaining the nonblocking full-pipe coalescing behavior. Inject an interrupted first wake into the real writer regression. |
||
|
|
9546695660 |
input: allow output writers to service driver-owned deadlines
Add an optional writer-thread timeout callback without adding shared timer state. Existing untimed POSIX writers retain their blocking read path. Cover timed service, idle waits, wake interruption, shutdown and no-thread fallback with a portable regression. |
||
|
|
2c20e986d6 |
webos: the on-screen keyboard is up while a line is typed, not whenever keys are kept from the binds
The webOS code in the SDL2 and SDL3 input drivers and in the Wayland webOS file asks input_driver_keyboard_mapping_blocked() in five places, each time to learn whether the on-screen keyboard is up: to let the remote's arrows and OK move about its grid instead of being keys, and to leave the remote's special keys alone meanwhile. "Keys kept from the binds" is true while a line is being typed, and also under Game Focus and while the menu waits for the key to bind. In those two there is no on-screen keyboard: with Game Focus on, the arrows and Enter of a keyboard were taken for moves about a grid that is not there and did not reach the core, and the menu could not be given one of them as the key to bind. The five ask input_driver_text_entry_active(), which is the question they mean: a line is being typed. Not compiled and not run: the webOS code needs its SDK, and a TV. The two calls are declared side by side and have the same shape; the SDL2 driver compiles without its webOS code. What this does on a TV - that the on-screen keyboard behaves as it did while typing, and that Game Focus and binding a key no longer behave as if it were up - wants looking at there. |
||
|
|
b9544ea208 |
OpenXR headset output for Vulkan on desktop Linux, (stacked on #19728) (#19729)
* gfx/video_views: check, lay out and map touch for a core's views The rules behind a view map live in one module with no driver or settings state: which maps are valid, how a frame is fitted to them, where each view goes in every stereo mode and screen layout, which part of a placement is drawn, and how a window point maps back into the core's packed frame or into the coordinates a per-eye UI is laid out in. Drivers and input share them, and a harness tests them without a GPU, under the sanitizers in CI. * menu: Stereo 3D & Screens settings Stereo Mode (2D, side by side half and full, top-bottom, anaglyph, interlaced), Swap Eyes and Screen Layout, under Settings > Video. They apply only to cores that send a view map. * video: accept a core's view map and hand drivers a layout The map is checked when the core sends it. Each frame the main thread lays it out for the current settings and passes the layout to the driver in video_frame_info_t, so drivers never read settings, threaded or not. A driver that can present views says so with GFX_CTX_FLAGS_VIDEO_VIEWS; otherwise, or when a frame doesn't fit the map, the packed frame is shown as before. A driver that draws a frame with a map whole anyway reports it, and the menu, overlays and touch follow the packed frame from the next frame. Under threaded video, a cached frame larger than the core's declared maximum, redrawn for a screenshot or a Win32 window drag, is now cropped as it was shown, so it makes the same views decision at the same viewport. The drag's redraw runs on the video thread beside the main one, so it lays out what was last presented and writes none of the views state. A hardware frame is no longer cropped: nothing is copied out of the core's image, and a cropped size dropped its views. View chains are built only through a new set_view_count poke, called when the accepted map or the driver's answer changes. Under threaded video the main thread waits while the video thread runs it, so preset parsing, which reads settings and replaces the file-watch list, never runs beside the main thread. A single frame that doesn't fit keeps the chains. Touch maps back through the layout into the core's packed frame, and a CPU filter's output scales the map without changing each view's shape. In side by side and top-bottom the menu and widgets are laid out at one eye's size. The menu maps its mouse and touch position through the layout, so either eye's copy is hit where it is drawn, and RGUI converts against the viewport its texture is fitted to rather than the whole window the driver reports while views are presented; the on-screen keyboard is hit-tested at the UI's size. A paused core asks for the views status only when it runs, so while the menu is open a change of the status (Stereo Mode, a headset) asks the core to update which of its options show, as an option change does. * input: overlays follow views Side by side and top-bottom hide the overlay, so its hit test is skipped there, while touches still reach the core, including through pointer passthrough. Elsewhere a non-fullscreen overlay is drawn over the whole window while views are presented, so it is hit-tested in window coordinates. * vulkan: draw a core's views Each view is copied out of the frame, shaded by its own chain with its own OriginalAspect, and drawn in its placement. A view's chain starts its passes and history small and follows the view's size, not the frame's declared maximum, which for a core like Azahar is 8192x8192 per buffer. A view shown in both eyes draws its final pass again with the first draw's source, so its feedback swaps once. Anaglyph and interlaced draw both eyes into an offscreen canvas and blend its halves into the window. A placement larger than its eye's area, as a custom viewport can make it, is cut there by a scissor on the chain's final pass. In side by side and top-bottom the UI is drawn once into a layer at one eye's size and blended into both halves, at screen depth, and only while there is UI to draw. The layer is FP16, drawn with the SDR pipelines HDR output already builds; with HDR off their alpha accumulates as coverage, so the layer composites as the UI drawn directly would. Views are off with HDR output or an HDR10 source. The driver publishes that answer for the main thread rather than reading its context flags, which the video thread rewrites each frame. A view that can't be copied or given a target falls back to the packed frame, and reports it. * glcore: draw a core's views Each view is blitted out of the frame's texture, keeping its orientation and swizzle, shaded by its own chain and drawn in its placement, following the same rules as Vulkan. Anaglyph and interlaced blend the halves of a canvas twice the window's width. GL counts rows from the bottom, so for interlaced with an even height the eyes take the other halves, keeping the left eye on the window's even rows. The blend programs are compiled on first use; without them the left eye is drawn alone. The UI is drawn per eye as in Vulkan, RGUI keeping its aspect inside each eye. Views need the slang chain, and are off with HDR output or an HDR10 source; get_flags reads published state only. * samples: a test core and end-to-end check for video views The core draws solid-colour views in the 3DS, DS and Virtual Boy shapes, in software, through a GL core context with either origin, or into Vulkan images of its own handed over with set_image, plus a frame larger than its declared maximum, which threaded video crops unless it is a hardware frame. It logs the views status, also when asked to update its options' display, and the touches it receives. run.py drives it in headless gamescope on vulkan and glcore through every stereo mode and screen layout, and checks screenshot colours and the logged status. One case runs a history preset over a core that declares a large maximum and checks the GPU memory it holds. One case runs on gl, which doesn't present views. The pointer cases move the pointer of gamescope's own X server from a helper inside the session and check that the menu's cursor, ozone's and RGUI's, is drawn under it in each eye's copy. It refuses to run on the desktop display. * vulkan, input: headset output through OpenXR PC headsets through the OpenXR runtime: a session on the Vulkan instance and device the runtime asks for, per-eye quad layers composed from the core's view map, flat-screen stereo modes, laser and menu pointer input, and the Monado end-to-end test infrastructure. The runtime is reached through the loader built into the tree, not a libopenxr_loader.so.1 opened at run time, so the same path works wherever the loader does, and the OpenXR headers come from the vendored SDK. The Vulkan instance and device wrappers route either owner of the context, this session or the Android projection context, with no cost where neither is built. OpenXR is on by default on Linux with Vulkan and threads, and its C is in the C89 lane like the rest of the tree. * vulkan: one swapchain per eye for the headset's stereo screens SteamVR on the Steam Frame ignores a quad layer's imageArrayIndex and shows array layer 0, so a stereo screen showed the left eye's image in both eyes and Swap Eyes changed nothing. Each layer of a slot now has a swapchain of its own, and each eye's quad shows layer 0 of its own. A slot's swapchains are acquired and released together, and its quads show once every one of them has released an image. The test layer can show layer 0 of every quad as the Frame does, and the e2e suite runs the stereo and Swap Eyes cases that way too. Revert this once SteamVR honours imageArrayIndex (ValveSoftware/SteamVR-for-Linux#975), to go back to one array swapchain per stereo screen. * openxr: the desktop headset path is built and checked in CI A job builds RetroArch on Linux with OpenXR on - the loader is in the tree, so nothing is installed for it - and runs the Stereo 3D & Screens menu harness, the API layer the Monado end-to-end check records through, and the video_views core, all with the vendored headers. The test layer no longer looks for installed OpenXR headers. * vulkan: the PC headset session is not opened beside the Android projection context * qb: OpenXR stays out of the C89 lane like the Vulkan it needs The vendored Khronos headers are not C89; the tree's own OpenXR C is. * video thread: the poke table keeps its place for the present wait * vulkan: the headset session's handoffs are lock-free What the XR thread tracks for the video thread (the predicted time, the anchor, pixels per radian) and the quads the video thread publishes for the XR thread and the pointer are each a seqlock over their words, the way video_driver.c publishes its viewport parameters, and the frame tick the video thread paces on is an eventcount. Nothing waits on a lock on either side; slot creation and destruction already happen under the queue lock. --------- Co-authored-by: libretroadmin <[email protected]> |
||
|
|
59fa38d1b4 |
input: wayland publishes its mouse and touches; the store has touches
The Wayland driver hands the frontend its mouse's frame and its touches once a poll, and its own answers for the mouse, the pointer and the lightgun's aim are deleted; the lightgun's buttons, which are the mouse's, stay. Read by a core over a session of moves, clicks and wheel turns under Weston it gives the same values as before, but for a second read of the wheel in a frame. With that core reading the pointer and the lightgun's aim every frame, 300 frames took 2796 translations and 2798 viewport fetches before and take 600 and 302 now. Three things change with it on Wayland. Relative motion adds up between polls: each event used to replace the last, so only the last of a frame counted. The motion and the wheel are taken once a poll, where the first read cleared them. And with a real touch in a place, whether it is off-screen goes by the touch, not by the mouse. The frontend's store takes touches (input_driver_publish_touches()): a place with a touch reads the touch, a place with none the mouse standing for it. How many touches a mouse stands for is the driver's to say - 3 for X11 and Wayland, as they had it, 1 for the drivers that will take the left button only - so input_driver_publish_pointers() gains that argument. The store moves to input/input_pointer_frame.h so that a test can drive it: samples/input/pointer_frame, in the input samples job, counts the viewport fetches and translations - eight pointer reads are one of each - and covers touches, both ways a mouse stands for them, and the wheel. |
||
|
|
1baadb09e5 |
input drivers: the mouse pairs of nine drivers are packed
Each of these was a pair of ints, written and read one axis at a time; each is now one VIDEO_POS_PACK word: - DirectInput: the mouse's motion and position; - raw input: the pointer; - SDL1 and SDL2: the mouse's motion and position, read from SDL into locals and stored once per poll; - PSP and Switch: the mouse's position and motion; - GameCube/Wii: the mouse's position and last position, read into locals and stored once; - Wayland: the pointer's position, last position and motion; - the web: the mouse's position and its two motions; - Android: the mouse's position and motion. A pair set together is stored once; a single axis is set with VIDEO_POS_PUT_X/Y and a running total moved with VIDEO_POS_ADD. |
||
|
|
39b49f28ff |
drm, wayland, video: context callbacks that run while drawing read no settings
The DRM and Wayland EGL contexts' swap_buffers run on the thread that draws; they take max swapchain images from their context, where it is latched when the context is made (a change of it reinitialises video). The refresh-rate query, reached from the Wayland, X11 Vulkan and KHR display contexts' resize and swap callbacks, picks the native or SDL display server by video_sdl_display_server, which reinitialises nothing when changed: the main thread publishes it with each frame's info and when the display server is set up, and the query reads that. |
||
|
|
53937798a7 |
wayland/webOS: the seat's events are on the input queue there too
On other compositors the seat and what comes from it are on a queue of their own, which only the input driver's poll dispatches (wayland_input_dispatch()): a key or a pointer event reaches its handler on the frontend's thread and nowhere else. webOS was left out, as its libwayland is an older one, so there the video side's flush_wayland_fd() - on the video thread when video is threaded - and the poll both dispatched the one queue, and an input event was handled on whichever got to it first. What the input queue needs that the older library lacks is only how the desktop code sets it up: a proxy wrapper for the relative pointer manager, and wl_display_roundtrip_queue(). webOS makes neither: it has no relative pointer, and its own init can do without the other. The queue itself - wl_display_create_queue(), wl_proxy_set_queue(), reading and dispatching one queue - it has, and where the backport is built it falls back to the default queue on a library without the reads. So webOS's own code now: - creates the queue at init (RETROARCH_WAYLAND_INPUT_QUEUE=0 leaves the events on the default queue, as on the desktop); - puts each seat on it in its registry handler, before anything is read, so the keyboard and the pointer made from it follow; - dispatches it after the start-up roundtrips, so the seat's capabilities and devices are there before the window is made; - destroys it after the seats and before the connection. The poll's dispatch of the queue is no longer behind the desktop-only switch (WAYLAND_HAVE_QUEUE_DISPATCH; WAYLAND_HAVE_INPUT_QUEUE keeps the desktop set-up). Compiled with WEBOS defined, against a stand-in for the SDK-generated webOS shell protocol header, and the shared Wayland input code for the desktop. Not run on a webOS TV. |
||
|
|
6da6466e88 |
input: no file under input/ takes a state pointer but the frontend
The last 23, in 11 files, are gone. Nothing under input/ calls config_get_ptr(), input_state_get_ptr(), runloop_state_get_ptr(), menu_state_get_ptr() or video_driver_get_ptr() any more, apart from the frontend itself (input_driver.c, input_driver_choice.c). The replay code (input/bsv/bsvmovie.c), seven: - its four entry points that took no state are handed the input state by their callers, the save-state task and the rewind; - its two inner functions used the state only to say the replay is over, fifteen times between them. That is bsv_movie_set_end() now, and they are handed the replay alone. The platform drivers, fourteen settings reads: named calls, as the others became - Apple (keyboard as gamepad, mouse index, rumble gain, device vibration), Wii and GameCube (mouse index and scale, joypad index), Vita (back touch), Switch (split Joy-Con), webOS (screensaver), udev (the five touch options). Two drivers wrote to the settings, and each has a call that says what it is doing: - the Wii and GameCube joypad driver puts port 1 back on the first pad when only one is left: input_config_set_joypad_index(); - the udev input driver, finding no device on the very first start, makes linuxraw the configured driver: input_driver_first_start_fallback(). The SDL2 input driver took the video driver's data to grab the pointer in its window. The video driver does the grab, sdl2_video_grab_window(), and the input driver asks. The Android input driver held the code that writes SRAM, core options and the configuration when Android takes the application away. That is frontend work; it is retroarch_save_for_suspend() in retroarch.c, as it was, and the driver calls it. tools/input_state_grab_check.py has an empty list, and no exemption for the replay code: a file under input/ that takes one of these fails. Built for Linux and Android; the frontend harness, the four replay tests and the udev devices test pass. The Apple, Wii, GameCube, Vita, Switch and webOS files are not built here. |
||
|
|
2bd0428eea |
input: drivers ask the frontend, the menu and the run loop by name
An input driver that needed to know whether the menu was up, or had to say that the platform's keyboard was showing, took the whole state it lived in and picked the field out: if (menu_state_get_ptr()->flags & MENU_ST_FLAG_ALIVE) input_state_get_ptr()->flags |= INP_FLAG_NATIVE_KB_SHOWN; runloop_state_get_ptr()->flags |= RUNLOOP_FLAG_PAUSED | RUNLOOP_FLAG_IDLE; That ties every driver to the layout of four structures and leaves nothing to say what a driver may read or change. Forty of these are replaced, in eleven files, with a named call on the side that owns the state: - the input frontend: the platform's keyboard is available, is shown; a line of text is being typed, is handed over, is done; pointer input is blocked; game focus; the mouse grab; the input driver's data for a joypad driver that is part of it - the menu: menu_driver_alive(), and the label of the open text entry - the run loop: paused by the platform, content loaded (and runloop_get_flags(), which was there) Each call does what the line it replaces did. No driver under input/ takes the input, menu or run loop state any more, but for the replay code in input/bsv. What is left is listed in tools/input_state_grab_check.py, file by file: 63 in 24 files, of which 52 are a driver reading the settings, 10 the replay code, and one the SDL2 input driver taking the video driver's window. The check runs in CI; a count can go down and not up. Built for Linux, Windows (four raw input tests under Wine) and Android, with the frontend harness. The PSP, PS3, QNX, web and webOS files are not built here. |
||
|
|
14ce75bdd9 |
wayland: say why when the compositor closes the connection
A Wayland compositor that finds a protocol error closes the client's connection. RetroArch notices the hang-up and quits as if it had been asked to, with nothing in its log: libwayland prints the error on stderr only. From a log file, RetroArch "just exits". The hang-up now logs the reason before quitting: the protocol error's code and the object it was raised on, or the system error otherwise. [Wayland] The compositor closed the connection: protocol error 4 on xdg_wm_base@18. Quitting. Reproduced under a headless Weston whose output is smaller than the window: leaving fullscreen is a protocol error there. That bug is not fixed here; this only makes it, and any other, show in the log. |
||
|
|
256c8b9801 |
linux illuminance sensor: the poll thread waits without a lock
The sensor's poll thread waited between readings on a condition under a mutex, which a rate change and close took to wake it, and which the thread took and dropped around every reading to look at the rate and the two flags. The rate, a count of rate changes and the done flag are an atomic word each, and the thread waits on an eventcount with the time to its next reading as the bound. A rate change stores the rate, bumps the count and notifies; close stores done and notifies. The thread reads the count before the rate, so a change landing between the two is read again rather than missed. The behaviour is the one illuminance_sensor_test pins: a new rate applies at once, and close returns as soon as a read in progress does. The sample links retro_eventcount.c now. |
||
|
|
1d5dc0cadf |
winraw: Controller Player Lights turned off puts the lights out
With the setting turned off again the lights stayed as they were last set, until the controller was plugged in again. The lights this driver lit are now put out when they are no longer wanted: the setting turned off, or the controller on no port. A DualSense's player lights go dark and a DualShock 4's light bar goes off. Lights the driver never lit are still left alone, so with the setting off from the start nothing is asked of them. sony_pad_output_report() takes a player below nought to mean that: the lights asked for, with nothing lit. |
||
|
|
8b8ce83922 |
winraw: Controller Player Lights
New setting "Controller Player Lights" (input_winraw_player_lights, off by default, Windows raw input joypad driver): each controller shows the port it is on on its own lights, as the consoles do. A DualSense lights its player lights; a DualShock 4 colours its light bar blue, red, green or pink. The lights follow the controller when its port changes. The output report that carries the motors' strengths can ask for the lights as well: sony_pad_output_report() takes a player number, and with none the lights are left alone, as before. The driver's poll looks now and then at which port each controller is on, and the writer's thread sends the report when that changes. Off, nothing is asked of the lights. Turned off again, they stay as they were last set until the controller is plugged in again. Xbox controllers' lights are XInput's and are not touched. Covered by the report builder's test and the raw input rumble test under Wine. Not run on a real controller. |
||
|
|
27ef9955d1 |
input: one thread for the joypad drivers' writes to their controllers
Three joypad drivers each carried a thread of their own to write rumble from, off the frame loop: Windows raw input, udev and XInput. Each had the same loop, wake, quit flag, start and stop. They are now one, input/common/output_writer.c: a thread that is woken through an event (Windows) or a pipe and calls the driver back. Nothing passes through it; what is wanted of each controller stays in the driver's own atomics, and the driver's callback compares that with what it last wrote. There is no lock. One final call as it is freed lets the driver let go of what that thread holds. What each driver writes, and when, is unchanged. The raw input driver's thread was started whether or not the build had threads; it now needs HAVE_THREADS, as the other two do, which every Windows build has. The three drivers' tests run through the helper, udev's under TSan too; the samples that include these drivers link it. |
||
|
|
71318ef1ec |
Fix build warnings on old GCC, uClibc and old wayland-scanner
Statics rely on implicit zero initialisation instead of {0}, and local
aggregates whose first member is an array get the matching braces, so
GCC 4.x -Wmissing-braces stays quiet. Locals the compiler cannot prove
written are initialised (rh265 keep[], rflac block header, query.c
lengths), loops older VRP misreads are reshaped, the unused SDL2
geometry forward declaration is gone, and task_queue no longer names a
variable main.
rzstd probes BMI2 with __get_cpuid_max/__cpuid_count, which every
cpuid.h the branch accepts provides. Hole punching needs uClibc-ng 1.0
with its Linux-specific API on uClibc. The sinc resampler's pop_options
does not warn on GCC 4.x MIPS. generate_wayland_protos.sh strips the
event type and deprecated-since attributes for scanners whose DTD
predates them, which ignore them anyway.
|
||
|
|
1c9249d57c |
winraw_joypad: a DualShock 4's or a DualSense's motion sensors
Under the raw input joypad driver a core that asked for a pad's accelerometer or gyroscope got nothing: the driver had no sensors. Raw input reads these pads by their reports' HID description, which covers the sticks and buttons; the sensors are in the same report, in a part the description calls vendor data. input/common/sony_pad_motion.h reads them from where each pad's USB report has them and turns them into what a core is given: the accelerometer in g, the gyroscope in radians a second, on the axes and with the signs the SDL joypad driver gives the same pads' sensors, so that a core sees the same pad the same way under either driver. The driver gives them through the joypad driver's sensor calls, which the frontend asks before the input driver's. - Read on demand. A pad's sensors are read out of its reports only while a core has asked for one of them: twelve bytes at the end of the parse the report gets anyway, and nothing for a pad nothing was asked of. This is the plan's per-port motion demand, for this driver. - What a core asked is the port's, and kept: a pad unplugged and plugged in again, or the driver restarted because another pad was, goes on giving the core what it asked for. - Over USB only. Over Bluetooth both pads send a short report with no sensors in it until they are switched to their full one, which has no HID description and would take the sticks and buttons away from a driver that reads by the description. A request is taken, and no value is given. - The scale is the pads' nominal one. Each pad carries its own calibration, which is not read: values are right to a few percent, and a gyroscope at rest may read a little off zero. No thread and no lock: the reports are parsed and the values asked for on the polling thread. samples/input/sony_pad_motion holds where the values are read from and what they come out as; samples/input/winraw_joypad_motion runs the real driver under Wine with reports handed to its parser: who has sensors, nothing before a report has had them, only what was asked, none read for a pad nothing was asked of, a short report changing nothing, and a pad coming back still giving what was asked. Both in CI. No pad was read. The report layouts and scales are the ones the Linux kernel's and SDL's drivers for these pads use, set down from memory of them: whether a core's motion follows the pad is for a pad to say. |
||
|
|
afd41a82d8 |
input: a port keeps its mouse by what the mouse is
The same as for keyboards (see "a port keeps its keyboard by what the keyboard is"): Mouse Index is a place in a list that changes when a mouse is plugged in or out, and the place was all that was kept. What is kept now for a port whose mouse was chosen is the mouse's identity (input_playerN_mouse_device) - its USB ids, or its name where it has none - and the number follows from it each time the input driver makes its list of mice. Two things differ from keyboards, and come from what Mouse Index is. Every port has a number from the start, its own, so that the first port reads the first mouse; and there is no "every mouse as one". So: - a port is pinned only when its mouse is chosen by hand - stepped to in the menu or picked from the list - never from a number it merely has. A configuration from before this stays as it was until Mouse Index is next set. Resetting the setting removes the pin; - a port whose pinned mouse is not there reads no mouse while another port has its own, and the mouse its number names otherwise. Mouse Index shows it by name, "046d:c08b (not connected)". Windows raw input and udev say what each of their mice is known by and ask the frontend which mouse a port reads (input_mouse_port_index()), in place of the setting. Under every other input driver nothing changes: no mouse has an identity, no port is pinned, the setting is read as before. Also: the pins header built an identity for the second of two devices of one model in a way gcc warned could truncate; it cannot, and is written so that the compiler sees it. No lock and no thread in any of it: the list, the pins and the lookups are all on the thread that polls. samples/input/device_pins has the mouse cases, in CI. samples/input/winraw_keyboards holds, through the real raw input driver under Wine, what the driver says its mice are known by - the two parts of one mouse told apart, in the order of their numbers - and what a pinned port then reads. The end-to-end run has a port pinned to a mouse that is away. The udev side is compiled only. Not run with two real mice. |
||
|
|
ee036de86d |
input: a port keeps its keyboard by what the keyboard is
A port is given a keyboard by its number in the list of keyboards (Keyboard Index), and the number was all that was kept. It is a place in a list that changes: with two keyboards, each given to a port, unplugging the first makes the second "keyboard 1" - the port that had "2" then names a keyboard that is not there and falls back to all of them, and the other port reads the wrong one. What is kept for a port now is the keyboard's identity, a pin (input_playerN_keyboard_device), and the number follows from it each time the list of keyboards is made (input/common/ input_device_pins.h): - the identity is what the input driver knows a keyboard by that stays the same from day to day: its USB vendor and product id, or its name where it has none. Windows raw input and udev tell it for each keyboard they list. The second of two of one model is "<identity>#2", which holds while they are listed in the same order; - a port whose pinned keyboard is listed reads that keyboard, whatever number it has now; Keyboard Index shows the new number; - a port whose pinned keyboard is not there reads no keyboard while another port has its own - its keys must not come from that one - and every keyboard while none has: a single player who pinned a keyboard that is now unplugged still has keys. Keyboard Index shows it by name, "046d:c31c (not connected)", not as a number that is some other keyboard's now, and the log says what the port reads; - a number with no pin - a configuration from before this - is taken at its word and the port pinned to the keyboard it names. Changing Keyboard Index in the menu pins the port to the keyboard chosen; "All" removes the pin. The drivers no longer read the setting: they ask the frontend what a port reads (input_keyboard_port_choice()), which is all keyboards, one of them, or none. Mouse Index is still a number; that is the same change again and comes next. samples/input/device_pins runs the rule on its own, in CI: two pinned ports each read their own keyboard in whatever order the keyboards are listed; one unplugged, the other is still its own port's and the port left without reads none; a single port whose keyboard is away reads every keyboard; two of one model are two pins. samples/input/winraw_keyboards holds the same through the real raw input driver under Wine, and the end-to-end run has a port pinned to a keyboard that is away: the core still gets its keys and the log says why. The udev side is compiled only. Not run with two real keyboards. |
||
|
|
b8e84c232e |
sony_pad_output: the Bluetooth CRC is libretro-common's CRC-32
The header had its own bit-by-bit CRC-32, so as to stand alone. It is the same CRC-32 encoding_crc32() computes - the report test checks the result against a table-free run of the polynomial, and still passes - so the header calls that, over the unsent 0xA2 and then the report. The tests that compile the raw input joypad driver, and the report test, link encoding_crc32.c and what it needs. |
||
|
|
a8539b6ba1 |
winraw_joypad: a DualShock 4 or a DualSense rumbles
Raw input reads a controller and has no way to write to one, and the raw input joypad driver had no rumble at all: a core's rumble went nowhere under it, whatever the pad. For the two pads there is a rumble report for, it has it now. A DualShock 4 or a DualSense (or Edge) rumbles on an output report in its own format, different for each pad and for USB and Bluetooth; input/common/sony_pad_output.h builds it, asking for the motors and nothing else - the light bar, the player lights, the triggers and the audio are left as they are. Windows lets a controller's HID device be opened for writing, so the driver opens it when such a pad arrives. The write is not made on the frontend's thread. It is a transfer on the controller's link - about a millisecond over USB, many over Bluetooth - and the frame is not to wait for it. set_rumble() notes the strength wanted and wakes a thread of the driver's own, which writes what is wanted now, not every step on the way to it. A write is given up after a quarter of a second, so that a pad gone out of range cannot hold up its own unplugging. Unplugging a rumbling pad, and stopping the driver, still the motors first. This is the second part of the plan's WP-09: output writes go to the provider's thread and never from the iterate. Other controllers have no rumble under this driver still; an Xbox pad's goes through XInput, which is another piece of work. samples/input/sony_pad_output holds each report's id, length and layout, that only the rumble flags are set, and the Bluetooth CRC. samples/input/winraw_joypad_rumble runs the real driver under Wine with files standing in for the controllers: the two Sony pads are opened and another make is not; set_rumble() writes nothing itself and the thread writes the pad's own report at the length Windows wants; a run of changes ends with the last written; unplugging and stopping still the motors. Both in CI. No pad was written to. The report layouts are the ones the Linux kernel's and SDL's drivers for these pads use, set down from memory of them and checked only against themselves: whether a pad rumbles is for a pad to say. |
||
|
|
ddb2053e20 |
input: one rule for which devices are keyboards and which are mice
The Windows raw input driver and the udev driver each say which of the devices a system reports are the keyboards on the desk. udev did it through input/common/input_keyboard_devices.h; raw input had its own copy, kept until its results had been seen on real hardware. They have been: one keyboard listed for a keyboard in two parts, a mouse that sends keys and a vendor's virtual device left out. The header now has the mice as well - which pointers are mice on the desk, and which are a keyboard that can send pointer events (input_kbdev_mice()) - and both drivers go by it for both: - raw input tells it what Windows says of each device and takes its answer, where it had the two rules written out. What it lists and how it numbers things is unchanged; samples/input/winraw_keyboards passes as it was. - udev gets the mouse side it did not have. Every pointer was a mouse there, in the order the devices are in, so that a keyboard that can send pointer events could be mouse 1 - the one the first port reads unless told otherwise. The mice on the desk are numbered first now, in the order they had, and the rest after them, still to be chosen by number and left out of Input Information and of what Mouse Index offers. A pointer's USB interface is read for "boot mouse" as a keyboard's is for "boot keyboard". As with raw input, this changes which number a mouse has under udev wherever something that is not a mouse was numbered before one. samples/input/keyboard_devices runs the mouse rule on its own: a keyboard's pointer part and a pointer with nothing behind it are no mice; a mouse, a mouse on a receiver with a keyboard, a Bluetooth keyboard's trackpoint and a laptop's touchpad are. The udev driver is compiled only. |