mirror of
https://github.com/libretro/RetroArch.git
synced 2026-11-22 10:50:15 -10:00
codex/android-native-streaming
795
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
f626f3f78f |
settings_table.reference: core_firmware_notification_enable and video_threaded_pacing_vblank
The two bools |
||
|
|
bc7280c3ae |
win32: D3DKMT follows the window's monitor
The adapter and VidPn source D3DKMTGetScanLine and D3DKMTWaitForVerticalBlankEvent are asked about are those of the monitor the window is on: bound when the window is made, and again when it moves to another monitor or the display configuration changes. The first display device that opens serves only until a window exists. With displays at different refresh rates, Scanline Sync read the primary's beam for a window on the secondary. The binding is two atomics under a seqlock, written by the window's thread and read by the video and main threads; the adapter left behind is closed. samples/gfx/win32_d3dkmt builds win32_common.c with HAVE_D3DKMT, which no Linux job compiled, and runs the binding under Wine on entry points of its own. |
||
|
|
b3b0b9c23d |
tools: core_hash_bench, a core's first-load hash read against mapped
Standalone timing for the core signature check: hashes one file warm, read into a buffer in 64 KiB and 1 MiB chunks (as core_hash_step does) and straight from a mapping, with and without pre-faulting, interleaved over several passes, best of each. Every way's digest is compared, so a wrong one stops it. Builds on Linux and with mingw-w64. On an SHA-NI Xeon the hash itself runs at about 1 GB/s; hashing from the mapping is 8-10% faster than reading into the buffer (136.9 MiB: 142.8 ms read, 130.2 ms mapped; 44.8 MiB: 45.9 / 42.1 ms; 190.7 MiB: 198.7 / 184.6 ms). Pre-faulting the mapping gains nothing. |
||
|
|
bac280f9d2 |
core signatures: the load check on by default
HAVE_CORE_LOAD_CHECK now builds wherever HAVE_CORE_SIGNATURES does. CI builds the tree once without it. |
||
|
|
f1675e7f4f |
core signatures: the load check's gate and check task
core_load_check.c checks a core before it is opened: the quick check on the main thread, else a task hashes it in slices of the shared I/O window and keeps the result for the load, bound to the file it checked. A refusal tells whether it only waits for the first run's seed. Built with HAVE_CORE_LOAD_CHECK; nothing calls it yet. Its unit harness runs in the samples-tasks job, under ASan and UBSan, TSan and mingw-w64. On Windows the check reads the file LoadLibraryW will load: a name with no '.' is read as <name>.dll, and a \\?\ path ending in '.' is refused, since CreateFileW opens that name as written while LoadLibraryW may drop the dot and map another file. |
||
|
|
670e274643 |
core signatures: let test-key builds hide their notice
Builds that trust the test signing key get a Test Signing Key toggle in Notification Visibility. Off hides the on-screen reminder; the log line saying the build trusts a test key stays on every launch. Release builds have no such setting. |
||
|
|
7e8aeb9d61 |
core signatures: build switches
HAVE_CORE_SIGNATURES builds the signature check and its trust store, HAVE_CORE_LOAD_CHECK the check at every core load, and HAVE_CORE_SIGNING_TEST_KEY the public test key. The first defaults on where dynamic loading and the crypto library are, a line to turn off for one target; the load check and the test key default off. configure has --disable-core_signatures, --enable-core_load_check and --enable-core_signing_test_key. griffin stops with an #error when HAVE_CORE_SIGNATURES is set without HAVE_CRYPTO, as it does for HAVE_S3, rather than failing on crypto/pk.c's missing symbols. |
||
|
|
cba09d9abf |
tools: add core_sign.py to sign libretro cores
Writes <core>.sig for the core signature check: key id, build time, the core's SHA-256 and its file name, signed with ECDSA P-256 as raw r || s. Signing goes through OpenSSL 3.2 or later; without it the tool exits with status 3. A PEM key signs with RFC 6979 nonces, checked against RFC 6979's own vector; a PKCS#11 URI's token makes its own. A build time of 0 is refused: RetroArch's rollback check reads it as no build time at all. |
||
|
|
8498482587 |
xmb: Ribbon Particles setting
The ribbon's drifting specks of light are drawn only with Ribbon Particles on, off by default like Ribbon Glow and Plastic Effect. With it off the ribbon draws its sheet alone, as Simple Ribbon does, and the glow is made of what the ribbon draws. The Wii U, which builds the specks on the CPU, skips them too. |
||
|
|
4bcd9a6c82 |
Rename the identifiers the Windows SDK turns into types
rpcndr.h, which windows.h and the D3D, DXGI and EGL headers pull in, defines small as char and hyper as __int64. The glow named the small image's dims 'small', which broke the UWP ANGLE build in gl_common.c; vulkan.c had the same name, and the replay index another. They are small_dims and inline_idxs now, and the Wii U and Metal glow code is named alike. tools/win_macro_names_check.py finds either name used as an identifier anywhere outside deps/ and the samples, comments, strings, preprocessor lines and member names left out, and the new Win-Macro-Names-Check workflow runs it, so the next one is caught on Linux rather than by the MSVC builds. |
||
|
|
08a6f540cb |
xmb: new ribbon, Ribbon Glow and Plastic Effect
The Ribbon is a lit sheet with drifting dust, worked out from the menu's clock alone, so every frame shows it at its own time at any refresh rate. Plastic Effect shades XMB icons and text as translucent plastic, and Ribbon Glow adds a soft bloom to the Ribbon; both are settings of their own, off by default, since both cost GPU time. The Simplified Ribbon draws from the Ribbon's mesh. Drivers: - Every driver draws the sheet on the GPU from the mesh's positions, read in place; the Wii U works out only the dust on the CPU. - The ribbon's data reaches the GPU straight from gfx_display: its own buffer index on Metal, written into the mapped constants on D3D10/11/12, bound only for the ribbon draw. - With float images the glow takes one output pass. Vulkan, GL and Metal draw its capture and blurs before the frame's first pass, so the pass the menu draws in is never split, which on a tiled GPU would store and reload the whole target. Based on PR #20101. Co-authored-by: Jean-André Santoni <[email protected]> |
||
|
|
abb9781bc9 |
menu: Quick Scroll With Left+Right on by default
Left/right jumps through file browser, playlist and other non-setting lists out of the box again; the option turns it off. |
||
|
|
990384fdb7 |
settings_table.reference: video_skip_dupe_frames
|
||
|
|
68d25aa5bf | Add option for quick scrolling with left+right (#19860) | ||
|
|
fd17192acb |
formats: no file I/O - image_texture's path loaders go through streams/
formats/image_texture.c loaded images by path through the data_transfer file adapter. Its four path loaders (image_texture_load, _load_ex, _load_request, _load_request_ex) move to streams/image_texture_file.c, declared in streams/image_texture_file.h, the same split data_transfer, cdfs and the DVD reader got. The names and behaviour are unchanged; callers include the new header. formats/image_texture.c keeps the buffer decoders and makes image_texture_load_buffer_probe public so the adapter can reach it. image_texture_load_set stays in formats/image_texture_set.c: it does no file I/O of its own, and gfx_surface_still tests it against a stubbed load_request. griffin, Makefile.common, the companion test scripts and the sample Makefiles that build the loaders add streams/image_texture_file.c; the overlay task sample, which stubs image loading, does not. |
||
|
|
68b07f6a1a |
formats: no file I/O - data_transfer, cdfs and the DVD file reader go through streams/
data_transfer reads only through its reader callback. The path entry points keep their names, data_transfer_open_prefix and data_transfer_open_window, in streams/data_transfer_file.c (<streams/data_transfer_file.h>), which opens the file through filestream, reads it at offsets and closes it with the transfer; data_transfer_open_prefix_reader and data_transfer_set_release are the core's side of that. cdfs reads only through the stream a track holds. cdfs_open_track, cdfs_open_data_track and cdfs_open_raw_track are in streams/cdfs_file.c (<streams/cdfs_file.h>); the length-based sector probe they use is cdfs_track_sector_size_from_length. rdvd_vfs, which binds files to the DVD source, and rdvd_stream, which drives it, are streams/rdvd_vfs.c and streams/rdvd_stream.c, their headers under <streams/>. cdfs_file_test covers the path openers: a cooked iso and a raw bin sized by length, a cue sheet resolving its bin beside it, an INDEX 01 offset, the data track, refusals. |
||
|
|
5ab2152e6a |
The checks today's commits left behind: cloud sync reads, centre point picks, gapless WMA, the H.264 border
|
||
|
|
2c80e1abd6 | Add Bluetooth settings visibility option | ||
|
|
a86d86a22c |
HAVE_RGIF: GIF images through image_texture, image_transfer and the tasks
rgif now loads GIFs wherever RetroArch loads images: thumbnails and
backgrounds through task_image, the image viewer core, the file browser
and the image_texture/image_transfer layer underneath them all.
rgif:
- the image_transfer interface the other decoders have:
rgif_set_buf_ptr, rgif_set_avail, rgif_header_ready and
rgif_process_image, giving a 32-bit texture of its own, ARGB32 or
ABGR32 in native byte order
- RGIF_ABGR, for ABGR32 on big-endian targets
- a file not all read yet gives IMAGE_PROCESS_WAIT and is not touched;
the image is decoded in one call once it is all in
Wiring, as HAVE_RTGA is wired:
- IMAGE_TYPE_GIF (image.h) and NBIO_TYPE_GIF (task_file_transfer.h),
both appended so no other value moves
- image_texture_get_type: .gif
- image_transfer: new, free, start, is_valid, set_buffer_ptr, process,
set_avail; the support matrix gains a GIF column
- task_image and task_file_transfer: GIF is an image task
- FILE_TYPE_GIF ("gif", "GIF"): opened as image content
- the file browser's image extensions, the image viewer core's
extensions, the System Information list ("GIF (RGIF)") and
--features ("RGIF"); SUPPORTS_RGIF in config.features.h
- griffin.c, Makefile.common (rgif.o), configure (HAVE_RGIF=yes), and
next to HAVE_RTGA in every platform Makefile, the Android, Apple,
MSVC, UWP and QNX projects and the CI compile matrix
- tools/settings_check.py and tools/stack_budget.py check with it
Also: menu_displaylist's image viewer extension list wrote "tga"
without moving its length on, so "webp" and "dds" landed on top of it
and TGA dropped out of the list; it moves on now.
Tests: rgif_test checks the texture in both byte orders against
rgif_decode, the wait before the whole file is in, and a refused file;
image_decode_fuzz sweeps GIF too (every byte of a small GIF set to
edge values, and every truncation), under ASan and UBSan. The griffin
unity build with every codec, the touched objects in a configured
build, the MinGW/C89 syntax check, the overlap check and the stack
budget pass.
|
||
|
|
ce3ee5174c |
net_upnp, raac: the stack budget and overlap copy checks
net_upnp_discover() held a 1536-byte SSDP datagram buffer next to a NET_UPNP_URL_MAX location, a 2384-2512 byte frame against the 2048 the budget allows for PSP's and GX's 8 KiB thread stacks. The datagram buffer is allocated once per discovery instead, before the receive loop, and freed with the socket; a failed allocation fails the discovery as a failed socket does. The parametric stereo decoder's six same-array copies are disjoint by construction and go on the overlap allow list: a parameter row copied from another row (the copy is guarded by src != num_env), the matrices of envelope 0 from envelope num_env_old (guarded by num_env_old > 0), and in_buf[i][32..37] down to [0..5]. tools/stack_budget.py reports no frame over 2048 bytes (Linux gcc and x86_64 mingw); the overlap copy check is clean; net_upnp_test passes under ASan and UBSan. |
||
|
|
026a7aa690 |
iOS screen margins: keep iPad multitasking and iOS-only settings
Follow-up to the scene window and screen margin change. Sizing from the window made the iPad multitasking test compare the view with its own window, which it always fills, so Split View, Slide Over and Stage Manager stopped being detected and the safe area was applied to them. Compare the window with the screen. The four settings were registered on every platform, adding keys to every retroarch.cfg. Registering them under TARGET_OS_IOS, as audio_respect_silent_mode is, keeps them off the others. They also had no sublabel: the description never appeared because sublabels are bound through the table in menu_cbs_sublabel.c. The margins were copied into an NSData, queued to the main thread and stored in an ivar, on a path borrowed from the screen orientation setter. All of it runs on the main thread already, so the layout now reads the settings directly and a change only asks for a layout. That also stops every slider step from re-requesting the orientation, and drops CMD_EVENT_VIDEO_APPLY_STATE_CHANGES, which ran before the asynchronous layout it was meant to follow. Margins are rounded to whole device pixels so the layer is not resampled at a fractional position or size. |
||
|
|
ed38dd6394 | iOS: preserve scene windows and add configurable screen margins | ||
|
|
b7f61b38be |
rh264, video decode interface v4: tag each access unit, get it back with its picture
A caller that attaches something to each access unit - the Wii U's H.264 API takes the game's output buffer with every unit - has to find it again on the picture that unit produced, and with B pictures output is in display order, not the input's. rh264_video_set_tag gives the picture the next decode opens a value; rh264_video_tag returns the value of the picture handed out. It rides with the picture through the output queue on both the software and the hardware path, and is taken when the picture opens, so a pool or rotating contexts finishing it later do not change it. A field pair keeps its first field's. Savestates carry the queue's tags (version 2; version 1 still loads, with tags 0). retro_video_decode_interface version 4 adds set_tag and get_tag over them. Tests: rh264_hw_test tags every sample and checks each picture's tag names a sample of its own - presentation times rising, each once - on both paths; rh264_state_test compares tags as well as pictures, so a loaded decoder must give back the tags its pictures went in with. tools/test_video_decode_interface.py checks v4 is accepted and v5 refused, that a v3 query writes nothing past get_gpu_frame, and v4 tags in presentation order through the frontend callbacks; it now runs in the libretro-common samples workflow, plain and under ASan/UBSan. |
||
|
|
5756db8659 |
Input: Plays As, several controllers on one player, with hotkeys of their own (#19916)
* OpenXR: the controllers' slots are not read from the driver's view
A joypad driver that keeps its pads' state lends it to the snapshot
bridge through view(), and the bridge reads that in place of a copy
(
|
||
|
|
ecfbdbf3aa |
overlap_copy_allow: the deflate fast-table doubling and a test's distinct elements
The overlap-copy check flagged three same-base copies, all disjoint: rinf_build doubles its fast and pfast tables in place, copying entries [0, cur) to [cur, 2cur), and video_windows_test copies place_d[1].name into place_d[2].name. memmove would only slow the table build the in-place doubling was written to speed up, so they are allowlisted. |
||
|
|
18128e1fa5 |
menu: a display for each screen, Menu Follows, Menu Display and Notifications
On Android, Separate Screen Windows reads "Game Screens on Other Displays". While it is on, Stereo 3D & Screens lists a Game Screen N Display row for each screen, Menu Follows (Game Screen 1, Game Screen 2 and each further screen the core has, or Separate), Menu Display (only when the menu follows no screen) and Notifications (With the Game or With the Menu). A Menu Follows screen kept from a core with more screens stays until it is changed. A display row offers Auto, each display by name with its product and size, such as "Display: DP Screen (DELL U2720Q 2560x1440)", and Off. OK opens a dropdown of the displays listed now. "Game Screen" and "Display:" keep a game's second screen apart from a panel Android calls Screen-2. The name is what is saved, so the same port is found again whichever monitor is on it; a display no longer listed shows as "Display: <name>" and counts as Auto. video_screenN_display, video_menu_follows, video_menu_display and video_notifications_window are saved in the config and in core and content overrides. They replace video_screenN_window_mode: an old Hidden loads as Off, Attached and Separate as Auto, and the old key is no longer written. The mode setting is gone, and the monitor row is listed on no platform; video_screenN_window_monitor stays in the config for the desktop. Until placement reads them, screen 1 stays in RetroArch's window and the others go by Auto unless Off. |
||
|
|
a4172fdafd |
CI: the lanes Ubuntu 26.04 broke, and the formats warnings
Built with ffmpeg 8, libaom 3.13, x265 4.1, glibc 2.43 and clang 21, five lanes failed on the 26.04 runners: - AV1 fixtures: a monochrome sequence comes out full range with no matrix whatever is asked for; the oracle takes the colour ffprobe reads instead of assuming it. - Preview audio oracle: ffmpeg 8 leaves a timestamp gap at every seam of a -stream_loop copy, which the mixer honours and ffmpeg's raw decode does not. trailing_large loops its picture and encodes its sound as one track. - rh265 multi-slice oracle: x265 4.1 writes unreadable slice headers when two slices are encoded on several threads; those cases encode on one worker. - vkms: the kernel follows the runner's own release, its modules may sit under /usr/lib/modules, and modules-extra is fetched only where it exists. - clang -std=c89 -pedantic: glibc's const-generic strchr/strstr under _GNU_SOURCE are _Generic; -Wno-c11-extensions goes wherever -Wno-c99-extensions already does. ci_paths filters a file at the top of a samples tree by its own path. rh264 and rh265 lose the parameters no instantiation reads, the 8-bit H.264 kernels mark the depth they ignore, and the AV1 WebM fixtures leave out the MP4 box writer they never use. |
||
|
|
08e5b72a88 |
Scan from the command line: exit status, Manual Scan options, playlist refresh (#19977)
* file_path: stop at the end of the path after '~'
fill_pathname_expand_special() skipped two characters after a leading
'~' or ':', so a bare "~" read past its NUL and "~x" lost the x. It
now skips the prefix and a slash after it, if there is one.
* scan: hand the callback user data and what the scan did
task_push_dbscan() and task_push_manual_content_scan() take user data
for their callback, and the callback's task_data is now a
task_dbscan_result_t: how many entries the scan added, how many its
playlists already held, and how many files matched nothing. A file is
counted by what became of it, so an archive that is expanded is not
counted as unmatched, and a loose scan's unmatched files count as
added. Callers pass NULL for now.
* scan: say in the result when a scan failed
A scan that ends before it runs (bad setup, no valid content, a DAT
that will not load) or ends with a task error now sets the result's
failed flag. A database folder that is missing or unset is treated as
an empty one, so it reports the same "no database" error instead of
finishing as if it had scanned.
* scan: count the files a scan could not read
A file whose scan fails (an unreadable file, a failed lookup) was in
no count. The result now carries an errors count for them. They do
not fail the scan.
* scan: print --scan errors on stderr and totals on stdout
A command-line scan now ends with a totals line on stdout, or with the
reason it failed on stderr. A file it could not read is listed on
stderr. The ++/==/?? marks are coloured only when their stream is a
terminal, so pipes and redirected output get plain text; on Windows
redirected output keeps its marks instead of losing them to
WriteConsole.
* scan: the manual scan finder skips a finished task
A finished scan stays in the task queue while its callback runs, and
the finder that refuses a second scan for the same playlist still
matched it, so a scan pushed from that callback was refused.
* retroarch: run every --scan, then exit with what the scans did
Each --scan is collected while the command line is parsed and run in
turn once it is done, so later options and further --scan flags are
no longer dropped. A path is expanded and made absolute first; one
that does not exist, or a scan that cannot start, is reported on
stderr and the next path still runs. --scan with --cloudsync or
--command is refused.
Without --menu the exit status is 1 if any scan failed, else 0 if any
added an entry, else 2, and a content path given with the scans is
ignored, with a line on stderr. With --menu each finished scan starts
the next, as a second scan is refused while one runs.
* manual_content_scan: clear the database name a refresh did not save
A playlist with no saved database name left the name buffer
uninitialised, and the refresh compared it against every installed
database, so whatever was on the stack could pick a database the
playlist never named.
* scan: Skip Database References names the scan's one playlist
The option was meant to put the playlist's name in each entry's
db_name, even for a database match (#18641), for users who build
their own thumbnail sets. When the scan picks the playlists, db_name
also picks the playlist an entry goes to, so with the option on every
match went to one playlist named after the content folder.
It now applies only when the scan writes one playlist, and gives
that playlist's name, a loose scan's unmatched entries included. With
the target on <Automatic>, or Fully Automatic with the option left on
from a Custom scan, matches go to their databases' playlists as with
it off; the entries of a custom playlist look their thumbnails up
under its name, not the folder's.
* scan: name the scanned folder in the start line
The "Scanning content" line, in the log and in --scan's output, has
named the database folder since the manual scan and the database scan
were merged (
|
||
|
|
58106ef61c |
CI: skip the workflows a push's samples and workflow files do not touch
Every push ran every workflow. tools/ci_paths.py now writes each workflow's push and pull_request paths filter: everything, less the samples trees and the other workflow files, plus the sample directories its jobs build or run (through the scripts they call and the paths those directories name in turn) and the workflow itself. A push to one sample runs the full-tree builds no longer, only the workflows that run that sample; a push to one workflow runs it alone; any other change runs everything as before. Jobs that call a tool or CI script, walk the samples trees or read the workflow files keep those whole, and workflows with a filter of their own keep it. The CI local runner workflow runs tools/ci_paths.py --check, which fails when a filter no longer matches what its workflow names, and tools/ci_local.py which reads past a generated filter to the coverage. |
||
|
|
a4c7689a6c |
rzstd: keep short match copies disjoint on builds without vectors
A match copied with slack went to the wide copy once the source was two vector widths back. The wide copy's short case is one fixed 32-byte memcpy, and on builds with no SSE2 or NEON a vector is eight bytes, so a match 16 to 31 bytes back and 32 or fewer long was copied over itself: undefined, aborted by the sanitizer and by fortified libcs, and liable to repeat stale bytes. The wide copy now also needs the source 32 bytes back; below that the eight-byte path, which takes any offset of eight or more, does it. On SSE2 and NEON both limits are 32, so nothing changes there. The raw block test is also built with the vector path switched off (rzstd_raw_block_test_novec, run in the samples job); it fails without this change and passes with it. The overlap-copy check flagged rzstd_match_copy's call sites since the helper copies within one buffer; it is now audited and on the allow list. |
||
|
|
513f559a36 |
rh264: savestates
rh264_video_state_size/save_state/load_state: the decoder between access units - parameter sets, picture order, reference marking, the DPB and output queue with their samples and motion. A loaded decoder decodes on exactly as the saved one, and saves the same bytes again. Pointers are not stored; a state from another layout is refused, and a refused load leaves the decoder as after a seek. A threaded decoder's last picture, open until the next one opens, is closed by a save and shown when that opening would have shown it. rh264_state_test splits seven clips at every access unit on one context, four, and a pool; it runs in the samples and TSan lanes. |
||
|
|
023bae90d7 |
tpool: the overflow without a lock, and workers that sleep
Jobs posted while the ring is full go on a lock-free stack, counted before they are pushed. Whichever thread finds the ring empty and holds the drain token takes the oldest for itself, moves as many more as fit into the ring and wakes a worker for each; one turned away leaves word, so the holder looks again before it lets go. Overflow nodes come from a pool of spares on a free list tagged against reuse. A worker that sees a job counted and cannot take one sleeps instead of yielding in a loop, and passes on a wake that found it still marked parked. tpool_add_work joins the lock-acquire budget at zero. |
||
|
|
27967e0b52 |
task_queue: titles and errors without property_lock
With the lock-free runner a task's title and error are also published as atomic pointers beside the handler's own fields. Progress reports and snapshots read the published copies inside a read epoch, and a string replaced while a reader is inside goes through the epoch's limbo instead of being freed at once, so a worker replacing its title never waits on the frame that is formatting it. The getters return the published copies; a title or error assigned to the field directly is published when the task is pushed. The locked runner keeps property_lock. |
||
|
|
5ba7f8c8cb |
task_queue: a threaded runner without locks
Where the atomics have compare-and-swap and pointer operations, the threaded runner takes no lock and waits on no condition variable. Every task is on a live list from its push until it is retired: any thread links it at the head, only the checking thread unlinks it, and find(), retrieve() and the lookups behind wake, cancel and reset walk it from any thread inside a read epoch. A retired task is cleaned up and freed once no finder can still hold it, at once when none is inside, since finders read task->state. Workers take ready tasks from two bounded MPMC rings: the plain one, which only the one worker takes from, and the parallel one, which every worker does; what overflows waits behind them in order. A task with a 'when' to wait for goes to the timer keeper, whichever idle worker holds the token, which sleeps until the earliest is due and hands the token on before it runs anything. Main-thread tasks and finished ones reach the checking thread through lock-free stacks. Workers, task_queue_wait() and deinit's bounded wait for the workers park on eventcounts. Each gather with work in flight and each pass's end advance one counter that both read, so a handler still sees what the frame loop wrote before a check, as the frame count a load waits on, and has read it before the loop writes again. The volatile and PS2 backends keep the locked runner, as does GCD. task_queue.c now uses retro_eventcount.c, which the sample builds compiling it with threads now link. task_queue_parallel_test floods both rings past what they hold with every worker held; task_queue_switch_test holds a waker in retro_eventcount_notify() where the runner takes no lock. |
||
|
|
6ebf66b643 |
OpenXR: per-screen placement for headset screens, and Edit Screens to arrange them by hand (#19945)
* video: per-screen geometry for the headset's floating screens Each floating screen, by the core's logical screen id, gets its own offsets, yaw, pitch, roll, scale and visibility (video_screen_xr_t), applied on top of where the layout puts it. video_views_xr_reset gives the defaults and video_views_xr_normalize clamps each value to its range: offsets to 10 m either way, angles to 180 degrees, scale from 0.1 to 10. A planner given no screens uses the defaults, so nothing moves until a setting does. * configuration: save per-screen headset geometry video_screen<N>_xr_x, _y, _z, _yaw, _pitch, _roll, _scale and _visible keep each floating screen's adjustments for screen ids 1 to 8, and survive configuration overrides like the other video settings. A minimal save writes only the values that differ from the defaults. The video_screens settings sample checks the round trip and the override cases, and runs in the OpenXR input and Wine views jobs. The defaults fixture now links video_views.c, which the reset uses. * menu: per-screen controls for the headset's floating screens Stereo 3D & Screens gains Screen, which picks a floating screen by its logical id among those in the current frame's map, and for it Horizontal, Vertical and Depth Offset, Yaw, Pitch, Roll, Scale and Visible, with Reset Screen and Reset All Screens. The rows apply live and are hidden where they cannot apply, such as a tracked projection's eyes. Stepping between screens reads one snapshot of the map and is bounded, so a tracking change mid-step cannot leave it walking an empty map. docs/openxr.md describes the controls; the video_screens sample drives them through the shipping menu actions. * video: apply per-screen headset geometry to the frame snapshots Each XR planner, Vulkan's and GL's, takes the normalized screen settings with the frame snapshot, so a screen moves, turns, scales or hides as its rows change, while paused too; recentering and tracked projections are unaffected. Screen images are kept between frames, so shader feedback survives a placement change. A retained XR target that cannot be allocated is skipped quietly, remembered by its size so it is not retried every frame; only the desktop UI and canvas targets log the failure. Covered by openxr_core_test, the video_screens sample, the e2e runner's feedback shader case and the new vulkan_views_target sample. * android: keep the OpenXR EGL context C89 gl_xr_egl_init declared its extension string after statements. * video: pose inverse, layout spots and grab maths for headset edit mode Each item's layout spot comes from one helper that placement uses and the quad set records per slot, so a shown pose turns back into the settings that placed it. Grab maths: the item follows the aim, level unless tilting, offsets clamped to the settings' range; the stick pushes along the ray and resizes. Edit picking sees every item and takes the menu by a handle bar under it. * video: a frame without a view map is screen 1 in the headset A core without a views map (SNES, say) had no screen to select, so its frame could not be moved. Its whole frame now takes screen 1's offsets, turn, scale and visibility, and the selector lists Screen 1. gl's window stays as laid out while the menu is open over it. * video: the headset's menu in front of screen 1, or where it was put The menu sat at a fixed spot, so moving screen 1 closer left the menu behind it. It now floats 10 cm in front of screen 1, facing as it does, at its default angular size and never nearer than 0.4 m, while screen 1 floats and shows, and is still submitted after the screens. A menu place (video_openxr_menu_xr_* with video_openxr_menu_placed) overrides that; it is saved like the per-screen keys, and Reset All Screens clears it. * input: Edit Headset Screens mode for the OpenXR controllers Edit Screens starts from a hotkey, a headset action, the HEADSET_EDIT_SCREENS command or a Stereo 3D & Screens row, and stops on the same, on opening the menu, on a video reinit or when the session ends. It syncs its own action set in place of the game's, points the lasers at every item whatever the Laser Pointer setting, keeps the menu's quad up while editing, and with While Editing Screens set to Pause pauses only content that was running. A runtime that refuses its bindings keeps the game's and leaves edit mode unavailable. The setting reaches the headset's poll with the others, and the pause and resume are asked of the frontend as platform requests, so the input driver issues no command and takes no settings itself. A Laser Pointer value past its choices, which a hand-edited config can hold, reads as Auto rather than as edit mode's. * input: grab, tilt, push and resize headset screens in edit mode A grip on an item takes it in the screens' frame: it keeps its pose relative to the hand, stays level unless the trigger is held, and the stick pushes it along the laser and resizes it, past a deadzone. Each poll writes the item's offsets, turn and scale where the menu's rows write them, through named frontend calls, clamped so it waits at a limit and resumes from there. The menu is taken by its handle; a menu that follows screen 1 is placed as large as it shows. The main button resets a free item as Reset Screen does, or puts the menu back in front of screen 1. A recenter, a screen leaving the map and leaving edit mode let go, counted for the frame snapshot; an untracked hand holds its item still. * openxr: held screens follow the hand at the headset's rate The main thread publishes what each hand holds through a seqlock; each headset frame re-places a held item, both eyes of a stereo screen, from that frame's own aim, so it no longer waits for the next video frame. An item let go stays where the hand left it until a quad set planned at or after its release (an edit count carried in the frame snapshot) shows it, even once the hand holds another item, so nothing steps back. Lazy Follow holds its glide while anything is held. Edit mode outlines every item, brightly the one under a laser, and draws the menu's handle bar under it, from the laser's image, now an atlas of the dot, two outlines and two handle bars. They take only the layers the screens leave after the dots. * openxr: edit mode end-to-end cases and documentation The test layer's aim can roll, and the e2e runner drives edit mode against Monado: grabs that follow the hand on every headset frame and stay where they are let go, level and tilt, the stick, resets of a screen and of the menu, the menu taken by its handle and following Screen 1 at its size, outlines and the handle, a no-map core, a views core's fallback frame, Follow Head, Lazy Follow, recentering, two hands, pausing, and what starts and ends edit mode, including the headset's hotkey bits with no command interface. The cases whose work is a host's or driver's own run on glcore and gl too. docs/openxr.md explains editing screens in the headset and where the menu goes. * openxr: a laser beam from each controller to its dot A thin strip runs from each hand's aim to its dot, or 1.5 m into nothing, turned about its own axis each headset frame to face the head so it never shows edge on. It comes from the laser's image, so it needs no new swapchain, and uses layers left after the dots and edit mode's outlines, so it is the first to go when the runtime has few. The new Laser Beam setting shows it in edit mode only (the default), always, or never; outside edit mode, Laser Pointer and its hotkey hide it with the dot. * openxr: edit mode outlines in three bands, outside the item A light band between two dark ones shows on white, black and busy borders alike. The rim now sits wholly outside its item, 5 mm clear of it even after filtering, so it never covers the picture; its region grows to keep two texels a band at about the old thickness. Screens' outlines are submitted before the screens, so a neighbour placed flush covers the part of a rim over its picture, while the menu's outline and handle bar stay on top. The handle bar moves 5 mm below the menu's outline, which it would otherwise cover, and gets the same bands, faint and bright. * input: choose a headset edit item with Select Next and Previous Edit mode steps from the laser through the screens it can move and the menu. A chosen item is the one lit, either hand's grip takes it from wherever the hand is, and Reset resets it, so a screen hidden behind another can be moved. Whatever a hand holds stays lit. A ray on the menu's handle bar takes the menu before any screen in front of it. Within 3 cm of the bar, a ray that came from the bar keeps the menu even over a screen, and one that came from elsewhere takes it only where no screen is hit. * openxr: snap a held headset screen to the screens near it Snap to Screens, on by default, turns a held screen parallel or square to a nearby screen and lines up its plane, edges or centre. Each pull is exact within 3 cm or 5 degrees and fades out over as far again, so the screen catches up with the hand rather than jumping, and snapping fades in over the first 5 cm or 10 degrees after a grab, so taking a screen never moves it. With several screens near, the snap that leaves the least error wins, so a near screen's exact pull beats a far one's fading pull whatever their order. One stateless function inside the grab serves the main thread and the headset's thread, so a screen is saved where it was shown. The holding hand buzzes as a snap takes hold, once, and not again until the screen has left that pull. * input: turn a held headset item with the free hand's stick A quarter turn of a held screen needed the controller turned a quarter turn, which swung the screen round the hand on its long reach, so a square snap could not be reached. Now the stick of the hand holding nothing turns what the other hand holds about the vertical through its middle, faster the further it is pushed, and snapping still catches it parallel or square. A carried item keeps its pitch and roll and its angle to the way the hand points across the floor, so raising, lowering or twisting the hand no longer tips or swivels it; the trigger lets it ride the hand rigidly. * openxr: smooth the controller aim in edit mode A screen held about 2 m out on the laser magnified every tremor of the hand. In edit mode each hand's aim now goes through a One Euro filter, which smooths a slow hand hard and a fast one little, with its rate taken from the headset frame's own time step. The headset's thread filters once a frame and hands the result to the main thread, which grabs, moves and lets go from it, so a screen is saved where it was shown. The new Edit Smoothing setting picks Off, Low, Medium (the default) or High; outside edit mode the lasers are never smoothed. * openxr: name the chosen edit item beside the controller Edit mode now shows a faint tag just above the hand that last pressed Select Next or Previous, reading Laser, Screen N or Menu, so what the grip will take is plain without a notice. The words are drawn once into the laser's image in the default font and the interface language, light over a dark halo like the outlines so they read on any background, and the tag is one more headset layer; when the runtime is short of layers the beams are dropped before it. On a runtime whose swapchains are too narrow for the words, the laser's image keeps its old width and there is no tag. * input: tilt a held headset item with the free hand's stick In edit mode the free hand's stick already turns the item the other hand holds. Its up and down now tilt that item too, about the item's own left-right line through its middle, at the turn's rate and with no limit: up tips the top back, as when pushing a monitor's top back. It works whether the item is carried or rides the hand with the trigger held, and snaps as the turn does. Within about 25 degrees of left or right the stick only turns, and within about 25 degrees of up or down it only tilts, so a push meant for one does not drift into the other. Edit mode's starting notice lists the turn and tilt and stays about 8 seconds. * input: snap a turned or tilted headset item to angle steps While the free hand's stick turns or tilts a held item in edit mode, the item clicks into steps of the new Snap to Angles setting (15 degrees by default; 30, 45, 90 or Off), so it is easy to set straight. The turn counts from facing the user's head across the floor, the tilt from upright. Within about 2 degrees of a step the item holds there and the holding hand buzzes once; the stick's own angle keeps adding up, so pushing on leaves the step. Only the stick steps: carrying an item or tilting it with the trigger never clicks, and a snap to another screen that would engage wins over a step. * openxr: show the back of a headset screen turned away Runtimes draw only the front of a quad layer, so a screen or the menu turned away from the head vanished. When the head is behind a quad's plane, the frame now submits a plain dark panel in that quad's place: a solid grey cell of the laser's image, at the quad's size, turned to face the head. It takes the quad's own layer, so the layer count and cap are unchanged. Edit mode picks either face, so an item turned away stays grabbable, and its outline, handle and dot turn with its back. * input: keep a screen snap's angle once the free stick lets go A snap to another screen shows a held screen square or parallel to it, but the item's own angle stays where the stick or the hand took it, up to several degrees off. The next turn with the free hand's stick started from that hidden angle, so the screen left the snap early on one side, late on the other, and caught up with a lurch. Now, as the free stick returns to its deadzone and as a push starts, a snap engaged on the turn becomes the item's own angle: the carried turn, or the orientation the trigger tilts. A snap still fading in never does, since that would hop the screen into it. The place is left to the hand, and carrying alone never keeps the angle, so pointing still pulls a screen out of a snap. Letting go of the grip leaves the item where it shows, as before. * openxr: hinge a held headset screen to a neighbour's edge Snap to Screens now also hinges a held screen to another along a shared edge at any angle between them, so a DS or 3DS pair can be opened at a slant: an edge within 5 degrees of parallel to one of the other's, within 3 cm of its line and sharing some length with it, turns exactly parallel and moves onto it, centres or ends level, its angle left free. The pull fades in over the first 3 cm of shared length, so a screen slides off the end of the other's edge without a jump, and a diagonal neighbour never hinges. Screens that would overlap do not hinge; the pull is whole from flat to square and fades out folded shut. Flat and square snap as before and report a hinge at 0 and 90. A turn to the same screen pivots on the shared edge, so the edge stays on the line as the screen leaves flat or square. The snap still keeps nothing between calls; its result carries a hinge bit, and video_xr_snap_hinge also says which edge and line, for the stick to swing about. * input: swing a hinged headset screen about the shared edge While a held screen is hinged to another, the free hand's stick axis that turns nearest the shared edge, the tilt for a top or bottom edge and the turn for a side one, now swings it about that edge, so it stays attached; the other axis still turns or tilts it and can pull it off. Where the swing leaves it, angle and place, it stays as the stick lets go. Snap to Angles counts a hinged screen's steps from flat with the other screen. A hinge counts only while the screen's own edge is within its range, not when other snaps alone hold it on the line, so a swing never carries a screen round a line it is far from. A square corner is a side hinge at 90 degrees, so the turn stick there now swings the screen about the corner's edge. Main thread only; nothing new reaches the frame loop, which still shows the grab through video_xr_grab_pose. * openxr: leave a gap between hinged headset screens Edges that meet in edit mode, side by side, at a corner or hinged at any angle, now click to a set gap from within 1 cm and otherwise keep the gap the hand gives them, still hinged, up to 10 cm (letting go by 13). Screens no longer have to touch, which made them overlap. Each grab carries the gap, so the edit poll and the frame loop snap alike; until a setting sets it, it is 0. Pushed past touching, a hinged edge stops there for the first centimetre of the push, the stop fading out by 3 cm, and ticks once per push. A swing pivots on the held screen's own edge, so the gap keeps through it, and a commit keeps the hand's gap unless the click holds it. After a swing lets go past square, that stick axis and its steps keep pivoting on the same edge until the edge leaves the hinge's reach, so a flick past square and back does not creep. Of two neighbours within the 5 degree turn snap, the nearer edge wins the turn and the hinge, by one measure for every screen, so a screen stacked behind, one off the ends of the edge or a side wall at a corner never outranks a hinge the turn holds. * menu: add Hinge Gap for headset screens Hinge Gap (0, 1, 2, 3, 5 or 10 cm, default 2) sets the gap edit mode's Snap to Screens leaves between screens that meet edge to edge, side by side, at a corner or hinged. Edit mode takes it as it starts and gives it to each grab; the click to it buzzes like the other snaps. * menu: put Edit Screens under Headset Output Stereo 3D & Screens now lists Edit Screens and its snaps right under the switch that reveals them, then the headset's own setup, then where the screens go, with the per-screen rows last and Visible first among them. * openxr: track each held screen's hinge on the frame loop The frame loop already re-snaps each held screen every frame. It now also keeps, per hand, the hinge that snap holds whole, until the edge leaves the hinge's 4.5 cm reach, where the frame draws it, so edit mode can mark it. A kept hinge whose target no longer matches is dropped. video_xr gains the hinge line's ends, along the overlap of the two real edges and midway across the gap, an outline cut that drops one edge's rim, and a green strip in the laser's image, before the tags. * openxr: mark a hinged headset screen with a green line While a held screen's hinge holds, the two edges that meet drop their outline rim and a 6 mm green line runs along the hinge where they overlap, midway across the gap, so it is clear when the hinge has taken hold. The line is drawn as the beam is, a centimetre nearer the eye than the edges, since SteamVR does not keep the order of overlapping quad layers, and comes after the outlines in the layer budget; hidden rims cost no layer. * input: buzz longer as a headset screen hinges A hinge taking hold now gets one 150 ms buzz at 0.8 on the hand carrying the screen, against the 20 ms snap tick, so the attach can be felt. It fires again only after the edge leaves the hinge's reach, hinges elsewhere, or the other hand takes the screen it hinges on, so a swing past square and back does not repeat it. Ticks due while it plays are skipped rather than cutting it short. * openxr: find headset screens resting in a hinge Two screens no hand holds rest in a hinge when their poses pass the test that engages a carried screen's hinge, with either one carried, and the hinge, held whole with nothing else pulling, leaves the carried one where it is. So a hinge found at rest stays hinged when its screen is taken. The engaged test moves into its own function so both use the same one, and one target can pull whole whatever the grab's fade. * openxr: keep a headset screen's hinge shown at rest In Edit Screens, two screens no hand holds that rest in a hinge keep the green line and their hidden rims, whether let go hinged or loaded that way. The main thread counts them only when a resting screen changes and sends them with the hands' record, so a release and its resting pair arrive together; the frame loop places each line from the screens it shows. A screen hinged at rest on two adjacent edges still keeps one of those rims. The hands' record now outgrows the quads, so the seqlock's copy is sized to the larger of the two. * openxr: pick up a hinged headset screen still hinged Taking up a screen that rests in a hinge starts the carry on that hinge, whole from the first poll, with no buzz and no jump, until it leaves the hinge's reach, another hinge takes hold, or the other hand takes the screen it hinges on. Until the grab's own snapping has faded in, the kept hinge's target still pulls whole, so a straight pull out does not hop. The grab carries the hinge so both threads hold it the same; of several, the one the snap ranks best carries over, and only where holding it moves nothing. While the other screens fade in, the hinge's screen also leads the turn, so a nearer one still fading does not take it. * openxr: end a headset screen's hinge where a push passes the stop Pushing a hinged screen into its neighbour holds the edge at touching for 3 cm of push, fading out by 5.5 cm. Where it stops holding, the hinge ends: the line goes, the rims come back, and the lid and buzz are cleared, so screens pushed into each other show no hinge that a let-go there would not rest in. Pulled back, the hinge takes hold again 5 mm short of where it ended, with the long buzz, so a tremor there does not flicker it. The grab carries that through flag, and the frame loop keeps its line until the main thread sets it, so the two threads never disagree for more than a poll. At Hinge Gap 1 a pair let go touching rests hinged and is taken up hinged, as at every other gap. A screen swung into a square corner gets the long buzz on arrival, and the other hand taking the target does not hop the carried screen by the push's depth. * input: let go of a headset screen where it was before the grip opened Opening the grip twitches the hand, and the poll that sees the grip open would move the screen by that twitched aim. Half a degree of pitch moves a screen 1.8 m out by 1.6 cm, enough to knock it off its hinge's gap or out of level, so it would not rest hinged. Each hand keeps a short trail of where, turned and as large as its screen showed, entries at least 10 ms apart, and a grip let go puts the screen as it showed 80 ms before (INPUT_OPENXR_EDIT_REWIND_US), or as it was taken if held for less. Edit mode's end and a recenter let go where the screen shows. * openxr: find where a let-go headset screen settles in its hinge A screen let go while its hinge shows should land exactly in that hinge, so the hinge still shows at rest and a pick-up is hinged. video_xr_hinge_settle holds the hinge whole from the hand's pose, then moves the edge to the set gap from within 3 cm of it (touching stays where the stop holds it) and levels it along the edge within the level pull's reach. Its result must pass the rest test, and it turns no further than a grab's hinge engages, which shares that test. A pair resting inside a settle band but off its point is no longer listed at rest, since a pick-up and let-go would move it. A touching rest is taken 5 mm deeper into the push stop, at every Hinge Gap, so a hand that drifts less than that apart before letting go settles touching rather than at the gap. * openxr: settle a let-go headset screen into its hinge A screen let go while its hinge shows now goes exactly into that hinge: to the set gap from within 3 cm of it, touching from the stop's hold, and level along the edge from within the level pull's reach. It then rests there, listed and green, in the same publish, and is saved there. Elsewhere it stays where it shows, as before. Each trail entry also records where the hand put the screen with no snap and whether a let-go there settles. At the let-go the rewound entry is settled again against the screens as they are now, at that entry's size, and put in one go. * openxr: let a hinged headset screen rest at any fold Snap to Screens' turn to flat, and its turn to square at a corner, is whole within 5 degrees and fades out by 10, so a hinged screen held there shows at twice its angle off less 10. No fold shown in that fade read as a rest: the pair was not listed, a let-go there did not settle into its hinge, and taking it up would have moved it. Where a hand takes a rest, it now holds the screen at the angle the turn's fade shows it from, the inverse of the turn's pull, so every fold rests, is listed and is taken up unmoved. Held snapping is unchanged. * input: keep a headset screen's hinge through a shaking hand Edit Screens' hinge buzz, lid and push stop followed the snap's own engage and reach on every poll. A hand shaking half a degree (1.6 cm at the screen) about a hinge's edge flipped them many times a second, each flip a long buzz. Each hold now keeps one mark: the hinge a let-go would settle into. It takes hold at once, with the long buzz, and lets go only once polls have seen the hand out of where a let-go would settle for 150 ms, each poll counting at most 50 ms, so a stalled main thread or a spell untracked never lets it go alone. The other hand taking its target, hinged elsewhere or not, the target leaving and the let-go end it at once. The lid waits for the mark to go, the push stop follows it, and a let-go while it shows settles into it from where the hand last would have, edit mode's end and a recenter included. * openxr: draw a held screen's hinge as the main thread marks it The grab carries the main thread's hinge mark, and the frame loop draws a held screen's green line and cuts its rims from that mark alone, through video_xr_grab_marked, while it snaps the screen every frame. A frame loop taking the hinge by itself between polls would flicker the line for a hand shaking at the edge of the hinge's range while the mark held. A mark whose target the frame does not show cuts no rim. The other hand taking the mark's target ends it, and the lid, on any poll, tracked or not, so a lost hand's line does not come back when that hand lets go. video_xr_grab_near_hinge loses its past argument, which only the frame loop's keep used. * openxr: keep edit mode's hinge layers in place SteamVR does not keep submission order for overlapping quad layers, so a layer added, dropped or moved to another index can pop the edit outlines in front of the screens, as a wobble at a hinge would do to its line's layer. The hinge lines are fixed slots: one for each hand holding a screen, hand 0 first, then one for each pair at rest. A slot with no line to show is drawn in place from its screen's middle, at rows of the laser image that are empty either way up. The layer count and every index change only at a grab, a let-go or a re-count of the pairs at rest; a mark only changes crops and which rows a slot shows. * input: date a let-go's trail by frame and stop it at a stall Each trail entry is dated by the frame its aims are from, one a frame and per hand, and the release poll records a new frame's aims first. The rewind stops at a stall, entries more than 2.5 frames apart, a frame counted as at least 20 ms so a fast headset's close entries never read as one. Under load a stall of 0.1 to 0.3 s can come just before the release; the entry from 80 ms back would then hold the pose from before it and step the let-go back across all the stall's motion. With Edit Smoothing on, which damps the twitch, a let-go that does not settle into a hinge stays where and as large as it shows: a rewind there would step back by what the smoothed aim still lags. The hinge decision and the settle use the trail either way. * openxr: cut edit outlines from cells instead of turning them Cutting a top or bottom rim from the one outline image turns both outline quads a quarter turn and swaps their width and height, and on SteamVR that can blink every edit outline as the hinge takes hold or lets go; side cuts, which never turn, do not. The laser's image carries twelve pre-cut outline cells after the tags, faint and bright, for a cut top, bottom, left, right, top and bottom, or left and right, so a cut only picks a cell and the quads keep their pose and size. The image is then 5582 texels wide. A runtime whose swapchains are narrower, or that does not say how wide they can be, keeps the turned and cropped outline at 2498 or 1208 wide. One log line at the laser's creation gives the width chosen and the runtime's limit. GL writes the top and bottom cells swapped for its bottom-up rows, and Android's copy of the image is allocated rather than static. The edit-hinge-3ds-narrow e2e case runs the turned cut at RA_XR_LAYER_MAX_WIDTH=4096, on Vulkan and the GL EGL lanes. * video: draw headset screens straight into the runtime's images Each headset screen was drawn into an image of the driver's own and copied from it into the runtime's on every new frame, Vulkan with a render pass and GL3 with a blit. Screens are now drawn into the runtime's image itself, as before per-screen placement, with no image of the driver's and no copy. A screen drawn again with no new frame - resized, made again or moved while paused - replays the last frame's final pass from the chain: build_viewport_pass_replay draws it at the new size from what it read then, the passes' outputs, their feedback and the history that frame saw, with that frame's count. Nothing else runs, feedback does not swap and history stays, so a feedback or history preset holds still while paused. A chain made to replay keeps one more history image, so the frame's end writes where the last frame did not read; the window's chains keep what they did. This also has movie frames reach the headset, which the copy held at the first one, and draws a screen resized while paused at its new size rather than stretching the old image. * openxr: leave what users who never edit see as it was Screens seen from behind turn to their grey backs only while Edit Screens is on, where screens are turned around; outside it nothing changes and no head is located for them. The grabs carry whether editing is on. The menu opens at its own spot, straight ahead of the anchor, as it did. Menu in Front of Screen 1, off by default, keeps it just in front of screen 1 and moving with it. The frame loop copies the main thread's grabs only once their stamp moves, so outside edit mode no frame copies them. A new session clears the frame loop's own copy and passes over what was published before it, rather than publishing itself: the main thread stays the grabs' one writer. On Touch, the left menu button that opens the menu from edit mode is spent until let go: held on as edit mode ends, it is no Start and does not toggle the menu again after a second. --------- Co-authored-by: libretroadmin <[email protected]> |
||
|
|
c30af2cd3e |
tests: tests-other/ into samples/
The widget and autosave harnesses become samples of their own - samples/gfx/widget_snapshot_ownership, samples/gfx/widget_task_lifetime and samples/runloop/autosave_snapshot - each built and run by make check like the rest, the task lifetime test with the widget defines its stubs build against. The autoconf suite, its .ratst scripts and test input configs move to samples/input/test_input; the workflows that ran them follow. The SPIRV-Cross MSL binding testbench, which nothing built or ran, goes. |
||
|
|
bae87174dc |
3DS: the runtime moves to os/ctr, linear allocator in C
The tree's 3DS layer (the custom crt0 and link spec, system and memory setup, svchax, the old GPU command layer and the 3dsx/CIA launchers) lives under os/ctr, beside os/gekko and os/wiiu. The linear heap allocator is C: the same first-fit pool, so buffers land where they did, with live allocations found by address in an open-addressing table instead of a per-allocation tree node, and list nodes taken from cache-line-aligned slabs and reused. On the same trace it runs about half the instructions and practically no malloc/free calls. With the whole heap allocated, a further allocation now fails instead of starting the heap over and handing out its first address again, and the free-space queries no longer fault. samples/frontend/ctr_linear checks placement, alignment, coalescing, the full-heap case and pages handed back from the heap's end. |
||
|
|
8f1e421733 |
wiiu: take in what it used of libiosuhax, drop deps/libiosuhax
RetroArch used libiosuhax for three things: opening the IOSU handle and an FSA client in os/wiiu/main.c, the storage_usb devoptab, and the raw SD/USB sector access libfat reads sd: and usb: through. Those now live in os/wiiu/fs/iosuhax.c, with everything but what main.c and libfat call made static. deps/libiosuhax is gone. Never used, so not taken: IOSU memory and kernel read/write, the SVC call, volume flush, FSA mount/unmount (main.c always registered an already-mounted path), and chmod, which newlib never reached - the devoptab table had the chmod handler in the deviceData slot, which mount_fs then overwrote. The table now has newlib's order, as libfat's does. No locks: every FSA call is one IPC request the iosuhax server carries out on its own, and nothing is shared between threads once a device is mounted, so the per-device OS mutex is gone. The one shared resource left is a data buffer, claimed with a retro_atomic exchange; a thread that finds it held stages through the stack instead. No allocation per call: every call used to memalign one or two buffers, every path was malloc'd, and every directory entry too. Requests are now built in aligned stack buffers and paths written straight into them. File and sector data go through a stack buffer up to 1 KB, the shared 128 KB buffer made at mount up to that, and beyond it straight into the caller's buffer: the server puts its reply header in front of the data, so the 0x40 bytes in front of the stretch being read are kept aside and put back. A large ROM read no longer allocates a buffer its own size and copies it; the data is never copied. Bugs fixed: - statvfs had the device info call write 0x64 bytes into an 8-byte stack variable - stat read the path after freeing it - fstat passed the file state's address as the FSA file handle - open checked the wrong pointer for allocation failure - seek with an unknown origin returned with the mutex held - the device lookup used strtok, which is not thread safe - read reported an error as end of file; it now returns -1 - seeking from the end after writing past it used the old length Requests are byte for byte what libiosuhax sent: both were run on 32-bit big-endian PowerPC against a recorder and compared. The data paths were run against a fake server for every size and alignment, with the shared buffer free and held, short reads and reads past the end, under AddressSanitizer, with guard bytes around the caller's buffer. A compile-matrix lane now builds the file against a stand-in for newlib's sys/iosupport.h. |
||
|
|
e6e0404029 |
go2 drm context: take in what it used of libgo2, drop deps/libgo2
Only one file in RetroArch ever used libgo2: the ODROID-GO Advance GL context, gfx/drivers_context/drm_go2_ctx.c. The oga video driver already talks to librga and DRM itself, and libgo2's audio, input, backlight, PNG and queue code was never called. What the context used - open the panel, make the EGL/GBM surface, and have the RGA scale and rotate each frame into a portrait buffer for the CRTC - now lives in the context itself, and deps/libgo2 is gone. No thread, queue, mutex or semaphore remains. libgo2 ran a render thread, a mutex-guarded queue and two semaphores only to hide a full drmModeSetCrtc modeset every frame. Frames are now page-flipped with drmModePageFlip, which the kernel already does asynchronously, so the only wait left is for the previous flip to land before the next is queued - the vsync throttle itself - and the RGA work for the new frame runs before that wait instead of after it. That is also one frame less latency than the old three-deep queue. A driver that refuses page flips falls back to drmModeSetCrtc. Overhead taken out of the frame: - the whole-screen RGA colour fill before every blit is gone; the borders beside the picture are cleared once per buffer when the picture's size or position changes, and never when it fills the panel - each GBM buffer's prime fd is exported once and kept on the buffer (gbm_bo user data) instead of a per-frame search of a malloc'd list - the scanout buffers' fds, strides and formats are worked out at init, not per blit - nothing is allocated per frame With vsync off (swap interval 0, e.g. fast-forward) a frame whose flip would have to wait is not shown rather than waited for, so the core runs uncapped without tearing; before, the interval was ignored. The EGL context now comes from egl_common like drm_ctx's, so egl_bind_hw_render works on it (a hardware core gets its shared context) instead of being handed an empty egl_ctx_data_t. It is still GLES 3. Fixed on the way: the context data was never freed, prime fds were leaked, and the console's CRTC is put back on exit. -lpng and -lz are no longer linked for HAVE_ODROIDGO2; only libgo2's unused PNG writer needed them. A compile-matrix lane now builds the context against the librga stand-in; nothing compiled it before. |
||
|
|
5361e1bc8f |
netplay: lockstep for cores whose states are too large to roll back
Rollback keeps a savestate for every buffered frame and serializes every frame, which a state in the tens of megabytes (Dolphin) cannot afford, and needs states that restore deterministically enough to rewind on. Lockstep runs a frame only once every player's real input for it has arrived and never rewinds, so all delta frames share one state, used only to hand a joiner the game or to resync. Desync checks hash the core's system RAM, or the RAM in its memory map, rather than a whole state; a state is serialized for them only when the core shows neither. Input latency rises by a frame whenever lockstep has to wait and falls again once input keeps arriving early, so it holds full speed over a slow link. A host keeps sending while it waits on a joiner, grows its buffers if the core's state has grown, and starts on the running game instead of reloading it. A client takes a state labeled with a frame whose input it already has, and loads it there. Lockstep is a local choice and plays with rollback peers of this protocol, and it is on by itself for cores past 32 MB of state and for cores whose savestates load but cannot be rewound on, which netplay used to refuse. The Lockstep setting asks for it everywhere. Older clients cannot join a lockstep host. samples/network/netplay_e2e runs a host and a client over the loopback on a test core: sticks synced or not, lockstep, a lockstep host with a rollback client, a desync mended and a 40 MB state. |
||
|
|
a0d408f0ce |
netplay: sync the analog sticks of joypad ports
Netplay sent a joypad port's buttons only, so a core reading the sticks of a joypad port (N64, GameCube and others) desynced or saw them at rest on every remote player. The host now sends joypad ports as analog, three words instead of one, with bit 30 marking them; each side hands the core the joypad device it set, so nothing changes for the core. This is protocol 8. A host with Sync Analog Sticks on, the default, turns away older clients with the out-of-date message rather than letting them desync; with it off, any version still joins. |
||
|
|
5c82bce0ed |
overlay: D-pad and face buttons read a finger's contact area (Android)
A touchscreen reports each finger as an ellipse, not a point; Android gives its axes and orientation (AMotionEvent_getTouchMajor/Minor and getOrientation). A thumb laid across up and right, or resting between two face buttons, covers both - and read by its centre alone presses one. After RetroArch-Lite's contact-area input. "D-Pad Input Method" and "ABXY Input Method" choose how each reads a touch: "Direction" - the way the centre lies, as always, and the default - "Contact Area", every way the contact covers, or "Both". Each tip of the ellipse's two axes presses the way it lies from the area's middle, past a small dead zone there. "Contact Area Size" scales how large a contact counts. Measured in pixels per axis against the pointer's own space; RetroArch-Lite measured both against the screen's height, which skews a contact on a wide screen. Android's reader keeps each pointer's contact beside its position, and the driver hands them to the frontend each poll (input_driver_publish_touch_contacts). A finger with no contact size, and every other driver, read by the centre's way. The rows show on Android, where an overlay has the area they apply to. overlay_contact_test holds the geometry: fingertips, thumbs across two ways, upright and level contacts, magnification, wide screens. |
||
|
|
9ec7de02d3 |
feat(ps3): add native libretro RSX hardware rendering support
Expose an experimental libretro RSX context and versioned rendering interface for PSL1GHT cores. Present core-owned RSX textures without CPU uploads, share the command FIFO and unused host mapping, and defer allocation retirement until queued GPU work completes. Integrate context negotiation and enforce main-thread rendering. Restore frontend GPU state before compositing and use fenced per-font vertex pages to prevent oversized Ozone batches from corrupting queued text. Invalidate the vertex cache before menu and font draws. Make the RSX host allocation configurable at build time. Extend regression coverage for hardware image validation, deferred resource retirement, oversized font batches and allocation failures. |
||
|
|
ed0a530640 |
settings: refresh the hotkey tap delay reference
Include the registered input_hotkey_tap_delay default in every emitted configuration profile. Settings behavior is unchanged. |
||
|
|
18b7d1867a |
deflate64: use overlap-safe bulk copies and retire stale exceptions
Keep periodic LZ matches on the bytewise path and use memmove for bulk matches. Remove obsolete copy-check exceptions. |
||
|
|
e2e41947cc | settings: refresh the stylus overlay default reference | ||
|
|
8235b3cc2f |
tools/console_objects_check.sh: see the crypto objects Makefile.common names
Object lists name libretro-common through $(LIBRETRO_COMM_DIR), so the crypto check matched nothing; the variable is expanded before matching. GameCube, Wii and PS2 may build crypto.o alone, the ciphers the RetroAchievements hashes use, and are refused the KDFs, public-key code and X.509. |
||
|
|
967d4dcacf |
menu: bypass VC8 optimizer for dialog initialization
Limit the optimizer workaround to MSVC 2005 and restore optimization before the next function. Check both mixer configurations and adjacent compiler versions in CI, including a missing-guard failure control. The native VC8 build is still required to confirm the reported C1001 is resolved. |
||
|
|
1a7b080dca |
cheevos: hash RVZ images through formats/rvz
cheevos_rvz.c is replaced by a small adapter in cheevos.c that hands rc_hash the new reader's seek, tell and read. The console comes, as before, from the disc header's Wii or GameCube magic word. Against the old reader, on images whose ISOs are known: - Hashes it got right come out the same. On Wii images rc_hash is 7.2 to 7.9 times faster, with rcheevos' own MD5 now most of what is left. GameCube is about even, the time there being MD5's too. - The old reader dropped a group's hash exceptions, so a Wii image with any came out with the wrong sectors. With chunks over 2 MiB it read one exception list too few from a short group, shifting that group's data by two octets, and the hash came out wrong. Both now come out as their ISOs do. - It returned reads shorter than asked inside an image; rc_hash does not loop on a short read. rc_hash keeps the file reader it was given from one load to the next. After an RVZ, a disc image of another kind was opened with the RVZ reader and its hash failed. The reader is now set on every load: the RVZ one for a file it takes, the default otherwise. The reader needs AES to encrypt Wii partitions again. A build without the crypto library, Wii and Wii U among them, links crypto.o for it alone, without HAVE_CRYPTO or the rest of the library. HAVE_CHEEVOS_RVZ still follows HAVE_RZSTD, and configure now turns it off with cheevos or RZSTD. |
||
|
|
00a3de3cd7 |
Temporal upscaler: HAVE_TEMPORAL_UPSCALER gates the subsystem
HAVE_NGX gated the whole temporal upscaler - the interface handed to cores, the settings, the threaded wrapper's carry and the DLSS, FSR and XeSS backends alike - under the name of one vendor's library. A MetalFX backend on the Metal driver would have to be built under a define that reads as NVIDIA's. The subsystem is now HAVE_TEMPORAL_ UPSCALER wherever HAVE_NGX stood, in the build files, the drivers, the menu, the samples and the compile matrix; nothing changes in what is built. |