Commit Graph

9076 Commits

Author SHA1 Message Date
Twinaphex
5e1ec17742
Merge pull request #7804 from fr500/fixes
reset on hardcore enable
2018-12-26 04:45:43 +01:00
orbea
476abf7dad materialui: Move 'Start Core' before 'Load Core'.
This matches other menu drivers better where its already like this in
rgui, xmb and ozone.
2018-12-24 15:32:24 -08:00
radius
90d816f31a reset on toggle everytime 2018-12-23 16:24:18 -05:00
orbea
d51b801221 ozone: Fix crash with menu_use_preferred_system_color_theme.
Fixes https://github.com/libretro/RetroArch/issues/7805
2018-12-23 11:41:43 -08:00
radius
6eae0df010 reset on hardcore enable 2018-12-23 11:16:55 -05:00
Twinaphex
c46e3468e2
Merge pull request #7796 from orbea/xmb
xmb: Don't show a black background without assets.
2018-12-23 13:39:33 +01:00
radius
0b8e39dd6b fix #7002 2018-12-22 20:36:42 -05:00
orbea
45c85aa6fe xmb: Don't show a black background without assets.
This also now only hides the time icon instead of the entire time
without assets.

Fixes https://github.com/libretro/RetroArch/issues/7795
2018-12-22 15:51:43 -08:00
Twinaphex
f353feba8a
Merge pull request #7789 from jdgleaver/buff-size-fix
Fix gcc -Wformat-truncation= warning (redux)
2018-12-22 19:45:24 +01:00
Twinaphex
326395ff17
Merge pull request #7794 from orbea/load
menu: Reset position after pushing quick menu.
2018-12-22 19:45:08 +01:00
Twinaphex
1df95bb28b
Merge pull request #7793 from fr500/fixes
move core sideloading to load core menu
2018-12-22 19:44:45 +01:00
orbea
4da7092aff menu: Reset position after pushing quick menu.
Fixes:
  https://github.com/libretro/RetroArch/issues/5595
  https://github.com/libretro/RetroArch/issues/2506
2018-12-21 18:43:14 -08:00
radius
c70e322496 cleanup 2018-12-21 18:19:48 -05:00
radius
09deb96397 move core sideloading to load core menu 2018-12-21 18:17:17 -05:00
jdgleaver
c2d4b70f8c menu_displaylist_parse_options_remappings(): increase buffer sizes, remove string precision qualifier (alternative to PR #7782) 2018-12-21 16:12:20 +00:00
orbea
2ab78dc67b menu: Use the default dir for recording output when unset. 2018-12-20 16:13:10 -08:00
Twinaphex
1d3874a142
Merge pull request #7779 from jdgleaver/rgui-colours
(RGUI) Enable customisation of background and border colours
2018-12-20 20:51:12 +01:00
Twinaphex
3bd1c3fa6a
Merge pull request #7782 from orbea/format
Fix gcc -Wformat-truncation= warning.
2018-12-20 20:49:37 +01:00
orbea
e6eedd05f5 Fix gcc -Wformat-truncation= warning.
menu/menu_displaylist.c: In function ‘menu_displaylist_ctl’:
menu/menu_displaylist.c:3441:28: warning: ‘ [’ directive output may be truncated writing 2 bytes into a region of size between 1 and 255 [-Wformat-truncation=]
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                            ^~
menu/menu_displaylist.c:3441:25: note: using the range [0, 4294967295] for directive argument
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                         ^~~~~~~~~~~~
menu/menu_displaylist.c:3440:16: note: ‘snprintf’ output 6 or more bytes (assuming 260) into a destination of size 255
                snprintf(desc_label, sizeof(desc_label),
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         "%s [%s %u]", descriptor, msg_hash_to_str(MENU_ENUM_LABEL_VALUE_USER), p + 1);
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2018-12-20 11:45:48 -08:00
orbea
5175c67381 menu: Fix directory settings.
The "Recording Output" and "Screenshot" directory settings accidentally
overwrote each other.

Fixes https://github.com/libretro/RetroArch/issues/7776
2018-12-20 11:13:28 -08:00
jdgleaver
f603d4ec30 (RGUI) Enable customisation of background and border colours 2018-12-20 16:13:16 +00:00
Brad Parker
458bb9fbb5 add option to toggle menu by holding down start button 2018-12-19 14:53:17 -05:00
Twinaphex
26568a6bc2
Merge pull request #7770 from jdgleaver/rgui-user-index
(RGUI) Add user index label to control menu entries
2018-12-19 17:47:53 +01:00
jdgleaver
f68d756af3 (RGUI) Add user index label to control menu entries 2018-12-19 12:19:29 +00:00
Stuart Carnie
11a7d34358
fix: animations deleted during update mutate tween list, causing crash
defer deletes resulting from callbacks until after update loop
2018-12-18 17:12:19 -07:00
Twinaphex
22fcd0be67
Merge pull request #7762 from orbea/rgui
Fix gcc -Wformat-truncation= warnings.
2018-12-18 10:12:50 +01:00
Brad Parker
4b323a45df paths can be const 2018-12-17 09:38:12 -05:00
Brad Parker
971591fb9c use filestream/VFS for core sideload 2018-12-17 09:25:52 -05:00
orbea
13e29308d5 Fix gcc -Wformat-truncation= warnings.
menu/drivers/rgui.c: In function ‘rgui_render’:
menu/drivers/rgui.c:670:53: warning: ‘%-*s’ directive output may be truncated writing up to 2147483648 bytes into a region of size between 0 and 252 [-Wformat-truncation=]
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                                     ^~~~
menu/drivers/rgui.c:676:13:
             type_str_buf);
             ~~~~~~~~~~~~
menu/drivers/rgui.c:670:42: note: assuming directive output of 254 bytes
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                          ^~~~~~~~~~~~~~~~
menu/drivers/rgui.c:670:7: note: ‘snprintf’ output between 4 and 4294967300 bytes into a destination of size 255
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_selected ? '>' : ' ',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_title_buf,
             ~~~~~~~~~~~~~~~~
             entry_spacing,
             ~~~~~~~~~~~~~~
             type_str_buf);
             ~~~~~~~~~~~~~
menu/drivers/rgui.c:670:53: warning: ‘%-*s’ directive output may be truncated writing up to 2147483648 bytes into a region of size between 0 and 252 [-Wformat-truncation=]
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                                     ^~~~
menu/drivers/rgui.c:676:13:
             type_str_buf);
             ~~~~~~~~~~~~
menu/drivers/rgui.c:670:42: note: assuming directive output of 254 bytes
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
                                          ^~~~~~~~~~~~~~~~
menu/drivers/rgui.c:670:7: note: ‘snprintf’ output between 4 and 4294967300 bytes into a destination of size 255
       snprintf(message, sizeof(message), "%c %-*.*s %-*s",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_selected ? '>' : ' ',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             (int)(RGUI_TERM_WIDTH(fb_width) - (entry_spacing + 1 + 2) - entry_title_buf_utf8len + entry_title_buf_len),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             entry_title_buf,
             ~~~~~~~~~~~~~~~~
             entry_spacing,
             ~~~~~~~~~~~~~~
             type_str_buf);
             ~~~~~~~~~~~~~
2018-12-16 20:22:53 -08:00
Twinaphex
af0bf7a992
Merge pull request #7761 from orbea/c89
Fix gcc warnings with C89_BUILD.
2018-12-17 05:18:13 +01:00
Twinaphex
6dcdb843e8
Merge pull request #7758 from fr500/sideload
Sideload
2018-12-17 05:15:41 +01:00
orbea
169002ef7f Fix a gcc -Wformat= warning with C89_BUILD.
The posix spec claims "%r" is equivelent to "%I : %M : %S %p".

Source: http://pubs.opengroup.org/onlinepubs/9699919799/functions/strftime.html

menu/menu_driver.c:395:15: warning: ISO C90 does not support the ‘%r’ gnu_strftime format [-Wformat=]
             "%r", localtime(&time_));
               ^
2018-12-16 19:59:47 -08:00
twinaphex
862a4e099b Duplicate entry removed 2018-12-17 00:07:35 +01:00
radius
6c936274b7 make file copy operation a function
add sublabels

improve localization
2018-12-16 16:55:12 -05:00
Twinaphex
708c9c0774
Merge pull request #7754 from orbea/c89
Fix C89 build with clang.
2018-12-16 19:47:17 +01:00
Twinaphex
fc6b3b7335
Merge pull request #7755 from fr500/fixes
subsystem: remember last used folder
2018-12-16 19:46:01 +01:00
radius
16d1cf28f7 only show with advanced options and on dynamic platforms 2018-12-16 12:42:10 -05:00
radius
bfd23150b5 add core sideloading option 2018-12-16 12:42:09 -05:00
radius
319124c7a0 subsystem: remember last used folder 2018-12-16 12:33:27 -05:00
orbea
6e95a62fdf Fix c89 build with clang. 2018-12-16 07:02:14 -08:00
orbea
f4a5c3bd55 Fix c89 build. 2018-12-15 21:03:28 -08:00
Stuart Carnie
c00b6e0750
fix: Fix use of freed memory in menu animations
`menu_animation_update` enumerates `menu_animation.list` to process each
`tween`. It was observed that some tweens execute a callback that
pushes more animations via `menu_animation_push`. During the push, if
the tween `list` does not have enough space, a `realloc` occurs,
potentially invalidating the existing list. The remaining pointer access
in menu_animation_update is therefore invalid. Best case is the memory
is unused and thus does not affect the program. Worst case is memory
corruption.
2018-12-15 14:55:10 -07:00
Twinaphex
90abb7846a
Merge pull request #7740 from orbea/hide
menu: Add 'Show Start Recording' and 'Show Start Streaming'.
2018-12-15 18:09:10 +01:00
orbea
2ea6d5a060 Fix c89 build. 2018-12-14 15:41:52 -08:00
orbea
2646e49eb4 menu: Add 'Show Start Recording' and 'Show Start Streaming'.
Fixes https://github.com/libretro/RetroArch/issues/7739

These options are located at:

  Settings -> User Interface -> Views -> Quick Menu -> Show Start Recording

and

  Settings -> User Interface -> Views -> Quick Menu -> Show Start Streaming

The quick menu options 'Stop Recording' and 'Stop Streaming' are
intentionally not hidden to prevent users from silently recording or
streaming without realizing.
2018-12-13 18:40:32 -08:00
radius
ced0f09f0e start at the current loaded content dir for subsystem and disk image append 2018-12-10 23:51:41 -05:00
radius
7a36190a0e cleanup filebrowser too 2018-12-10 23:20:27 -05:00
radius
45228d0307 massive subsystem cleanup & use the proper data in each instance 2018-12-10 23:01:21 -05:00
radius
cad5ae287f fix https://github.com/libretro/fbalpha/issues/24#issuecomment-445803876 2018-12-10 22:09:42 -05:00
jdgleaver
11391d601c Hide 'scan content' entries from Collections menu when 'Show Import content Tab' is disabled (RGUI, GLUI) 2018-12-10 17:01:13 +00:00