mirror of
https://github.com/libretro/RetroArch.git
synced 2026-11-21 12:29:43 -10:00
The previous fix added image: nil to the synonyms-bearing DisplayRepresentation call, but the build still failed with: RetroArchAppShortcuts.swift Extra argument 'synonyms' in call No synonyms-bearing DisplayRepresentation initializer that also takes a subtitle is callable across the SDKs/deployment targets RetroArch builds against, so overload resolution falls back to init(title:subtitle:image:) and reports synonyms as extra. The symbol is absent at compile time, so an #available guard cannot rescue it. Drop the synonyms argument from DisplayRepresentation; the synonyms remain stored and continue to drive GameMatchingEngine (entities(matching:)) for fuzzy game-name resolution, which is the path that actually consumes them. This also fixes: Stored property 'displayRepresentation' of 'Sendable'-conforming struct 'GameEntity' has non-sendable type 'DisplayRepresentation' AppEntity refines Sendable, but the representation was a stored property and DisplayRepresentation is not Sendable. Store the game title instead and compute displayRepresentation on demand (the AppEntity requirement is get-only), deriving the system-context subtitle from the stored systemName/coreName. All stored fields are now Sendable. The three matcher call sites that read the title via displayRepresentation.title now read the stored title directly, avoiding construction of a throwaway DisplayRepresentation inside the sort/match loops.