mirror of
https://github.com/libretro/RetroArch.git
synced 2024-12-01 04:00:32 +00:00
13cf3cdef2
This is a potential security issue. The problem is that config.h and config.mk are populated with all variables prefixed with 'HAVE_' from the user's environment. Example: $ HAVE_FOO=yes ./configure $ grep FOO config.mk HAVE_FOO = 1 $ grep FOO config.h #define HAVE_FOO 1 After this commit these files will only use variables set by qb configure process and not from the user's environment. This issue could result in hard to diagnose undefined behavior or maybe worse? The user should experience no change in behavior, but developers should be more careful about setting 'HAVE_' variables manually. Unless the FOO variable is used by check_enabled ($2 only), check_platform, check_lib, check_pkgconf, check_header, check_macro or check_switch functions it should be set at least once by the new add_opt function. The first argument should be 'FOO' which matches the HAVE_FOO variable and the second argument should contain 'auto', 'no' or 'yes'. Example: add_opt FOO yes When in doubt its safe to use add_opt. This will also fix a few potential issues where configure arguments used by the user are ignored. When the second argument is not set the FOO variable will only be used to populate config.h and config.mk with its current value. This should only be done in qb/qb.libs.sh in functions that set 'HAVE_' variables.
111 lines
2.5 KiB
Bash
111 lines
2.5 KiB
Bash
. qb/config.comp.sh
|
|
|
|
TEMP_C=.tmp.c
|
|
TEMP_CXX=.tmp.cxx
|
|
TEMP_EXE=.tmp
|
|
|
|
CC="${CC:-}"
|
|
CXX="${CXX:-}"
|
|
PKG_CONF_PATH="${PKG_CONF_PATH:-}"
|
|
WINDRES="${WINDRES:-}"
|
|
|
|
# Checking for working C compiler
|
|
cat << EOF > "$TEMP_C"
|
|
#include <stdio.h>
|
|
int main(void) { puts("Hai world!"); return 0; }
|
|
EOF
|
|
|
|
cc_works=0
|
|
add_opt CC no
|
|
if [ "$CC" ]; then
|
|
"$CC" -o "$TEMP_EXE" "$TEMP_C" >/dev/null 2>&1 && cc_works=1
|
|
else
|
|
for cc in gcc cc clang; do
|
|
CC="$(exists "${CROSS_COMPILE}${cc}")" || CC=""
|
|
if [ "$CC" ]; then
|
|
"$CC" -o "$TEMP_EXE" "$TEMP_C" >/dev/null 2>&1 && {
|
|
cc_works=1; break
|
|
}
|
|
fi
|
|
done
|
|
fi
|
|
|
|
rm -f -- "$TEMP_C" "$TEMP_EXE"
|
|
|
|
cc_status='does not work'
|
|
if [ "$cc_works" = '1' ]; then
|
|
cc_status='works'
|
|
HAVE_CC='yes'
|
|
elif [ -z "$CC" ]; then
|
|
cc_status='not found'
|
|
fi
|
|
|
|
printf %s\\n "Checking for suitable working C compiler ... $CC $cc_status"
|
|
|
|
if [ "$cc_works" = '0' ] && [ "$USE_LANG_C" = 'yes' ]; then
|
|
die 1 'Error: Cannot proceed without a working C compiler.'
|
|
fi
|
|
|
|
# Checking for working C++
|
|
cat << EOF > "$TEMP_CXX"
|
|
#include <iostream>
|
|
int main() { std::cout << "Hai guise" << std::endl; return 0; }
|
|
EOF
|
|
|
|
cxx_works=0
|
|
add_opt CXX no
|
|
if [ "$CXX" ]; then
|
|
"$CXX" -o "$TEMP_EXE" "$TEMP_CXX" >/dev/null 2>&1 && cxx_works=1
|
|
else
|
|
for cxx in g++ c++ clang++; do
|
|
CXX="$(exists "${CROSS_COMPILE}${cxx}")" || CXX=""
|
|
if [ "$CXX" ]; then
|
|
"$CXX" -o "$TEMP_EXE" "$TEMP_CXX" >/dev/null 2>&1 && {
|
|
cxx_works=1; break
|
|
}
|
|
fi
|
|
done
|
|
fi
|
|
|
|
rm -f -- "$TEMP_CXX" "$TEMP_EXE"
|
|
|
|
cxx_status='does not work'
|
|
if [ "$cxx_works" = '1' ]; then
|
|
cxx_status='works'
|
|
HAVE_CXX='yes'
|
|
elif [ -z "$CXX" ]; then
|
|
cxx_status='not found'
|
|
fi
|
|
|
|
printf %s\\n "Checking for suitable working C++ compiler ... $CXX $cxx_status"
|
|
|
|
if [ "$cxx_works" = '0' ] && [ "$USE_LANG_CXX" = 'yes' ]; then
|
|
die : 'Warning: A working C++ compiler was not found, C++ features will be disabled.'
|
|
fi
|
|
|
|
if [ "$OS" = "Win32" ]; then
|
|
echobuf="Checking for windres"
|
|
if [ -z "$WINDRES" ]; then
|
|
WINDRES="$(exists "${CROSS_COMPILE}windres")" || WINDRES=""
|
|
[ -z "$WINDRES" ] && die 1 "$echobuf ... Not found. Exiting."
|
|
fi
|
|
printf %s\\n "$echobuf ... $WINDRES"
|
|
fi
|
|
|
|
if [ -z "$PKG_CONF_PATH" ]; then
|
|
PKG_CONF_PATH="none"
|
|
for pkgconf in pkgconf pkg-config; do
|
|
PKGCONF="$(exists "${CROSS_COMPILE}${pkgconf}")" || PKGCONF=""
|
|
[ "$PKGCONF" ] && {
|
|
PKG_CONF_PATH="$PKGCONF"
|
|
break
|
|
}
|
|
done
|
|
fi
|
|
|
|
printf %s\\n "Checking for pkg-config ... $PKG_CONF_PATH"
|
|
|
|
if [ "$PKG_CONF_PATH" = "none" ]; then
|
|
die : 'Warning: pkg-config not found, package checks will fail.'
|
|
fi
|