libretro/beetle-gba-libretro
1
0
Fork 0
mirror of https://github.com/libretro/beetle-gba-libretro.git synced 2024-11-27 02:20:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix update_input() loop boundaries

Browse Source 
Prevent the for loop to go beyond the button array's boundaries.

This prevent crashes in frontends when a button number corresponding to
a random value in memory is asked for its value.
This commit is contained in:
Adrien Plazas 2015-08-27 19:05:05 +02:00
parent f0c2b8056b
commit 18067d534b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libretro.cpp
View File

@ -3706,6 +3706,7 @@ static void update_input(void)
{
MDFNGI *currgame = (MDFNGI*)game;
input_buf = 0;
size_t map_size = 10;
static unsigned map[] = {
RETRO_DEVICE_ID_JOYPAD_A, //A button
RETRO_DEVICE_ID_JOYPAD_B, //B button
@ -3719,7 +3720,7 @@ static void update_input(void)
RETRO_DEVICE_ID_JOYPAD_L,
};
for (unsigned i = 0; i < MAX_BUTTONS; i++)
for (unsigned i = 0; i < map_size; i++)
input_buf |= map[i] != -1u &&
input_state_cb(0, RETRO_DEVICE_JOYPAD, 0, map[i]) ? (1 << i) : 0;