diff --git a/nall/snes/cartridge.hpp b/nall/snes/cartridge.hpp index dc08f36..5d84e29 100644 --- a/nall/snes/cartridge.hpp +++ b/nall/snes/cartridge.hpp @@ -125,7 +125,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { if(type == TypeGameBoy) { xml << "\n"; if(gameboy_ram_size(data, size) > 0) { - xml << " \n"; + xml << " \n"; } xml << "\n"; xmlMemoryMap = xml.transform("'", "\""); @@ -159,7 +159,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; xml << " \n"; } else if(has_cx4) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -178,9 +178,9 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -205,7 +205,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; if(ram_size > 0) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; if((rom_size > 0x200000) || (ram_size > 32 * 1024)) { @@ -226,7 +226,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; if(ram_size > 0) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; if((rom_size > 0x200000) || (ram_size > 32 * 1024)) { @@ -244,7 +244,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; if(ram_size > 0) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -252,14 +252,14 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { } } else if(mapper == ExHiROM) { xml << " \n"; - xml << " \n"; - xml << " \n"; - xml << " \n"; - xml << " \n"; + xml << " \n"; + xml << " \n"; + xml << " \n"; + xml << " \n"; xml << " \n"; if(ram_size > 0) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; if((rom_size > 0x200000) || (ram_size > 32 * 1024)) { @@ -277,10 +277,10 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; xml << " \n"; xml << " \n"; - xml << " \n"; - xml << " \n"; + xml << " \n"; + xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -301,11 +301,11 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -315,12 +315,12 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; } else if(mapper == BSCLoROM) { xml << " \n"; - xml << " \n"; - xml << " \n"; - xml << " \n"; - xml << " \n"; + xml << " \n"; + xml << " \n"; + xml << " \n"; + xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -336,7 +336,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -373,7 +373,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -383,7 +383,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { xml << " \n"; xml << " \n"; xml << " \n"; - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -411,7 +411,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { } if(has_dsp1) { - xml << " \n"; + xml << " \n"; if(dsp1_mapper == DSP1LoROM1MB) { xml << " \n"; xml << " \n"; @@ -444,7 +444,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { } if(has_dsp2) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -457,7 +457,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { } if(has_dsp3) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -470,7 +470,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { } if(has_dsp4) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -490,7 +490,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { } if(has_st010) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; @@ -507,7 +507,7 @@ SNESCartridge::SNESCartridge(const uint8_t *data, unsigned size) { } if(has_st011) { - xml << " \n"; + xml << " \n"; xml << " \n"; xml << " \n"; xml << " \n"; diff --git a/snes/cartridge/xml.cpp b/snes/cartridge/xml.cpp index 4ad7936..d0162f2 100644 --- a/snes/cartridge/xml.cpp +++ b/snes/cartridge/xml.cpp @@ -397,7 +397,7 @@ void Cartridge::xml_parse_hitachidsp(xml_element &root) { if(fp.open(path, file::mode_read) == false) { system.interface->message(string( "Warning: Hitachi DSP data ", dataROM, " is missing." )); } else if(fp.size() != 1024 * 3) { - system.interface->message(string( "Warning: Hitachi DSP data ", dataROM, " is of the wrong file size." )); + system.interface->message(string( "Warning: Hitachi DSP data ", dataROM, " is of the wrong file size (got: ", (unsigned)fp.size(), " bytes)" )); fp.close(); } else { for(unsigned n = 0; n < 1024; n++) hitachidsp.dataROM[n] = fp.readl(3); diff --git a/snes/libsnes/libsnes.cpp b/snes/libsnes/libsnes.cpp index 6a5551a..f4b1bdc 100644 --- a/snes/libsnes/libsnes.cpp +++ b/snes/libsnes/libsnes.cpp @@ -17,24 +17,23 @@ struct Interface : public SNES::Interface { unsigned height = overscan ? 239 : 224; if(interlace) height <<= 1; data += 9 * 1024; //skip front porch - if(pvideo_refresh) return pvideo_refresh(data, width, height); + return pvideo_refresh(data, width, height); } void audio_sample(uint16_t left, uint16_t right) { - if(paudio_sample) return paudio_sample(left, right); + return paudio_sample(left, right); } void input_poll() { - if(pinput_poll) return pinput_poll(); + return pinput_poll(); } int16_t input_poll(bool port, SNES::Input::Device::e device, unsigned index, unsigned id) { - if(pinput_state) return pinput_state(port, (unsigned)device, index, id); - return 0; + return pinput_state(port, (unsigned)device, index, id); } void message(const string &text) { - print(text, "\n"); + fprintf(stderr, "%s\n", (const char*)text); } string path(SNES::Cartridge::Slot::e slot, const string &hint) {